From: Michael Tokarev <mjt@tls.msk.ru>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event system changes
Date: Tue, 22 May 2012 20:31:32 +0400 [thread overview]
Message-ID: <4FBBBF64.5010607@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAN05THR5Wt5RPkyNfddQ+8HM8dVYAXk39nDvqk0_qr==4r-1wg@mail.gmail.com>
On 22.05.2012 14:03, ronnie sahlberg wrote:
[]
>>> Doh, now I remember. Whenever you change the aio handlers you need to
>>> call qemu_notify_event() afterwards, if the handler may fire right away.
>>
>> Thanks. I just confirmed that qemu_notify_event() fixes the issue.
>> Ill send a patch that uses qemu_notify_event() and a comment why this is needed.
When I were writing network block driver I tried to not call qemu_aio_set_fd_handler()
unless absolutely necessary -- that is, trying to write as much as possible till
the next write returns EAGAIN, or to read till the next read returns EAGAIN. This
way there's no need to call qemu_notify_event(). FWIW.
/mjt
next prev parent reply other threads:[~2012-05-22 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 6:07 [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event system changes ronnie sahlberg
2012-05-21 10:45 ` Kevin Wolf
2012-05-21 10:59 ` Paolo Bonzini
2012-05-21 11:00 ` ronnie sahlberg
2012-05-21 13:20 ` Stefan Hajnoczi
2012-05-22 9:07 ` ronnie sahlberg
2012-05-22 9:15 ` Paolo Bonzini
2012-05-22 9:15 ` ronnie sahlberg
2012-05-22 9:29 ` Paolo Bonzini
2012-05-22 9:48 ` ronnie sahlberg
2012-05-22 10:03 ` ronnie sahlberg
2012-05-22 16:31 ` Michael Tokarev [this message]
2012-05-25 6:53 ` ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBBBF64.5010607@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.