From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code. Date: Tue, 22 May 2012 14:02:17 -0500 Message-ID: <4FBBE2B9.6030304@sandeen.net> References: <1337500880.16053.YahooMailNeo@web192405.mail.sg3.yahoo.com> <1337570918.78986.YahooMailNeo@web192406.mail.sg3.yahoo.com> <20120521233133.GG12339@thunk.org> <4FBBBA98.9090101@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Ted Ts'o , Linus Torvalds , manish honap , "adilger.kernel@dilger.ca" , "linux-fsdevel@vger.kernel.org" , linux-ext4@vger.kernel.org To: Eric Sandeen Return-path: Received: from sandeen.net ([63.231.237.45]:53148 "EHLO mail.sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760172Ab2EVTCS (ORCPT ); Tue, 22 May 2012 15:02:18 -0400 In-Reply-To: <4FBBBA98.9090101@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 5/22/12 11:11 AM, Eric Sandeen wrote: > On 5/21/12 6:31 PM, Ted Ts'o wrote: >> On Mon, May 21, 2012 at 03:22:28PM -0700, Linus Torvalds wrote: >>> >>> So I'm pretty sure this patch is what we want, and rw_verify_area() >>> really is required to protect low-level filesystems from these kinds >>> of issues. Not just ext4. >>> >>> At the same time, I would *really* want somebody who actually uses >>> anything AIO to test it out too. Because I want to not only commit it, >>> but also mark it for stable - and it would be nice to have some more >>> testing than me saying "ok, it passes the one test-case sent to me" >>> and "hey, the code looks sane". > > Just FWIW, the ext4_file_write() part of this fix was sent by Zheng Liu on 4/12/12: > > [PATCH RESEND] ext4: change return value from int to ssize_t in ext4_file_write Sorry, I was talking about Manish's original patch, not Linus's followup. -Eric > I'll see about writing an xfstest for this stuff too so it doesn't regress again. > > -Eric >