From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60342)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SWviw-0000ka-Us
	for qemu-devel@nongnu.org; Tue, 22 May 2012 16:30:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SWviv-0007Me-8C
	for qemu-devel@nongnu.org; Tue, 22 May 2012 16:30:30 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:60089)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SWviv-0007MZ-1W
	for qemu-devel@nongnu.org; Tue, 22 May 2012 16:30:29 -0400
Message-ID: <4FBBF762.3070009@weilnetz.de>
Date: Tue, 22 May 2012 22:30:26 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1336666788-30233-1-git-send-email-jim@meyering.net>	<1336666788-30233-2-git-send-email-jim@meyering.net>
	<4FABFAA1.5070307@siemens.com>
In-Reply-To: <4FABFAA1.5070307@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.1 1/2] kvm/apic: correct short memset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jim Meyering <meyering@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Avi Kivity <avi@redhat.com>

Am 10.05.2012 19:28, schrieb Jan Kiszka:
> On 2012-05-10 13:19, Jim Meyering wrote:
>    
>> From: Jim Meyering<meyering@redhat.com>
>>
>> kvm_put_apic_state's attempt to clear *kapic before setting its
>> bits cleared sizeof(void*) bytes (no more than 8) rather than the
>> intended 1024 (KVM_APIC_REG_SIZE) bytes. Spotted by coverity.
>>
>> Signed-off-by: Jim Meyering<meyering@redhat.com>
>> ---
>>   hw/kvm/apic.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/kvm/apic.c b/hw/kvm/apic.c
>> index ffe7a52..a0ab503 100644
>> --- a/hw/kvm/apic.c
>> +++ b/hw/kvm/apic.c
>> @@ -29,7 +29,7 @@ void kvm_put_apic_state(DeviceState *d, struct kvm_lapic_state *kapic)
>>       APICCommonState *s = DO_UPCAST(APICCommonState, busdev.qdev, d);
>>       int i;
>>
>> -    memset(kapic, 0, sizeof(kapic));
>> +    memset(kapic, 0, sizeof(*kapic));
>>       kvm_apic_set_reg(kapic, 0x2, s->id<<  24);
>>       kvm_apic_set_reg(kapic, 0x8, s->tpr);
>>       kvm_apic_set_reg(kapic, 0xd, s->log_dest<<  24);
>>      
> Yep, that's what I actually meant...
>
> Thanks,
> Jan
>
>    

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Hello Anthony,

this patch should be committed to QEMU 1.1.
I had sent a patch with the same fix 6 days later.

Regards,

Stefan W.