From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonghwa3.lee@samsung.com Subject: Re: [PATCH v3 2/2] regulator: Add support for MAX77686. Date: Wed, 23 May 2012 14:33:28 +0900 Message-ID: <4FBC76A8.2070004@samsung.com> References: <4fbb2ada.63de440a.589d.78e2@mx.google.com> <4FBC3FF0.5080408@samsung.com> <4FBC6A2D.6040408@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Yadwinder Singh Brar Cc: Yadwinder Singh Brar , linux-samsung-soc@vger.kernel.org, Kyungmin Park , Samuel Ortiz , Mark Brown , linux-kernel@vger.kernel.org, Liam Girdwood , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxMuuFhCAwNeyblCAyM+ydvCAxNDoyMywgWWFkd2luZGVyIFNpbmdoIEJyYXIgd3JvdGU6 Cgo+IE9uIFdlZCwgTWF5IDIzLCAyMDEyIGF0IDEwOjEwIEFNLCAgPGpvbmdod2EzLmxlZUBzYW1z dW5nLmNvbT4gd3JvdGU6Cj4+IE9uIDIwMTLrhYQgMDXsm5QgMjPsnbwgMTM6MTYsIFlhZHdpbmRl ciBTaW5naCBCcmFyIHdyb3RlOgo+Pgo+Pj4+PiArICAgICBtYXg3NzY4Nl91cGRhdGVfcmVnKGky YywgTUFYNzc2ODZfUkVHX0JVQ0syQ1RSTDEsCj4+Pj4+ICsgICAgICAgICAgICAgbWF4Nzc2ODYt PnJhbXBfZGVsYXkgPDwgNiwgUkFNUF9NQVNLKTsKPj4+Pj4gKyAgICAgbWF4Nzc2ODZfdXBkYXRl X3JlZyhpMmMsIE1BWDc3Njg2X1JFR19CVUNLM0NUUkwxLAo+Pj4+PiArICAgICAgICAgICAgIG1h eDc3Njg2LT5yYW1wX2RlbGF5IDw8IDYsIFJBTVBfTUFTSyk7Cj4+Pj4+ICsgICAgIG1heDc3Njg2 X3VwZGF0ZV9yZWcoaTJjLCBNQVg3NzY4Nl9SRUdfQlVDSzRDVFJMMSwKPj4+Pj4gKyAgICAgICAg ICAgICBtYXg3NzY4Ni0+cmFtcF9kZWxheSA8PCA2LCBSQU1QX01BU0spOwo+Pj4+PiArCj4+Pj4K Pj4+Pgo+Pj4+IFdoeSBkbyB5b3UgdXNlIGkyYyBjbGllbnQgc3RpbGw/IElmIHlvdSByZWdpc3Rl cmVkIHJlZ21hcCB5b3UgY2FuIHVzZQo+Pj4+IGl0cyBBUEkuIEkgcmVjb21tZW5kIHlvdSB0byB1 c2UgcmVnbWFwX3VwZGF0ZV9iaXRzKCkgZGlyZWN0bHkuCj4+Pj4KPj4+Pgo+Pj4KPj4+IFllcywg d2UgYXJlIHVzaW5nIHJlZ21hcF91cGRhdGVfYml0cygpLiAgbWF4Nzc2ODZfdXBkYXRlX3JlZygp IGlzIGp1c3QKPj4+IGEgd3JhcHBlciBvdmVyIGl0Lgo+Pj4KPj4KPj4KPj4gWWVzLCBpIGtub3cg d2hhdCB5b3UgbWVhbi4gSG93ZXZlciBpdCBkb2Vzbid0IG5lZWQgbWF4Nzc2ODZfdXBkYXRlX3Jl ZygpCj4+IGFueSBtb3JlIHNpbmNlIGl0IHVzZXMgcmVnbWFwIEFQSS4gV2h5IGRvbid0IHlvdSBq dXN0IHBhc3MgaW9kZXYtPnJlZ21hcAo+PiB0byByZWdtYXBfdXBkYXRlX2JpdHMoKS4gSXQgaXMg Y2xlYXIgdGhhdCB0aGVyZSBpcyBubyByZWFzb24gZm9yIHVzaW5nCj4+IGkyYyBjbGllbnQgYXMg YSBtZWRpdW0uIFBsZWFzZSBjaGVjayByZWd1bGF0b3IgYW5kIG1mZCBkcml2ZXIgb2YgbXkKPj4g cHJldmlvdXMgcGF0Y2guCj4+Cj4gCj4gSSBhZ3JlZSB3aXRoIHlvdSB3ZSBjYW4gdXNlIGRpcmVj dGx5ICByZWdtYXAgQVBJLiBCdXQgSSBwcmVmZXJyZWQKPiBtYXg3NzY4Nl91cGRhdGVfcmVnKCkg YmVjYXVzZSBpdHMgYSBjb21tb24gcHJhY3RpY2UgdG8gdXNlCj4gY29tbW9uIHJlYWQvd3JpdGUg QVBJIHdoaWNoIHdlIGRlZmluZSBpbiBtZmQgZHJpdmVyIHRvIGFjY2Vzcwo+IHRoYXQgcGFydGlj dWxhciBtZmQgZGV2aWNlIGZyb20gb3RoZXIgZHJpdmVycy4KPiAKPiBSZWdhcmRzLAo+IFlhZHdp bmRlci4KPiAtLQo+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5l ICJ1bnN1YnNjcmliZSBsaW51eC1rZXJuZWwiIGluCj4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRv IG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKPiBNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRw Oi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwKPiBQbGVhc2UgcmVhZCB0aGUg RkFRIGF0ICBodHRwOi8vd3d3LnR1eC5vcmcvbGttbC8KPiAKCgpJIGluZm9ybSB5b3UgbXkgbWZk IGRyaXZlciBoYXMgYmVlbiBjb25maXJtZWQgYnkgU2FtdWVsIE9yaXR6IGFuZCB0aGVyZQppcyBu byBtZmQgcHJpdmF0ZSBBUEkuIFRoaXMgc2l0dWF0aW9uIGxvb2tzIHVudXN1YWwgdGhhdCB3ZSBy ZWdpc3RlcnMKbWZkIGRyaXZlciBhbmQgcmVndWxhdG9yIGRyaXZlciBzZXBhcmF0ZWx5LiBCdXQg aG93IHNob3VsZCB3ZSBkbz8gRm9yCmNvcnBvcmF0aW9uICwgaSdtIGFza2luZyB5b3UgdG8gY29u c2lkZXIgbXkgc3VnZ2VzdGlvbi4KClRoYW5rcy4KCgpUaGFua3MuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonghwa3.lee@samsung.com (jonghwa3.lee at samsung.com) Date: Wed, 23 May 2012 14:33:28 +0900 Subject: [PATCH v3 2/2] regulator: Add support for MAX77686. In-Reply-To: References: <4fbb2ada.63de440a.589d.78e2@mx.google.com> <4FBC3FF0.5080408@samsung.com> <4FBC6A2D.6040408@samsung.com> Message-ID: <4FBC76A8.2070004@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2012? 05? 23? 14:23, Yadwinder Singh Brar wrote: > On Wed, May 23, 2012 at 10:10 AM, wrote: >> On 2012? 05? 23? 13:16, Yadwinder Singh Brar wrote: >> >>>>> + max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1, >>>>> + max77686->ramp_delay << 6, RAMP_MASK); >>>>> + max77686_update_reg(i2c, MAX77686_REG_BUCK3CTRL1, >>>>> + max77686->ramp_delay << 6, RAMP_MASK); >>>>> + max77686_update_reg(i2c, MAX77686_REG_BUCK4CTRL1, >>>>> + max77686->ramp_delay << 6, RAMP_MASK); >>>>> + >>>> >>>> >>>> Why do you use i2c client still? If you registered regmap you can use >>>> its API. I recommend you to use regmap_update_bits() directly. >>>> >>>> >>> >>> Yes, we are using regmap_update_bits(). max77686_update_reg() is just >>> a wrapper over it. >>> >> >> >> Yes, i know what you mean. However it doesn't need max77686_update_reg() >> any more since it uses regmap API. Why don't you just pass iodev->regmap >> to regmap_update_bits(). It is clear that there is no reason for using >> i2c client as a medium. Please check regulator and mfd driver of my >> previous patch. >> > > I agree with you we can use directly regmap API. But I preferred > max77686_update_reg() because its a common practice to use > common read/write API which we define in mfd driver to access > that particular mfd device from other drivers. > > Regards, > Yadwinder. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > I inform you my mfd driver has been confirmed by Samuel Oritz and there is no mfd private API. This situation looks unusual that we registers mfd driver and regulator driver separately. But how should we do? For corporation , i'm asking you to consider my suggestion. Thanks. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702Ab2EWFdb (ORCPT ); Wed, 23 May 2012 01:33:31 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:56033 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559Ab2EWFda (ORCPT ); Wed, 23 May 2012 01:33:30 -0400 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee61a-b7fe76d0000023f5-e6-4fbc76a8d548 Message-id: <4FBC76A8.2070004@samsung.com> Date: Wed, 23 May 2012 14:33:28 +0900 From: jonghwa3.lee@samsung.com User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 To: Yadwinder Singh Brar Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Brown , Liam Girdwood , Yadwinder Singh Brar , Kyungmin Park , Samuel Ortiz Subject: Re: [PATCH v3 2/2] regulator: Add support for MAX77686. References: <4fbb2ada.63de440a.589d.78e2@mx.google.com> <4FBC3FF0.5080408@samsung.com> <4FBC6A2D.6040408@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLLMWRmVeSWpSXmKPExsVy+t9jAd0VZXv8DTp+qllc3jWHzWLG+X1M DkwenzfJBTBGcdmkpOZklqUW6dslcGX0nz7MWvCRv2LOjcoGxvM8XYycHBICJhLrLqxkgbDF JC7cW8/WxcjFISSwiFHiQvtzJpAEr4CgxI/J94CKODiYBeQljlzKBgkzC6hLTJq3iBmi/i2j xMlz+5kh6rUkrj8+wghiswioSnyYNB8sziYgJ/G26RsjyBxRgQiJX/0cIGERAQOJiUvmsYLM YRbYySTx7NkdsF5hAQeJ2WunM0IsmM4ksXjGPHaQBKdAsET702PMExgFZiG5bxbCfbOQ3LeA kXkVo2hqQXJBcVJ6rqFecWJucWleul5yfu4mRnAgPpPawbiyweIQowAHoxIP7w+3Pf5CrIll xZW5hxglOJiVRHjXT9/tL8SbklhZlVqUH19UmpNafIhRmoNFSZzXbvEOfyGB9MSS1OzU1ILU IpgsEwenVAPjVr2cTpcfN+9vvNny1vBoslnTe7F/6pfPSdx39e8P+LI++sKSLyc0lfTz/FYf 2VMwV1Euf/nqe3aT12Q+z/PRrTm35PuhJ1L8yXdP6M06t6+aq+aZXMDzHWutnl5mzprV6bjo xuxJ85xtp08qar08syP+2ofgNCHrHWdXubPFGEZ/sXbpuO68SYmlOCPRUIu5qDgRAOQem8ZA AgAA X-TM-AS-MML: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2012년 05월 23일 14:23, Yadwinder Singh Brar wrote: > On Wed, May 23, 2012 at 10:10 AM, wrote: >> On 2012년 05월 23일 13:16, Yadwinder Singh Brar wrote: >> >>>>> + max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1, >>>>> + max77686->ramp_delay << 6, RAMP_MASK); >>>>> + max77686_update_reg(i2c, MAX77686_REG_BUCK3CTRL1, >>>>> + max77686->ramp_delay << 6, RAMP_MASK); >>>>> + max77686_update_reg(i2c, MAX77686_REG_BUCK4CTRL1, >>>>> + max77686->ramp_delay << 6, RAMP_MASK); >>>>> + >>>> >>>> >>>> Why do you use i2c client still? If you registered regmap you can use >>>> its API. I recommend you to use regmap_update_bits() directly. >>>> >>>> >>> >>> Yes, we are using regmap_update_bits(). max77686_update_reg() is just >>> a wrapper over it. >>> >> >> >> Yes, i know what you mean. However it doesn't need max77686_update_reg() >> any more since it uses regmap API. Why don't you just pass iodev->regmap >> to regmap_update_bits(). It is clear that there is no reason for using >> i2c client as a medium. Please check regulator and mfd driver of my >> previous patch. >> > > I agree with you we can use directly regmap API. But I preferred > max77686_update_reg() because its a common practice to use > common read/write API which we define in mfd driver to access > that particular mfd device from other drivers. > > Regards, > Yadwinder. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > I inform you my mfd driver has been confirmed by Samuel Oritz and there is no mfd private API. This situation looks unusual that we registers mfd driver and regulator driver separately. But how should we do? For corporation , i'm asking you to consider my suggestion. Thanks. Thanks.