From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>
Cc: 'Kevin Wolf' <kwolf@redhat.com>,
'Anthony Liguori' <anthony@codemonkey.ws>,
'qemu-devel' <qemu-devel@nongnu.org>,
'dunrong huang' <riegamaths@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu
Date: Wed, 23 May 2012 09:03:01 +0200 [thread overview]
Message-ID: <4FBC8BA5.8090409@redhat.com> (raw)
In-Reply-To: <3123.31610261953$1337755763@news.gmane.org>
Il 23/05/2012 08:48, Pavel Dovgaluk ha scritto:
>>> > > I'm not against your patch and it's probably 1.1 material, but there may
>>> > > be more shutdown logic that we're missing if you close the console window.
>> >
>> > Looks like qemu_ctrl_handler (in os-win32.c) needs to do something like
>> > termsig_handler (in os-posix.c) instead of a plain exit.
> I tried to call qemu_system_shutdown_request() instead of exit() there, but Windows kills qemu
> before it finishes cleanup work.
Uff...
http://stackoverflow.com/questions/3640633/c-setconsolectrlhandler-routine-issue
says more or less what you have to do.
Paolo
next prev parent reply other threads:[~2012-05-23 7:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4fb35a7e.2458b40a.3ed6.649cSMTPIN_ADDED@mx.google.com>
2012-05-16 8:16 ` [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu dunrong huang
2012-05-16 10:16 ` Pavel Dovgaluk
2012-05-22 8:51 ` Kevin Wolf
2012-05-22 9:25 ` Paolo Bonzini
2012-05-23 6:48 ` Pavel Dovgaluk
[not found] ` <3123.31610261953$1337755763@news.gmane.org>
2012-05-23 7:03 ` Paolo Bonzini [this message]
2012-05-24 7:41 ` Pavel Dovgaluk
2012-05-16 7:42 Pavel Dovgaluk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBC8BA5.8090409@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riegamaths@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.