From: Ola Lilja <ola.o.lilja@stericsson.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@ti.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 10/11] ASoC: codecs: Add AB8500 codec-driver
Date: Wed, 23 May 2012 09:04:49 +0200 [thread overview]
Message-ID: <4FBC8C11.6020602@stericsson.com> (raw)
In-Reply-To: <20120508182751.GJ15893@opensource.wolfsonmicro.com>
On 05/08/2012 08:27 PM, Mark Brown wrote:
>> +static struct snd_kcontrol_new ab8500_ctrls[] = {
>> + /* Charge pump */
>> + SOC_ENUM("Charge Pump High Threshold For Low Voltage",
>> + soc_enum_envdeththre),
>> + SOC_ENUM("Charge Pump Low Threshold For Low Voltage",
>> + soc_enum_envdetlthre),
>> + SOC_ENUM("Charge Pump Envelope Detection", soc_enum_envdetcpen),
>> + SOC_ENUM("Charge Pump Envelope Detection Decay Time",
>> + soc_enum_envdettime),
>
> Again, why is this all exposed to userspace?
These one we need as ALSA-controls. They are parameters that we can tune during
runtime and are not hard-wired in any way.
next prev parent reply other threads:[~2012-05-23 7:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 13:57 [PATCH 10/11] ASoC: codecs: Add AB8500 codec-driver Ola Lilja
2012-05-08 18:27 ` Mark Brown
2012-05-09 7:48 ` Ola Lilja
2012-05-09 8:33 ` Mark Brown
2012-05-09 9:09 ` Ola Lilja
2012-05-09 10:51 ` Mark Brown
2012-05-23 7:04 ` Ola Lilja [this message]
2012-05-23 17:40 ` Mark Brown
2012-05-24 6:21 ` Ola Lilja
2012-05-24 10:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBC8C11.6020602@stericsson.com \
--to=ola.o.lilja@stericsson.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.