Re: [PATCH] ath6kl: Fix missing gpio pin 9 configuration

[Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>]

On Tuesday 22 May 2012 12:52 PM, Vasanthakumar Thiagarajan wrote:
> GPIO pin 9 also needs to be configured along with other gpio
> pins to avoid sdio crc errors. I've not experienced any issue
> with missing this particular gpio pin configuration, found dunring
> code review. This can potentially improve rx performance.
>
> Signed-off-by: Vasanthakumar Thiagarajan<vthiagar@qca.qualcomm.com>
> ---
>   drivers/net/wireless/ath/ath6kl/init.c   |    6 ++++++
>   drivers/net/wireless/ath/ath6kl/target.h |    1 +
>   2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index 10de132..241febc 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1392,6 +1392,12 @@ static int ath6kl_init_upload(struct ath6kl *ar)
>   	    ar->version.target_ver == AR6003_HW_2_1_1_VERSION) {
>   		ath6kl_err("temporary war to avoid sdio crc error\n");
>
> +		param = 0x28;
> +		address = GPIO_BASE_ADDRESS + GPIO_PIN9_ADDRESS;
> +		status = ath6kl_bmi_reg_write(ar, address, param);
> +		if (status)
> +			return status;
> +
>   		param = 0x20;
>
>   		address = GPIO_BASE_ADDRESS + GPIO_PIN10_ADDRESS;
> diff --git a/drivers/net/wireless/ath/ath6kl/target.h b/drivers/net/wireless/ath/ath6kl/target.h
> index 78e0ef4..a98c12b 100644
> --- a/drivers/net/wireless/ath/ath6kl/target.h
> +++ b/drivers/net/wireless/ath/ath6kl/target.h
> @@ -45,6 +45,7 @@
>   #define LPO_CAL_ENABLE_S		20
>   #define LPO_CAL_ENABLE			0x00100000
>
> +#define GPIO_PIN9_ADDRESS		0x0000004c
>   #define GPIO_PIN10_ADDRESS		0x00000050
>   #define GPIO_PIN11_ADDRESS		0x00000054
>   #define GPIO_PIN12_ADDRESS		0x00000058

I hope you are not dropping this one along with the other
series of two patches sent mistakenly. This is genuine patch.

Vasanth