All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 1/2 V3] watchdog: Add multiple device support
Date: Wed, 23 May 2012 10:47:20 +0200	[thread overview]
Message-ID: <4FBCA418.5070203@redhat.com> (raw)
In-Reply-To: <20120522211832.GG3074@spo001.leaseweb.com>

Hi,

On 05/22/2012 11:18 PM, Wim Van Sebroeck wrote:
> Hi Hans,
>
>>> I will split your "watchdog_dev: Add support for dynamically allocated
>>> watchdog_device structs" patch into 3 patches:
>>> 1) rewriting of wrappers (and I will add some extra code to it for
>>> the get_timeleft ioctl).
>>> 2) locking
>>> 3) ref+unref+unregistered.
>>
>> Sounds good! Assuming you manage to finish this tonight, I'll review
>> and test first thing tomorrow morning.
>
> They are there.

Thanks!

I've reviewed the entire set, it looks good. I like the 3-way split you did!

I've ofcourse also tested it and it works as advertised.

Regards,

Hans

  reply	other threads:[~2012-05-23  8:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 13:29 [PATCH 1/2 V3] watchdog: Add multiple device support Tomas Winkler
2012-05-14 13:29 ` [PATCH 2/2 V3] watchdog: create all the proper device files Tomas Winkler
2012-05-14 13:52 ` [PATCH 1/2 V3] watchdog: Add multiple device support Wim Van Sebroeck
2012-05-14 14:00   ` Winkler, Tomas
2012-05-14 17:30     ` Tomas Winkler
2012-05-17  7:19       ` Wim Van Sebroeck
2012-05-17 11:30         ` Tomas Winkler
2012-05-21 20:21           ` Wim Van Sebroeck
2012-05-22  9:36             ` Hans de Goede
2012-05-22 16:41               ` Wim Van Sebroeck
2012-05-22 16:51                 ` Hans de Goede
2012-05-22 21:18                   ` Wim Van Sebroeck
2012-05-23  8:47                     ` Hans de Goede [this message]
2012-05-22 10:53             ` Tomas Winkler
2012-05-22 16:38               ` Wim Van Sebroeck
2012-05-14 14:01 ` Wim Van Sebroeck
2012-05-14 14:07   ` Winkler, Tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBCA418.5070203@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alan@linux.intel.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.