From: Jens Axboe <axboe@kernel.dk>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, Sasha Levin <sasha.levin@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH block/for-3.5/core] blkcg: tg_stats_alloc_lock is an irq lock
Date: Wed, 23 May 2012 12:16:51 +0200 [thread overview]
Message-ID: <4FBCB913.8050403@kernel.dk> (raw)
In-Reply-To: <CA+1xoqff_OQORFm05fCqeZ-vCt+2Y9H0KNfSxrCepfCDNGZgXQ@mail.gmail.com>
On 05/23/2012 11:54 AM, Sasha Levin wrote:
> On Thu, Apr 26, 2012 at 11:10 PM, Tejun Heo <tj@kernel.org> wrote:
>> tg_stats_alloc_lock nests inside queue lock and should always be held
>> with irq disabled. throtl_pd_{init|exit}() were using non-irqsafe
>> spinlock ops which triggered inverse lock ordering via irq warning via
>> RCU freeing of blkg invoking throtl_pd_exit() w/o disabling IRQ.
>>
>> Update both functions to use irq safe operations.
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
>> Reported-by: Sasha Levin <sasha.levin@oracle.com>
>> LKML-Reference: <1335339396.16988.80.camel@lappy>
>> ---
>
> I think that this patch got lost somewhere and never got merged into
> the for-3.5 branch.
Seems it did, odd. Applied it now.
--
Jens Axboe
prev parent reply other threads:[~2012-05-23 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 7:36 blkcg: INFO: possible irq lock inversion dependency detected Sasha Levin
2012-04-26 21:10 ` [PATCH block/for-3.5/core] blkcg: tg_stats_alloc_lock is an irq lock Tejun Heo
2012-05-23 9:54 ` Sasha Levin
2012-05-23 10:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBCB913.8050403@kernel.dk \
--to=axboe@kernel.dk \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sasha.levin@oracle.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.