From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43582)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SX8sf-0007gS-Ou
	for qemu-devel@nongnu.org; Wed, 23 May 2012 06:33:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SX8sZ-0002mT-Fw
	for qemu-devel@nongnu.org; Wed, 23 May 2012 06:33:25 -0400
Received: from thoth.sbs.de ([192.35.17.2]:27492)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SX8sZ-0002ln-2v
	for qemu-devel@nongnu.org; Wed, 23 May 2012 06:33:19 -0400
Message-ID: <4FBCBCE6.3060000@siemens.com>
Date: Wed, 23 May 2012 07:33:10 -0300
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1336666788-30233-1-git-send-email-jim@meyering.net>
	<1336666788-30233-2-git-send-email-jim@meyering.net>
	<4FABFAA1.5070307@siemens.com> <4FBBF762.3070009@weilnetz.de>
In-Reply-To: <4FBBF762.3070009@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.1 1/2] kvm/apic: correct short memset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Anthony Liguori <aliguori@us.ibm.com>
Cc: Jim Meyering <meyering@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Avi Kivity <avi@redhat.com>

On 2012-05-22 17:30, Stefan Weil wrote:
> Am 10.05.2012 19:28, schrieb Jan Kiszka:
>> On 2012-05-10 13:19, Jim Meyering wrote:
>>    
>>> From: Jim Meyering<meyering@redhat.com>
>>>
>>> kvm_put_apic_state's attempt to clear *kapic before setting its
>>> bits cleared sizeof(void*) bytes (no more than 8) rather than the
>>> intended 1024 (KVM_APIC_REG_SIZE) bytes. Spotted by coverity.
>>>
>>> Signed-off-by: Jim Meyering<meyering@redhat.com>
>>> ---
>>>   hw/kvm/apic.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/hw/kvm/apic.c b/hw/kvm/apic.c
>>> index ffe7a52..a0ab503 100644
>>> --- a/hw/kvm/apic.c
>>> +++ b/hw/kvm/apic.c
>>> @@ -29,7 +29,7 @@ void kvm_put_apic_state(DeviceState *d, struct kvm_lapic_state *kapic)
>>>       APICCommonState *s = DO_UPCAST(APICCommonState, busdev.qdev, d);
>>>       int i;
>>>
>>> -    memset(kapic, 0, sizeof(kapic));
>>> +    memset(kapic, 0, sizeof(*kapic));
>>>       kvm_apic_set_reg(kapic, 0x2, s->id<<  24);
>>>       kvm_apic_set_reg(kapic, 0x8, s->tpr);
>>>       kvm_apic_set_reg(kapic, 0xd, s->log_dest<<  24);
>>>      
>> Yep, that's what I actually meant...
>>
>> Thanks,
>> Jan
>>
>>    
> 
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
> 
> Hello Anthony,
> 
> this patch should be committed to QEMU 1.1.
> I had sent a patch with the same fix 6 days later.

Thanks for reminding. Yes, please merge!

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux