All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/9] tar: fix build
Date: Wed, 23 May 2012 04:44:54 -0600	[thread overview]
Message-ID: <4FBCBFA6.8020307@mlbassoc.com> (raw)
In-Reply-To: <9fcc40151424883e9f660dfdd3a3eb52213701c1.1337731469.git.nitin.a.kamble@intel.com>

On 2012-05-22 18:05, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble<nitin.a.kamble@intel.com>
>
> Avoid this error:
> | rmdir: failed to remove `/srv/home/nitin/builds/build-gcc47/tmp/work/i586-poky-linux/tar-1.26-r1/image/usr/sbin/': No such file or directory
> NOTE: package tar-1.26-r1: task do_install: Failed
>
> no PR bump as no change in the output.
>
> Signed-off-by: Nitin A Kamble<nitin.a.kamble@intel.com>
> ---
>   meta/recipes-extended/tar/tar.inc |    8 ++++++--
>   1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/tar/tar.inc b/meta/recipes-extended/tar/tar.inc
> index 0533b82..5c2325a 100644
> --- a/meta/recipes-extended/tar/tar.inc
> +++ b/meta/recipes-extended/tar/tar.inc
> @@ -18,8 +18,12 @@ do_install () {
>   do_install_extra () {
>       install -d ${D}${base_bindir}
>       mv ${D}${bindir}/tar ${D}${base_bindir}/tar.${PN}
> -    rmdir ${D}${bindir}/
> -    rmdir ${D}${sbindir}/
> +    if [ -d ${D}${bindir}/ ] ; then
> +        rmdir ${D}${bindir}/
> +    fi
> +    if [ -d ${D}${sbindir}/ ] ; then
> +        rmdir ${D}${sbindir}/
> +    fi
>       mv ${D}${libexecdir}/rmt ${D}${libexecdir}/rmt.${PN}
>   }
>

Why not just use
   rm -fr ${D}${bindir}
etc?  No need for all the extra testing...

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------



  reply	other threads:[~2012-05-23 10:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23  0:05 [PATCH 0/9] fixes for misc issue discovered by automake 1.12 nitin.a.kamble
2012-05-23  0:05 ` [PATCH 1/9] tar: fix build nitin.a.kamble
2012-05-23 10:44   ` Gary Thomas [this message]
2012-05-23 13:48     ` Richard Purdie
2012-05-23 22:08       ` Kamble, Nitin A
2012-05-23  0:05 ` [PATCH 2/9] libgcrypt: " nitin.a.kamble
2012-05-23  0:05 ` [PATCH 3/9] gpgme: " nitin.a.kamble
2012-05-23  0:05 ` [PATCH 4/9] telepathy-glib: " nitin.a.kamble
2012-05-23  0:05 ` [PATCH 5/9] xf86-video-vmware: fix build issue nitin.a.kamble
2012-05-23  0:05 ` [PATCH 6/9] avahi: fix install issue nitin.a.kamble
2012-05-23  0:05 ` [PATCH 7/9] pango: fix dependencies to avoid build issue nitin.a.kamble
2012-05-23  0:05 ` [PATCH 8/9] libfm: fix a " nitin.a.kamble
2012-05-23  0:05 ` [PATCH 9/9] evolution-data-server: fix with automake work in progress nitin.a.kamble
2012-05-23  0:06   ` Kamble, Nitin A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBCBFA6.8020307@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.