All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: GPU lockup dumping
Date: Wed, 23 May 2012 14:34:49 +0200	[thread overview]
Message-ID: <4FBCD969.8040408@vodafone.de> (raw)
In-Reply-To: <CAPM=9twP33ZgtRauNHA=MqHDghOgwb0AwFP85qHRg0n=fLPyAA@mail.gmail.com>

On 23.05.2012 11:27, Dave Airlie wrote:
> On Thu, May 17, 2012 at 7:28 PM,<j.glisse@gmail.com>  wrote:
>> So here is improved patchset, where i splited ground work necessary
>> for the dumping into their own patch. The debugfs improvement could
>> probably be usefull to intel instead of having i915 have it's own
>> debugfs file stuff.
>>
>> The lockup dumping public api have been move into radeon_drm.h
>>
>> Stressing the fact again that dump are self contained ie they have
>> all the data needed to be replayed (vertex, indices, shader, texture,
>> ...).
>>
>> Would really like to get this into 3.5, the new API is pretty much
>> straightforward and userspace tools can easily be made to convert
>> it to other format. The change to the driver is self contained.
> I really don't like introducing this at this stage into 3.5,
>
> I'd really like a good review of the API and what information we provide
> along with how extensible it is.
>
> I'm still not convinced replay is what we want in the field, I know its what
> *you* want, but I think apitrace stuff in userspace pretty much covers
> the replaying situation. So I'd have to look at this and see how easy
> it makes disecting command streams etc.
>
> Dave.

I agree that it might not be a good idea to push that into 3.5, since at 
least I (and I also think Alex) didn't had time to look into it yet. On 
the other hand the patches look quite reasonable.

But I still wanted to throw in a requirement from my day to day work, 
maybe that helps finding a more general solution:
When we start to work with more parts of the chip it might be necessary 
to dump everything that is currently "in the fly". For example I had a 
whole bunch of problems where copying data around with a 3D Blit and 
then missing a sync between this job and a job on another rings causes a 
"hiccup" in the hardware.

I know that this isn't your focus and that is absolutely ok with me, 
cause the format you are introducing is just used in debugfs and so not 
part of any stable API (at least not in my understanding), but you 
should still keep in mind that we might need to extend it into that 
direction in the future.

Christian.

  reply	other threads:[~2012-05-23 12:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 18:28 GPU lockup dumping j.glisse
2012-05-17 18:28 ` [PATCH 1/5] drm/debugfs: allow driver to provide a custom read callback j.glisse
2012-05-17 18:28 ` [PATCH 2/5] drm/radeon: allow radeon debugfs helper to provide custom read j.glisse
2012-05-17 18:28 ` [PATCH 3/5] drm/radeon: allow radeon_vm_bo_update_pte caller to get bo virtual offset j.glisse
2012-05-17 18:28 ` [PATCH 4/5] drm/radeon: add lockup faulty command recording v2 j.glisse
2012-05-17 18:28 ` [PATCH 5/5] drm/radeon: restore consistant whitespace & indentation j.glisse
2012-05-23  9:27 ` GPU lockup dumping Dave Airlie
2012-05-23 12:34   ` Christian König [this message]
2012-05-23 14:48     ` Jerome Glisse
2012-05-23 16:08       ` Dave Airlie
2012-05-23 16:26         ` Jerome Glisse
2012-05-23 16:41           ` Dave Airlie
2012-05-23 17:02             ` Jerome Glisse
2012-05-24  7:58               ` Christian König
2012-05-23 16:04     ` Alex Deucher
2012-05-23 16:26       ` Jerome Glisse
2012-05-23 14:51   ` Jerome Glisse
2012-05-23 19:33     ` Jordan Crouse
  -- strict thread matches above, loose matches on Subject: below --
2012-05-17 19:53 j.glisse
2012-05-17 22:07 j.glisse
2012-05-22 21:08 ` Jerome Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBCD969.8040408@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.