From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] 030: fix for new xfs_repair versions
Date: Wed, 23 May 2012 08:12:15 -0500 [thread overview]
Message-ID: <4FBCE22F.80205@sgi.com> (raw)
In-Reply-To: <4F848278.501@sgi.com>
On 04/10/12 13:56, Mark Tinguely wrote:
> On 03/31/12 18:28, Christoph Hellwig wrote:
>> Given that we now drop invalid unlinked inode lists there is no message
>> to capture. Also add a sed expression to avoid failures on old repair
>> versions.
>>
>> Signed-off-by: Christoph Hellwig<hch@lst.de>
>>
>
>
> This is something that worked on an older OS:
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
> ---
> 030 | 3 ++-
> 030.out.linux | 1 -
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/030
> ===================================================================
> --- a/030
> +++ b/030
> @@ -55,7 +55,8 @@ _check_ag()
> for structure in 'sb 0' 'agf 0' 'agi 0' 'agfl 0'
> do
> echo "Corrupting $structure - setting bits to $1"
> - _check_repair $1 "$structure"
> + _check_repair $1 "$structure" |
> + sed -e '/^error following ag 0 unlinked list$/d'
> done
> }
>
> Index: b/030.out.linux
> ===================================================================
> --- a/030.out.linux
> +++ b/030.out.linux
> @@ -85,7 +85,6 @@ bad agbno AGBNO for inobt root, agno 0
> root inode chunk not found
> Phase 3 - for each AG...
> - scan and clear agi unlinked lists...
> -error following ag 0 unlinked list
> - process known inodes and perform inode discovery...
> - process newly discovered inodes...
> Phase 4 - check for duplicate blocks...
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
ping.
People are still listing 030 as broken. We should get this fixed.
--Mark Tinguely
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-05-23 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 23:28 [PATCH] 030: fix for new xfs_repair versions Christoph Hellwig
2012-04-02 14:35 ` Mark Tinguely
2012-04-10 18:56 ` Mark Tinguely
2012-05-23 13:12 ` Mark Tinguely [this message]
2012-05-23 13:55 ` Christoph Hellwig
2012-05-23 17:11 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBCE22F.80205@sgi.com \
--to=tinguely@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.