All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	Brian Zhao <zwanp@linux.vnet.ibm.com>,
	Kelvin Wang <senwang@linux.vnet.ibm.com>,
	Amos Kong <kongjianjun@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug
Date: Wed, 23 May 2012 16:30:06 +0200	[thread overview]
Message-ID: <4FBCF46E.3020509@redhat.com> (raw)
In-Reply-To: <20120523141202.GC29930@redhat.com>

Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto:
>> > 2, Run qemu with the option -monitor.
>> > 
>> > 3, In the guest, insert necessary modules:
>> > for m in acpiphp pci_hotplug; do sudo modprobe ${m}; done
>> > 
>> > 4, In the qemu monitor,hot add a virtio-scsi-pci adapter:
>> > (qemu)pci_add auto storage if=virtio-scsi-pci
>> > 
>> > 5, Check whether the controller was added:
>> > Guest: lspci
>> > Qemu: (qemu)info qtree
>> > 
>> > Signed-off-by: Kelvin Wang <senwang@linux.vnet.ibm.com>
>> > Signed-off-by: Sheng Liu <liusheng@linux.vnet.ibm.com>
> NAK
> 
> Do not use pci_add. It is a compatibility command.
> Use the new style device_add.
> Same for if=.
> 
> I think you won't need any changes then?
> 

You don't.  You need to rescan the bus manually in the guest, that's all.

Paolo

  reply	other threads:[~2012-05-23 14:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 13:52 [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug Kelvin Wang
2012-05-23 14:12 ` Michael S. Tsirkin
2012-05-23 14:30   ` Paolo Bonzini [this message]
2012-05-23 14:45     ` Michael S. Tsirkin
2012-05-24  6:31       ` Kelvin Wang
2012-05-24  6:51         ` Michael S. Tsirkin
2012-05-24 10:00         ` Paolo Bonzini
2012-05-24 11:42           ` Kelvin Wang
2012-05-25 11:57         ` Stefan Hajnoczi
2012-05-24  5:43   ` Kelvin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBCF46E.3020509@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kongjianjun@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=senwang@linux.vnet.ibm.com \
    --cc=stefanha@gmail.com \
    --cc=zwanp@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.