From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SXDDe-000190-1I
	for qemu-devel@nongnu.org; Wed, 23 May 2012 11:11:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SXDDV-0000cY-Ip
	for qemu-devel@nongnu.org; Wed, 23 May 2012 11:11:21 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:41146)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SXDDV-0000bH-E0
	for qemu-devel@nongnu.org; Wed, 23 May 2012 11:11:13 -0400
Received: by obbwd20 with SMTP id wd20so13933253obb.4
	for <qemu-devel@nongnu.org>; Wed, 23 May 2012 08:11:11 -0700 (PDT)
Message-ID: <4FBCFE0C.9090407@codemonkey.ws>
Date: Wed, 23 May 2012 10:11:08 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1337504561-20297-1-git-send-email-gleb@redhat.com>
	<1337504561-20297-2-git-send-email-gleb@redhat.com>
	<4FBCE5A5.7050308@codemonkey.ws> <4FBCF566.3060902@suse.de>
	<4FBCF772.3040300@redhat.com>
In-Reply-To: <4FBCF772.3040300@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM
 system states.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Gleb Natapov <gleb@redhat.com>, qemu-devel@nongnu.org

On 05/23/2012 09:42 AM, Paolo Bonzini wrote:
> Il 23/05/2012 16:34, Andreas Färber ha scritto:
>>>>
>>>> I see nothing wrong in principle here except that you should use a PTR
>>>> property to pass the fw_cfg object to the ACPI PM device.
>> Paolo was on a quest to eliminate the PTR properties so I don't think we
>> should advocate adding any more. Without having reviewed the code, I
>> would suggest to rather QOM'ify the fw_cfg object and to use a link<>
>> property if needed.

fw_cfg is already a QOM object.  I think there's enough in the tree already to 
do link<>s properly so that's definitely better than doing a PTR.

>
> Perhaps it should be the other way round.  fw_cfg gets links to all the
> devices it has to expose information about.  In the future it could be
> changed to an FWCfgProvider interface.

Yes, that does make more sense.

Regards,

Anthony Liguori

>
> Paolo