All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Ingo Molnar <mingo@kernel.org>, Mike Galbraith <efault@gmx.de>,
	linux-kernel@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH 0/2] RFC: readd fair sleepers for server systems
Date: Wed, 23 May 2012 17:28:54 +0200	[thread overview]
Message-ID: <4FBD0236.7040508@linux.vnet.ibm.com> (raw)
In-Reply-To: <1337773798.27020.175.camel@laptop>



On 05/23/2012 01:49 PM, Peter Zijlstra wrote:
> On Wed, 2012-05-23 at 13:32 +0200, Christian Ehrhardt wrote:
>>> Why is this, is this some weird interaction with your hypervisor?
>>
>> It is not completely analyzed, as soon as debugging goes out of Linux it
>> can be kind of complex even internally.
>
> Is there significant steal time in these workloads? If so, does it help
> if you implement
> CONFIG_PARAVIRT_TIME_ACCOUNTING/paravirt_steal_rq_enabled for s390?
> (although I guess we'd better loose the paravirt part of the name then).

Interesting, yeah there is enough steal time - not in all, but in most 
cases we had in conflict with fair sleepers so far.
We don't have any code for CONFIG_PARAVIRT and its childs yet, so I need 
to look further into it.

> This 'feature' subtracts steal time from the task-clock so that the
> scheduler doesn't consider a task to be running when the vcpu wasn't
> running as well.
>
> Not doing that (current situation) could result in over-active
> preemption because we think a task ran significantly longer than it
> actually did. Same for sleeper fairness, we might think a task slept
> very long (and give a bigger boost) when in fact it didn't.

Great - sounds like a good thing to check, I'll definitely try this out.
This week we are changing our automation environment, so give me a few 
days for numbers on that.

-- 

Grüsse / regards, Christian Ehrhardt
IBM Linux Technology Center, System z Linux Performance


  reply	other threads:[~2012-05-23 15:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 15:45 [PATCH 0/2] RFC: readd fair sleepers for server systems Martin Schwidefsky
2012-05-21 15:45 ` [PATCH 1/2] sched: readd FAIR_SLEEPERS feature Martin Schwidefsky
2012-05-22  7:11   ` Christian Ehrhardt
2012-05-22  9:06     ` Mike Galbraith
2012-05-21 15:45 ` [PATCH 2/2] sched: enable FAIR_SLEEPERS for s390 Martin Schwidefsky
2012-05-21 18:17 ` [PATCH 0/2] RFC: readd fair sleepers for server systems Mike Galbraith
2012-05-22  7:11   ` Christian Ehrhardt
2012-05-22  8:53     ` Mike Galbraith
2012-05-22  9:01 ` Peter Zijlstra
2012-05-23 11:32   ` Christian Ehrhardt
2012-05-23 11:49     ` Peter Zijlstra
2012-05-23 15:28       ` Christian Ehrhardt [this message]
2012-05-23 15:43         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBD0236.7040508@linux.vnet.ibm.com \
    --to=ehrhardt@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=efault@gmx.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.