From: Stefan Weil <sw@weilnetz.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts
Date: Wed, 23 May 2012 17:29:48 +0200 [thread overview]
Message-ID: <4FBD026C.5040304@weilnetz.de> (raw)
In-Reply-To: <CAJSP0QUJ7n3fN8UdBRD3jE74PvKwx2mo7k_kOtM97aUOFqAi0Q@mail.gmail.com>
Am 23.05.2012 10:09, schrieb Stefan Hajnoczi:
> On Tue, May 22, 2012 at 10:23 PM, Stefan Weil<sw@weilnetz.de> wrote:
>> The local variables ret, i are only used if __linux__ is defined.
>>
>> Signed-off-by: Stefan Weil<sw@weilnetz.de>
>> ---
>> hw/virtio-blk.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> The #ifdef __linux__ further down in the function declares the local
> hdr variable. We could move ret and i down into the #ifdef instead of
> adding a new one.
I noticed that, but declaring variables anywhere is C++, not C code.
hdr violates the QEMU coding rules (other patches which did not
declare local variables at the beginning of a block were already
rejected). That's why I wrote the patch as it is.
Regards,
Stefan W.
next prev parent reply other threads:[~2012-05-23 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 21:23 [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts Stefan Weil
2012-05-23 8:09 ` Stefan Hajnoczi
2012-05-23 15:29 ` Stefan Weil [this message]
2012-05-23 15:32 ` Kevin Wolf
2012-05-23 16:03 ` Stefan Weil
2012-05-28 12:39 ` Stefan Hajnoczi
2012-05-28 12:48 ` Daniel P. Berrange
2012-05-28 12:52 ` Peter Maydell
2012-05-28 14:14 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBD026C.5040304@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.