From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SXE19-0001YL-Rb
	for qemu-devel@nongnu.org; Wed, 23 May 2012 12:02:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SXE17-0007ex-SR
	for qemu-devel@nongnu.org; Wed, 23 May 2012 12:02:31 -0400
Received: from goliath.siemens.de ([192.35.17.28]:32075)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SXE17-0007dQ-JA
	for qemu-devel@nongnu.org; Wed, 23 May 2012 12:02:29 -0400
Message-ID: <4FBD0A0B.1060106@siemens.com>
Date: Wed, 23 May 2012 13:02:19 -0300
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <CAETRQW=Yxwh5LCG4=To-dDUUVf-SktQuP3ctUt2_N7P-fM0+Hg@mail.gmail.com>
	<4FBC5C67.1080007@suse.de>
	<CAETRQWkWDmuVX1re6VicFkdSt77KYaWSDrjBeuRZKnYa6eMhCQ@mail.gmail.com>
	<4FBCC877.30003@siemens.com>
	<CAETRQW=tPZf3SE3Ye=oLKSSfhvNRNAHHGHuhvDhw5pcQ712s=g@mail.gmail.com>
In-Reply-To: <CAETRQW=tPZf3SE3Ye=oLKSSfhvNRNAHHGHuhvDhw5pcQ712s=g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: TeLeMan <geleman@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Avi Kivity <avi@redhat.com>

On 2012-05-23 11:11, TeLeMan wrote:
> On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka <jan.kiszka@siemens.com> wr=
ote:
>> On 2012-05-23 04:09, TeLeMan wrote:
>>> On Wed, May 23, 2012 at 11:41 AM, Andreas F=C3=A4rber <afaerber@suse.=
de> wrote:
>>>> Am 18.05.2012 11:49, schrieb TeLeMan:
>>>>> This breakage was introduced by the commit "memory: make
>>>>> phys_page_find() return an unadjusted".
>>>>
>>>> You seem to have found the origin of your problem. If you also menti=
on
>>>> the commit hash in your commit message then certain frontends (gitk,
>>>> repo.or.cz) will display it as a handy hyperlink to that commit.
>>>>
>>>>>
>>>>> Signed-off-by: TeLeMan <geleman@gmail.com>
>>>>
>>>> Signed-off-by is a legal statement of origin and must not be a pseud=
onym.
>>> Ok, please ignore this patch. I won't submit any patch just report bu=
gs.
>>
>> Then please describe this bug in more details, e.g. how to reproduce.
> I think its evident. cpu_get_phys_page_debug(env, pc) is not the
> physical address of pc but the physical page base address of pc.

...so this bites us if the instruction spans two pages as
tb_invalidate_phys_addr requests invalidation on a page granularity.
Such information would have been helpful to understand when it actually
breaks - not in the common case.

Thanks,
Jan

--=20
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux