From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Borislav Petkov <borislav.petkov@amd.com>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
frank.arnold@amd.com, akpm@linux-foundation.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mce] x86/bitops: Move BIT_64() for a wider use
Date: Wed, 23 May 2012 09:55:27 -0700 [thread overview]
Message-ID: <4FBD167F.7080305@zytor.com> (raw)
In-Reply-To: <CA+55aFxxMTQVoFQkgViBR-pmcpWrmvtHzV=yT-vfaWJ1eXZf0w@mail.gmail.com>
On 05/23/2012 09:54 AM, Linus Torvalds wrote:
> On Wed, May 23, 2012 at 9:47 AM, H. Peter Anvin <hpa@zytor.com> wrote:
>>
>> Any reason we can't just tell people to use BIT() for a native "unsigned
>> long" type (32/64 bits) and BIT_64() if they really want a 64-bit result?
>
> Well, that's what we're doing now. And it seems to have resulted in
> repeated bugs for architectures where most of the developers run on
> 64-bit machines, but the same code is actually supposed to work on
> 32-bit too (ie x86).
>
Yes, but I fear that this will result in more subtle bugs which will
therefore be even harder to detect and diagnose.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-05-23 16:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 10:53 [PATCH 1/2] x86, bitops: Move BIT_64 for a wider use Borislav Petkov
2012-05-22 10:53 ` [PATCH 2/2] x86, MCE: Fix 32-bit build Borislav Petkov
2012-05-23 16:08 ` [tip:x86/mce] x86/mce: " tip-bot for Borislav Petkov
2012-05-23 16:18 ` Peter Zijlstra
2012-05-23 16:23 ` Borislav Petkov
2012-05-23 16:31 ` Peter Zijlstra
2012-05-23 16:44 ` Borislav Petkov
2012-05-23 16:46 ` Peter Zijlstra
2012-05-23 16:54 ` Borislav Petkov
2012-05-23 16:07 ` [tip:x86/mce] x86/bitops: Move BIT_64() for a wider use tip-bot for Borislav Petkov
2012-05-23 16:10 ` Peter Zijlstra
2012-05-23 16:11 ` H. Peter Anvin
2012-05-23 16:19 ` Borislav Petkov
2012-05-23 16:29 ` Peter Zijlstra
2012-05-23 16:31 ` H. Peter Anvin
2012-05-23 16:43 ` Linus Torvalds
2012-05-23 16:47 ` H. Peter Anvin
2012-05-23 16:50 ` H. Peter Anvin
2012-05-23 16:54 ` Linus Torvalds
2012-05-23 16:55 ` H. Peter Anvin [this message]
2012-05-23 16:53 ` Borislav Petkov
2012-05-23 16:57 ` Linus Torvalds
2012-05-23 17:11 ` Borislav Petkov
2012-05-23 17:37 ` Linus Torvalds
2012-05-23 16:54 ` Peter Zijlstra
2012-05-23 16:40 ` Linus Torvalds
2012-05-23 16:42 ` H. Peter Anvin
2012-05-23 16:45 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBD167F.7080305@zytor.com \
--to=hpa@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=borislav.petkov@amd.com \
--cc=frank.arnold@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.