From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXMwY-0006hs-I1 for qemu-devel@nongnu.org; Wed, 23 May 2012 21:34:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXMwW-0005iT-Ao for qemu-devel@nongnu.org; Wed, 23 May 2012 21:34:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47580 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXMwW-0005i7-3q for qemu-devel@nongnu.org; Wed, 23 May 2012 21:34:20 -0400 Message-ID: <4FBD900E.5070207@suse.de> Date: Thu, 24 May 2012 03:34:06 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1335958273-769-1-git-send-email-pbonzini@redhat.com> <1335958273-769-11-git-send-email-pbonzini@redhat.com> <4FBD76DC.6010604@suse.de> In-Reply-To: <4FBD76DC.6010604@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/21] qdev: do not propagate properties to subclasses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org Am 24.05.2012 01:46, schrieb Andreas F=E4rber: > Am 02.05.2012 13:31, schrieb Paolo Bonzini: >> As soon as we'll look up properties along the inheritance chain, we >> will have duplicates if class A defines some properties and its >> subclass B does not define any, because class_b->props will be >> left equal to class_a->props. >> >> The solution here is to reintroduce the class_base_init TypeInfo >> callback, that was present in one of the early QOM versions but >> removed (on my request...) before committing. >> >> Signed-off-by: Paolo Bonzini >=20 > This breaks `make check` once again: >=20 > GTESTER check-qtest-i386 > qemu-system-i386: Property '.id' not found This was caused by the APIC 'id' property (dot in error message is misleading). IIUC it's because it's defined for the base class. Solved by squashing into the following commit. Applied to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg