From: Jan Kiszka <jan.kiszka@web.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 1/3 - qemu-kvm stable-1.0] Fix conditional build of various x86 specific bits
Date: Wed, 23 May 2012 23:51:40 -0300 [thread overview]
Message-ID: <4FBDA23C.5000608@web.de> (raw)
In-Reply-To: <1337825690.3038.50.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
On 2012-05-23 23:14, Benjamin Herrenschmidt wrote:
> This adds/modifies ifdefs etc. and moves code to make sure that
> x86-specific code doesn't get compiled on non-x86 platforms.
> These changes all relate to code that is in the qemu-kvm tree and
> not in the qemu tree.
>
> The change from KVM_CAP_IRQCHIP to KVM_IRQCHIP_PIC_MASTER is because
> the KVM_CAP_IRQCHIP symbol is defined on all platforms (though the
> capability only exists on x86), whereas KVM_IRQCHIP_PIC_MASTER is
> only defined on x86. (If a better symbol exists it could be used
> instead.)
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> An equivalent of this is already in qemu-kvm master as commit id
> 20ad1def644494f5055d129961d46b050c0a6158
What is the interest of patching qemu-kvm for non-x86? It is not
supposed to be used for this. And the affected bits are history in 1.1
(or 1.2 latest). Are there distros proving QEMU based on qemu-kvm for
non-x86 hosts?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-05-24 2:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 2:14 [PATCH 1/3 - qemu-kvm stable-1.0] Fix conditional build of various x86 specific bits Benjamin Herrenschmidt
2012-05-24 2:51 ` Jan Kiszka [this message]
2012-05-24 3:03 ` Benjamin Herrenschmidt
2012-06-01 23:07 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBDA23C.5000608@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.