From: Wen Congyang <wency@cn.fujitsu.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: rob@landley.net, tglx@linutronix.de,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86: add max_addr boot option
Date: Thu, 24 May 2012 13:19:48 +0800 [thread overview]
Message-ID: <4FBDC4F4.4000404@cn.fujitsu.com> (raw)
In-Reply-To: <CAErSpo4cUwwJNq45GZhUW02FU+T72OmvGfNcd2d1WhFo86KFOw@mail.gmail.com>
At 05/23/2012 10:25 PM, Bjorn Helgaas Wrote:
> On Tue, May 22, 2012 at 1:02 AM, Wen Congyang <wency@cn.fujitsu.com> wrote:
>
>> + if (start >= max_addr) {
>> + printk(KERN_INFO "Ingoring memory: %016Lx - %016Lx\n",
>> + (unsigned long long)start,
>> + (unsigned long long)(start + size));
>> + return;
>> + }
>> +
>> + if (max_addr - start < size) {
>> + printk(KERN_INFO "Ingoring memory: %016Lx - %016Lx\n",
>> + (unsigned long long)max_addr,
>> + (unsigned long long)(start + size));
>> + size = max_addr - start;
>
> s/Ingoring/Ignoring/
>
> Please use a format like "e820: ignoring [mem %#010Lx-%#010Lx]" so it
> matches other places where we print physical address ranges. See
> https://lkml.org/lkml/2012/2/13/436
Hmm, no one reviews/acks patch. So I am not sure whether we need to do this.
So I think there is no need to use such format now.
Thanks
Wen Congyang
>
> Bjorn
>
prev parent reply other threads:[~2012-05-24 5:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 7:02 [PATCH 1/2] x86: add max_addr boot option Wen Congyang
2012-05-22 7:05 ` [PATCH 2/2] x86: reimplement mem " Wen Congyang
2012-05-22 19:51 ` [PATCH 1/2] x86: add max_addr " Rob Landley
2012-05-23 1:23 ` Wen Congyang
2012-05-23 4:06 ` KAMEZAWA Hiroyuki
2012-05-23 14:25 ` Bjorn Helgaas
2012-05-24 5:19 ` Wen Congyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBDC4F4.4000404@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rob@landley.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.