From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v5 0/9] KVM: fast page fault
Date: Thu, 24 May 2012 14:31:38 +0800 [thread overview]
Message-ID: <4FBDD5CA.9020906@linux.vnet.ibm.com> (raw)
In-Reply-To: <4FBCCC09.3020605@redhat.com>
On 05/23/2012 07:37 PM, Avi Kivity wrote:
> On 05/23/2012 11:51 AM, Xiao Guangrong wrote:
>> Changlog:
>> This are some changes from Marcelo's review:
>> - drop SPTE_WRITE_PROTECT bit, now, only one bit is needed to do
>> lockless update.
>>
>> - always atomicly update spte if it can be updated out of mmu-lock.
>>
>> - flod the judgement of tlb flush into mmu_spte_update(), make the
>> code easilyer audited.
>>
>> Performance result:
>> - autoest migration test (smp2.Fedora.16.64.migrate.with_autotest.dbench.unix):
>> before after
>> smp2.Fedora.16.64.migrate.unix 93 91 +2.1%
>> smp2.Fedora.16.64.migrate.with_autotest.dbench.unix 218 188 +13.7%
>>
>> - the benchmark attached is used to measure the resuming time
>> after dirty-log
>> before after
>> Run 10 times, Avg time: 512466818 ns. 269231261 ns +47.5%
>
> Still scary (esp. indirect sptes), but looks pretty good.
Hmm, i do not have a better way to solve the ABA problem on indirect spte now. :(
How about only allow fast page fault to work for direct spte?
next prev parent reply other threads:[~2012-05-24 6:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 8:51 [PATCH v5 0/9] KVM: fast page fault Xiao Guangrong
2012-05-23 8:51 ` [PATCH v5 1/9] KVM: MMU: return bool in __rmap_write_protect Xiao Guangrong
2012-05-23 8:52 ` [PATCH v5 2/9] KVM: MMU: abstract spte write-protect Xiao Guangrong
2012-05-23 8:53 ` [PATCH v5 3/9] KVM: VMX: export PFEC.P bit on ept Xiao Guangrong
2012-05-23 8:53 ` [PATCH v5 4/9] KVM: MMU: fold tlb flush judgement into mmu_spte_update Xiao Guangrong
2012-05-23 8:55 ` [PATCH v5 5/9] KVM: MMU: introduce SPTE_MMU_WRITEABLE bit Xiao Guangrong
2012-05-23 8:55 ` [PATCH v5 6/9] KVM: MMU: fast path of handling guest page fault Xiao Guangrong
2012-05-23 11:34 ` Avi Kivity
2012-05-24 6:26 ` Xiao Guangrong
2012-05-24 8:25 ` Avi Kivity
2012-05-24 9:03 ` Xiao Guangrong
2012-05-23 8:56 ` [PATCH v5 7/9] KVM: MMU: trace fast " Xiao Guangrong
2012-05-23 8:57 ` [PATCH v5 8/9] KVM: MMU: fix kvm_mmu_pagetable_walk tracepoint Xiao Guangrong
2012-05-23 8:57 ` [PATCH v5 9/9] KVM: MMU: document mmu-lock and fast page fault Xiao Guangrong
2012-05-23 11:37 ` [PATCH v5 0/9] KVM: " Avi Kivity
2012-05-24 6:31 ` Xiao Guangrong [this message]
2012-05-24 7:19 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBDD5CA.9020906@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.