Re: [PATCH v3] ath6kl: Add support for setting tx rateset.

[Kalle Valo <kvalo@qca.qualcomm.com>]

On 05/22/2012 10:53 AM, Bala Shanmugam wrote:
> Tx legacy and mcs rateset can configured using iw for
> 2.4 and 5 bands.  Add support for the same in driver.
> 
> Signed-off-by: Bala Shanmugam <bkamatch@qca.qualcomm.com>

Thanks, this looks very good now. I did two minor changes still:

    kvalo: add an enum for the hw flags and rename the flag accordingly,
    rename ath6kl_cfg80211_set_bitrate_mask() to a shorter version to make
    it easier to indent

The enum looks like this:

enum ath6kl_hw_flags {
	ATH6KL_HW_FLAG_64BIT_RATES	= BIT(0),
};

And I did that just to make it more obvious to group the flags in the
future.

Kalle