From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXWAY-0000T6-QO for qemu-devel@nongnu.org; Thu, 24 May 2012 07:25:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXWAT-0006zj-8v for qemu-devel@nongnu.org; Thu, 24 May 2012 07:25:26 -0400 Received: from goliath.siemens.de ([192.35.17.28]:17474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXWAS-0006zD-VT for qemu-devel@nongnu.org; Thu, 24 May 2012 07:25:21 -0400 Message-ID: <4FBE1A98.3090708@siemens.com> Date: Thu, 24 May 2012 08:25:12 -0300 From: Jan Kiszka MIME-Version: 1.0 References: <4FBD9E3A.6080704@web.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: Blue Swirl , TeLeMan , qemu-devel , Avi Kivity On 2012-05-24 07:51, Max Filippov wrote: > On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> tb_invalidate_phys_addr has to called with the exact physical address of >> the breakpoint we add/remove, not just the page's base address. >> Otherwise we easily fail to flush the right TB. >> >> Regression of 1e7855a558. > > Sorry, I fail to see how 1e7855a558 could introduce a regression, it > just rearranged the code. > Even more, AFAIK cpu_get_phys_page_debug returns complete physical > address, not just > physical page. Probably it has a misleading name. Unfortunately, cpu_get_phys_page_debug does NOT deliver the sub-page offset, only the page base address. So the regression was caused by this refactoring. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux