From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXWZd-0007U1-Ca for qemu-devel@nongnu.org; Thu, 24 May 2012 07:51:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXWZY-0006GX-MW for qemu-devel@nongnu.org; Thu, 24 May 2012 07:51:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXWZY-0006DI-Fc for qemu-devel@nongnu.org; Thu, 24 May 2012 07:51:16 -0400 Message-ID: <4FBE20B0.5010808@redhat.com> Date: Thu, 24 May 2012 13:51:12 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1337859784-24097-1-git-send-email-armbru@redhat.com> <1337859784-24097-3-git-send-email-armbru@redhat.com> In-Reply-To: <1337859784-24097-3-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws, afaerber@suse.de Il 24/05/2012 13:43, Markus Armbruster ha scritto: > Note: qdev objects (subtype of TYPE_DEVICE) created with qom-new lack > additional magic performed by qdev_try_create(), and almost certainly > won't work. True. With the patches on the list, all that adev_try_create does is really dev->parent_bus = bus; bus_add_child(bus, dev); We should change that to a parent_bus property, so that device_add is really qom-new + qom-set parent_bus. Paolo