All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Haggerty <haggerty@jpk.com>
To: Jeff King <peff@peff.net>
Cc: git discussion list <git@vger.kernel.org>
Subject: t4014 broken by 43ae9f47ab: format-patch: use default email for generating message ids
Date: Thu, 24 May 2012 14:01:57 +0200	[thread overview]
Message-ID: <4FBE2335.2090903@jpk.com> (raw)

On my setup, the above commit causes 12 tests in t4014 to fail.  For 
example, test 25:

> expecting success:
>         check_threading expect.thread --thread master
>
> --- expect.thread       2012-05-24 11:57:26.841337237 +0000
> +++ actual      2012-05-24 11:57:26.853337255 +0000
> @@ -1,10 +1,10 @@
>  ---
> -Message-Id: <0>
> +Message-Id: <1135adfeed86678c55e1aad7c568046ee8215660.1337860646.git.mhagger@michael.(none)>
>  ---
> -Message-Id: <1>
> -In-Reply-To: <0>
> -References: <0>
> +Message-Id: <fd00575a8382ce27c62b83730a40bcff1dc2f25f.1337860646.git.mhagger@michael.(none)>
> +In-Reply-To: <1135adfeed86678c55e1aad7c568046ee8215660.1337860646.git.mhagger@michael.(none)>
> +References: <1135adfeed86678c55e1aad7c568046ee8215660.1337860646.git.mhagger@michael.(none)>
>  ---
> -Message-Id: <2>
> -In-Reply-To: <0>
> -References: <0>
> +Message-Id: <18ed22aae56367787c36a882bd61281e07994f11.1337860646.git.mhagger@michael.(none)>
> +In-Reply-To: <1135adfeed86678c55e1aad7c568046ee8215660.1337860646.git.mhagger@michael.(none)>
> +References: <1135adfeed86678c55e1aad7c568046ee8215660.1337860646.git.mhagger@michael.(none)>
> not ok - 25 thread

Beyond bisecting, I haven't looked into this problem further.  Let me 
know if you need more info.

Michael

-- 
Michael Haggerty
Head of Software Development

JPK Instruments AG
Bouchéstr. 12
12435 Berlin, Germany

tel:  +49 30 5331 12070
fax:  +49 30 5331 22555
mail: haggerty@jpk.com
web:  www.jpk.com, www.nanobioviews.net

Aufsichtsrat: Dr. Franz-Ferdinand von Falkenhausen (Vorsitzender)
Vorstand:     Torsten Jähnke, Frank Pelzer, Jörn Kamps, René Grünberg

JPKinstruments Aktiengesellschaft
Amtsgericht Berlin-Charlottenburg
HRB 75513

             reply	other threads:[~2012-05-24 12:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 12:01 Michael Haggerty [this message]
2012-05-24 17:16 ` t4014 broken by 43ae9f47ab: format-patch: use default email for generating message ids Jeff King
2012-05-24 20:07   ` Junio C Hamano
2012-05-24 20:15     ` Jeff King
2012-05-24 23:25       ` Jeff King
2012-05-24 23:26         ` [PATCH 1/7] ident: refactor empty ident error message Jeff King
2012-05-24 23:26         ` [PATCH 2/7] ident: refactor NO_DATE flag in fmt_ident Jeff King
2012-05-24 23:27         ` [PATCH 3/7] ident: let callers omit name with fmt_indent Jeff King
2012-05-24 23:28         ` [PATCH 4/7] format-patch: use GIT_COMMITTER_EMAIL in message ids Jeff King
2012-05-24 23:28         ` [PATCH 5/7] ident: rename IDENT_ERROR_ON_NO_NAME to IDENT_STRICT Jeff King
2012-05-24 23:32         ` [PATCH 6/7] ident: reject bogus email addresses with IDENT_STRICT Jeff King
2012-05-24 23:32         ` [PATCH 7/7] format-patch: do not use bogus email addresses in message ids Jeff King
2012-05-25  0:08         ` t4014 broken by 43ae9f47ab: format-patch: use default email for generating " Junio C Hamano
2012-05-25  0:34           ` Jeff King
2012-05-24 20:49   ` Michael Haggerty
2012-05-24 21:02     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBE2335.2090903@jpk.com \
    --to=haggerty@jpk.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.