From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52609)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SXWyV-0007Zl-Kh
	for qemu-devel@nongnu.org; Thu, 24 May 2012 08:17:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SXWyP-0006Lw-6l
	for qemu-devel@nongnu.org; Thu, 24 May 2012 08:17:03 -0400
Received: from thoth.sbs.de ([192.35.17.2]:17798)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SXWyO-0006La-LY
	for qemu-devel@nongnu.org; Thu, 24 May 2012 08:16:56 -0400
Message-ID: <4FBE26AF.2090103@siemens.com>
Date: Thu, 24 May 2012 09:16:47 -0300
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4FBD9E3A.6080704@web.de>
	<CAMo8Bf+pWij2ojdGT02Fyo+DmbMjxvAzOm6sV_f-D7vaJDE_AQ@mail.gmail.com>
	<4FBE1A98.3090708@siemens.com>
	<CAMo8BfKN15QHRLPhtVc4mRF8bsKwZO=FiF0gU9SdL6qpY-LWWQ@mail.gmail.com>
In-Reply-To: <CAMo8BfKN15QHRLPhtVc4mRF8bsKwZO=FiF0gU9SdL6qpY-LWWQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint
	insertion/deletion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

On 2012-05-24 09:08, Max Filippov wrote:
> On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2012-05-24 07:51, Max Filippov wrote:
>>> On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> tb_invalidate_phys_addr has to called with the exact physical address of
>>>> the breakpoint we add/remove, not just the page's base address.
>>>> Otherwise we easily fail to flush the right TB.
>>>>
>>>> Regression of 1e7855a558.
>>>
>>> Sorry, I fail to see how 1e7855a558 could introduce a regression, it
>>> just rearranged the code.
>>> Even more, AFAIK cpu_get_phys_page_debug returns complete physical
>>> address, not just
>>> physical page. Probably it has a misleading name.
>>
>> Unfortunately, cpu_get_phys_page_debug does NOT deliver the sub-page
>> offset, only the page base address.
> 
> Ok, i386 has probably the most explicit implementation,
> let's look at the target-i386/helper.c:876
> 
>     page_offset = (addr & TARGET_PAGE_MASK) & (page_size - 1);
>     paddr = (pte & TARGET_PAGE_MASK) + page_offset;
>     return paddr;
> 
> that's clearly physical page plus in-page offset.
> I can provide other samples (:

"page_offset" is misleading: addr & TARGET_PAGE_MASK kills all the
offset bits. It will only contain the relevant bits between page_size
and TARGET_PAGE_SIZE.

Check also ppc's cpu_get_phys_page_debug, it's clearer in this regard.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux