All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	afaerber@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new
Date: Thu, 24 May 2012 07:58:05 -0500	[thread overview]
Message-ID: <4FBE305D.3020705@codemonkey.ws> (raw)
In-Reply-To: <4FBE20B0.5010808@redhat.com>

On 05/24/2012 06:51 AM, Paolo Bonzini wrote:
> Il 24/05/2012 13:43, Markus Armbruster ha scritto:
>> Note: qdev objects (subtype of TYPE_DEVICE) created with qom-new lack
>> additional magic performed by qdev_try_create(), and almost certainly
>> won't work.
>
> True.  With the patches on the list, all that adev_try_create does is really
>
>      dev->parent_bus = bus;
>      bus_add_child(bus, dev);
>
> We should change that to a parent_bus property,

parent_bus is a property with the QOM bus series (which is part of your Push, 
push, series, no?).

You still can't add a bus as a child.  We need a magic child[*] link that acts 
like a clone file.  Shouldn't be hard to add.

Regards,

Anthony Liguori

  so that device_add is
> really qom-new + qom-set parent_bus.
>
> Paolo

  reply	other threads:[~2012-05-24 12:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 11:43 [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new Markus Armbruster
2012-05-24 11:43 ` [Qemu-devel] [PATCH RFC 1/2] qom: Give type_get_by_name() external linkage Markus Armbruster
2012-05-24 11:43 ` [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new Markus Armbruster
2012-05-24 11:51   ` Paolo Bonzini
2012-05-24 12:58     ` Anthony Liguori [this message]
2012-05-24 13:01       ` Andreas Färber
2012-05-24 13:44       ` Paolo Bonzini
2012-05-24 14:12         ` Anthony Liguori
2012-05-24 13:04   ` Anthony Liguori
2012-05-24 13:48     ` Igor Mammedov
2012-05-24 14:01       ` Andreas Färber
2012-05-24 14:07         ` Anthony Liguori
2012-05-24 15:33         ` Igor Mammedov
2012-05-24 14:04       ` Anthony Liguori
2012-05-24 14:24     ` Markus Armbruster
2012-05-24 15:15       ` Michael Roth
2012-05-24 12:32 ` [Qemu-devel] [PATCH RFC 0/2] QMP " Andreas Färber
2012-05-24 13:06   ` Anthony Liguori
2012-05-24 13:18     ` Peter Maydell
2012-05-24 14:10       ` Anthony Liguori
2012-05-24 14:23         ` Peter Maydell
2012-05-24 14:35           ` Anthony Liguori
2012-05-24 14:52             ` Peter Maydell
2012-05-24 14:08   ` Markus Armbruster
2012-05-24 14:31     ` Andreas Färber
2012-05-24 14:48       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBE305D.3020705@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.