From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SXa9w-0005kf-VE for mharc-grub-devel@gnu.org; Thu, 24 May 2012 11:41:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXa9q-0005jZ-0C for grub-devel@gnu.org; Thu, 24 May 2012 11:41:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXa9j-0005vI-Lk for grub-devel@gnu.org; Thu, 24 May 2012 11:40:57 -0400 Received: from mail-bk0-f41.google.com ([209.85.214.41]:52652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXa9j-0005uG-Ct for grub-devel@gnu.org; Thu, 24 May 2012 11:40:51 -0400 Received: by bkcjm19 with SMTP id jm19so7787867bkc.0 for ; Thu, 24 May 2012 08:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=jybyQ+A2gZoKooms80F7pRAI5/INLcEf4I5LJXfS2bs=; b=qilxiYIwL6ZX9PW0/sPb+oD59eeKbH7PrZekBT8UwI1JNan98P7fjHqv9JBzf5OFcj 5WBQCzYVYkT3vnRdzyf7hCy3ld97ZSSQlWk9/gSMPiVRr0NcpGWlNNz8B3xShNEY8HLm Q9fDi/I0nNRtBrUHbtgjwvL2YntZYnOT3d+AEQ2E7x5+qYtcR3pWhuAJuCUOvHxDnLrx bxgGiSwLc9j3XyjAtBLhsd0a/+ukVKGvgyAZHMfJ5eh97Pv8j0Y6Pnb8r9nZGkD6KjzI rC6oCAZPH/nHgV27TLGrNGyPFJ886NDeyx5/3wfQkjdYy28ULvDg+CxmdDhEnwvjop1q pvZA== Received: by 10.204.152.75 with SMTP id f11mr4905484bkw.103.1337874048673; Thu, 24 May 2012 08:40:48 -0700 (PDT) Received: from debian.x201.phnet (3-233.197-178.cust.bluewin.ch. [178.197.233.3]) by mx.google.com with ESMTPS id e20sm3365930bkv.10.2012.05.24.08.40.47 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 May 2012 08:40:48 -0700 (PDT) Message-ID: <4FBE567B.6090508@gmail.com> Date: Thu, 24 May 2012 17:40:43 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] Add support for entering the firmware setup screen. References: <1337869896-3671-1-git-send-email-pjones@redhat.com> In-Reply-To: <1337869896-3671-1-git-send-email-pjones@redhat.com> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig5E1E7D6641424C0AB9C62E3A" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2012 15:41:03 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5E1E7D6641424C0AB9C62E3A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24.05.2012 16:31, Peter Jones wrote: > + if (old_os_indications !=3D NULL && oi_size =3D=3D 8) > + os_indications |=3D *old_os_indications; > + Could you make this 8 a sizeof ? Other than that the patch is good and is approved post-2.0 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig5E1E7D6641424C0AB9C62E3A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk++VnsACgkQNak7dOguQgk2KgEAoVbrwAgVor47y4FIiilDtivx 6mTmDtVs5jb/z3gLL5kA/1OyO58BJPqYLtHs13qaW7wDSNftIWFlec4zjempntzr =XkZ6 -----END PGP SIGNATURE----- --------------enig5E1E7D6641424C0AB9C62E3A--