All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] distutils.bbclass: don't delete .pyo files
Date: Thu, 24 May 2012 10:57:02 -0700	[thread overview]
Message-ID: <4FBE766E.50009@linux.intel.com> (raw)
In-Reply-To: <1337633664-19754-1-git-send-email-obi@opendreambox.org>

On 05/21/2012 01:54 PM, Andreas Oberritter wrote:
> * Deleting .pyo files causes them to get compiled on the target.
> * First boot gets *really* slow for python based projects.
> * No space gets saved on the target.
> * The package manager doesn't know about the files and
>    therefore fails to uninstall them, occupying space and causing
>    uninstalled python scripts to remain executable.
> * It's inconsistent, because python itself and autotools based
>    projects already ship .pyo files.
> * Probably .pyo files were deleted because .pyc files were
>    available earlier, but this has changed and OE-Core's python
>    now only generates optimized .pyo files. Deletion of .pyo was
>    introduced in 2008, python/04-default-is-optimized.patch
>    was introduced in 2009.
>
> Signed-off-by: Andreas Oberritter<obi@opendreambox.org>
> ---
>   meta/classes/distutils.bbclass |    4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/meta/classes/distutils.bbclass b/meta/classes/distutils.bbclass
> index 18ae805..bcddf8d 100644
> --- a/meta/classes/distutils.bbclass
> +++ b/meta/classes/distutils.bbclass
> @@ -65,10 +65,6 @@ distutils_do_install() {
>           if test -e ${D}${datadir}/share; then
>               mv -f ${D}${datadir}/share/* ${D}${datadir}/
>           fi
> -
> -        # These are generated files, on really slow systems the storage/speed trade off
> -        # might be worth it, but in general it isn't
> -        find ${D}${libdir}/${PYTHON_DIR}/site-packages -iname '*.pyo' -exec rm {} \;
>   }
>
>   EXPORT_FUNCTIONS do_compile do_install


Merged these 2 into OE-Core

Thanks
	Sau!



      parent reply	other threads:[~2012-05-24 18:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 20:54 [PATCH 1/2] distutils.bbclass: don't delete .pyo files Andreas Oberritter
2012-05-21 20:54 ` [PATCH 2/2] python: bump PR of packages after update of distutils.bbclass Andreas Oberritter
2012-05-24 17:57 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBE766E.50009@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.