From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXcWa-0003Zm-Pl for qemu-devel@nongnu.org; Thu, 24 May 2012 14:12:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXcWX-0001gF-Qv for qemu-devel@nongnu.org; Thu, 24 May 2012 14:12:36 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:45974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXcWX-0001f7-Bs for qemu-devel@nongnu.org; Thu, 24 May 2012 14:12:33 -0400 Message-ID: <4FBE7A0C.3060707@weilnetz.de> Date: Thu, 24 May 2012 20:12:28 +0200 From: Stefan Weil MIME-Version: 1.0 References: <4FBC5C67.1080007@suse.de> <4FBD42D9.6050809@suse.de> <4FBD4C2F.5080606@codemonkey.ws> <4FBE393A.4090508@suse.de> In-Reply-To: <4FBE393A.4090508@suse.de> Content-Type: multipart/alternative; boundary="------------070906050907020606010003" Subject: Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Blue Swirl , TeLeMan , Avi Kivity , Anthony Liguori , qemu-devel This is a multi-part message in MIME format. --------------070906050907020606010003 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Am 24.05.2012 15:35, schrieb Andreas F=C3=A4rber: > Am 24.05.2012 04:12, schrieb TeLeMan: >> I won't use >> my Chinese name because I think it's my privacy. > > That exactly is touching the core point: Signed-off-by is about > transparency and taking responsibility for your actions, not hiding in > anonymity. It's a certification of whom the code came from and who woul= d > be to blame if anything was wrong with that (think non-GPL-compatible > code taken from somewhere else). > > Why should you be granted more privacy than us just because your name i= s > Chinese? There's quite a few Chinese IBM guys around that don't seem to > have any problem with this, and git would even handle UTF-8 characters > quite well if desired[*]. > > Andreas > > > [*] For example, > > commit e965fc380703110e967febf8d5b2ecd7db53b5d2 > Author: =E9=99=B3=E9=9F=8B=E4=BB=BB > Date: Mon Feb 6 14:02:55 2012 +0800 > > cpu-exec.c: Correct comment about this file and indentation cleanu= p > > Each target uses the #define macro (in target-xxx/cpu.h) to rename > cpu_exec (cpu-exec.c) to cpu_xxx_exec, then defines its own cpu_lo= op > which calls cpu_xxx_exec. So basically, cpu-exec.c is not only the= i386 > emulator main execution loop. This patch corrects the comment of t= his > file and does indentation cleanup. > > Signed-off-by: Chen Wei-Ren (=E9=99=B3=E9=9F=8B=E4=BB=BB) > Signed-off-by: Stefan Hajnoczi This discussion looks strange for me. If someone contributes to QEMU not only with patches but also on qemu-devel and in other forms since a long time, I appreciate his/her contributions, no matter what his/her name is. Names are not absolute. There are cultural differences with regard to names and their meaning - just think of the way names change when someone gets married. There are a lot of good and acceptable reasons why someone chooses to use a nickname or a pseudonym. If we strictly enforce real names, some people would simply choose a pseudonym. Maybe others would stop contributing. Therefore I suggest a pragmatical approach: if someone contributes for the first time using a nickname, it is good practice to tell that per= son that a real name is wanted. I would not insist on a real name, because there is no way to verify it, but verify such patches more carefully. When people contribute using a nick name for a long time, that nick _is_ their name, and I know them by that name as I know Andreas, Anthony or Avi. Blue and TeLeMan are well known names. I did not review the patch, but if the code is ok, I suggest to apply it. Regards, Stefan W. --------------070906050907020606010003 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 24.05.2012 15:35, schrieb Andreas F=C3=A4rber: 
Am 24.05.2012 04:12, schrieb TeLeMan:

I won't use
my Chinese name because I think it's my privacy.


That exactly is touching the core point: Signed-off-by is about
transparency and taking responsibility for your actions, not hiding in
anonymity. It's a certification of whom the code came from and who would
be to blame if anything was wrong with that (think non-GPL-compatible
code taken from somewhere else).

Why should you be granted more privacy than us just because your name is
Chinese? There's quite a few Chinese IBM guys around that don't seem to
have any problem with this, and git would even handle UTF-8 characters
quite well if desired[*].

Andreas


[*] For example,

commit e965fc380703110e967febf8d5b2ecd7db53b5d2
Author: =E9=99=B3=E9=9F=8B=E4=BB=BB <chenwj@iis.sinica.edu.tw>
Date:   Mon Feb 6 14:02:55 2012 +0800

    cpu-exec.c: Correct comment about this file and indentation cleanup

    Each target uses the #define macro (in target-xxx/cpu.h) to rename
    cpu_exec (cpu-exec.c) to cpu_xxx_exec, then defines its own cpu_loop
    which calls cpu_xxx_exec. So basically, cpu-exec.c is not only the i3=
86
    emulator main execution loop. This patch corrects the comment of this
    file and does indentation cleanup.

    Signed-off-by: Chen Wei-Ren (=E9=99=B3=E9=9F=8B=E4=BB=BB) <chen=
wj@iis.sinica.edu.tw>
    Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com&=
gt;

This discussion looks strange for me.

If someone contributes to QEMU not only with patches but also
on qemu-devel and in other forms since a long time, I appreciate his/her contributions, no matter what his/her name is.

Names are not absolute. There are cultural differences with regard<= br> to names and their meaning - just think of the way names change
when someone gets married.

There are a lot of good and acceptable reasons why someone chooses<= br> to use a nickname or a pseudonym.

If we strictly enforce real names, some people would simply choose<= br>
a pseudonym. Maybe others would stop contributing.

Therefore I suggest a pragmatical approach: if someone contributes<= br> for the first time using a nickname, it is good practice to tell that person
that a real name is wanted. I would not insist on a real name,
because there is no way to verify it, but verify such patches more<= br> carefully.

When people contribute using a nick name for a long time,
that nick _is_ their name, and I know them by that name as I know Andreas, Anthony or Avi. Blue and TeLeMan are well known names.

I did not review the patch, but if the code is ok, I suggest to
apply it.

Regards,

Stefan W.

 --------------070906050907020606010003--