From: "Crístian Viana" <vianac@linux.vnet.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1 v4] Allow machines to configure the QEMU_VERSION that's exposed via hardware
Date: Thu, 24 May 2012 16:54:27 -0300 [thread overview]
Message-ID: <4FBE91F3.3050502@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAFEAcA_6Te6fgTYES7pesjhH8in_3QMR3-czcKgvUxqLHeWoeA@mail.gmail.com>
On 23-05-2012 17:54, Peter Maydell wrote:
> The point is that your snprintf is not actually using the full power of
> a format string parser, it's just concatenating two strings ("QEMU "
> and the version). The simple way to put two strings into a buffer
> one after the other is to copy string A and then concatenate string
> B on the end.
I got it. That has been fixed in three snippets of my patch, thanks!
Best regards,
Crístian.
prev parent reply other threads:[~2012-05-24 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 21:10 [Qemu-devel] [PATCH 1/1 v4] Allow machines to configure the QEMU_VERSION that's exposed via hardware Crístian Viana
2012-05-22 21:38 ` Peter Maydell
2012-05-23 16:08 ` Crístian Viana
2012-05-23 16:11 ` Eric Blake
2012-05-23 20:06 ` Crístian Viana
2012-05-23 20:54 ` Peter Maydell
2012-05-24 19:54 ` Crístian Viana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE91F3.3050502@linux.vnet.ibm.com \
--to=vianac@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.