From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] tegra: usb: Add USB support to Tamonten boards
Date: Thu, 24 May 2012 16:13:43 -0600 [thread overview]
Message-ID: <4FBEB297.4090008@wwwdotorg.org> (raw)
In-Reply-To: <20120524210717.GB13236@avionic-0098.adnet.avionic-design.de>
On 05/24/2012 03:07 PM, Thierry Reding wrote:
> * Stephen Warren wrote:
>> On 05/24/2012 01:04 AM, Thierry Reding wrote:
>>> This adds basic USB support for port 0. Device tree support is
>>> needed to initialize the USB EHCI and will be added in a
>>> subsequent patch.
...
>> The code here duplicates changes made to
>> board/nvidia/common/board.c. Shouldn't all Tegra boards be using
>> that common board code so we don't have to duplicate all this
>> early setup for every board vendor using Tegra? Otherwise, every
>> time we add I2C, SPI, LP0, ... to board/nvidia/common/board.c,
>> you'll just have to make the same change to tamonten.c too.
>
> I think the problem is U-Boot's build system, which doesn't allow
> sharing code between different subdirectories of board/.
I have both board/compulab/trimslice and board/compal/paz00 sharing
the board/nvidia/common code; take a look at their Makefiles.
next prev parent reply other threads:[~2012-05-24 22:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 7:04 [U-Boot] [PATCH 1/3] tegra: usb: Add USB support to Tamonten boards Thierry Reding
2012-05-24 7:04 ` [U-Boot] [PATCH 2/3] tegra: medcom: Add device tree support Thierry Reding
2012-05-24 15:51 ` Stephen Warren
2012-05-24 21:09 ` Thierry Reding
2012-05-24 7:04 ` [U-Boot] [PATCH 3/3] tegra: plutux: " Thierry Reding
2012-05-24 15:51 ` Stephen Warren
2012-05-24 15:46 ` [U-Boot] [PATCH 1/3] tegra: usb: Add USB support to Tamonten boards Stephen Warren
2012-05-24 21:07 ` Thierry Reding
2012-05-24 22:13 ` Stephen Warren [this message]
2012-05-25 4:55 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBEB297.4090008@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.