From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36305)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1SXntY-0008NF-9k
	for qemu-devel@nongnu.org; Fri, 25 May 2012 02:21:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1SXntW-0003r6-Hz
	for qemu-devel@nongnu.org; Fri, 25 May 2012 02:21:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44010)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1SXntW-0003qD-9i
	for qemu-devel@nongnu.org; Fri, 25 May 2012 02:21:02 -0400
Message-ID: <4FBF24B1.8080803@redhat.com>
Date: Fri, 25 May 2012 14:20:33 +0800
From: Amos Kong <akong@redhat.com>
MIME-Version: 1.0
References: <1337916721-14308-1-git-send-email-akong@redhat.com>
	<1337916721-14308-3-git-send-email-akong@redhat.com>
	<4FBF01AE.5000007@redhat.com>
In-Reply-To: <4FBF01AE.5000007@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

On 25/05/12 11:51, Eric Blake wrote:
> On 05/24/2012 09:32 PM, Amos Kong wrote:
>> Convert 'sendkey' to use. do_sendkey() depends on some variables
>> in monitor.c, so reserve qmp_sendkey() to monitor.c
>> Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'
>>
>> Signed-off-by: Amos Kong<akong@redhat.com>
>
>> +##
>> +# @sendkey:
>> +#
>> +# Send keys to VM.
>> +#
>> +# @keys: key sequence
>> +# @hold-time: time to delay key up events
>> +#
>> +# Returns: Nothing on success
>> +#          If key is unknown or redundant, QERR_INVALID_PARAMETER
>> +#          If key is invalid, QERR_INVALID_PARAMETER_VALUE
>> +#
>> +# Notes: Send @var{keys} to the emulator. @var{keys} could be the name of the
>> +#        key or the raw value in either decimal or hexadecimal  format. Use
>> +#        @code{-} to press several keys simultaneously.
>> +#
>> +# Since: 0.14.0
>> +##
>> +{ 'command': 'sendkey', 'data': {'keys': 'str', '*hold-time': 'int'} }
>
> Rather than making 'keys' a free-form string where qemu then has to
> parse '-' to separate keys, should we instead make it a JSON array?  For
> example,


Anthony, Luiz, Daniel,  what's your opinion?


> { "execute":"sendkey", "data":{ "keys":["ctrl", "alt", "del"],
> "hold-time":200 } }

How to make it compatible with hum command? Still use 'ctrl-alt-delete'
for hum, separate keys and generate an array in hum_sendkey() before
calling qmp_sendkey()?


And I'm know clear about how to define command in qapi-schema.json,
I didn't find exist example, any clue?

   { 'command': 'sendkey', 'data': { 'keys': [ 'str'], '*hold-time': 
'int'} }
--
   { 'type': 'Key', 'data': {'name': 'str'} }
   { 'command': 'sendkey', 'data': { 'keys': [ 'Key' ], '*hold-time': 
'int'} }


-- 
			Amos.