All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/3] sched/rt: Remove redundant check before push_rt_task()
Date: Fri, 25 May 2012 15:43:41 +0900	[thread overview]
Message-ID: <4FBF2A1D.2090302@ct.jp.nec.com> (raw)
In-Reply-To: <4FBF29B2.9030904@ct.jp.nec.com>

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

Currently rq->rt.overloaded is checked twice in switched_to_rt().
Remove the first one which out of push_rt_task().

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
 kernel/sched/rt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index c5565c3..a601a70 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1907,7 +1907,7 @@ static void switched_to_rt(struct rq *rq, struct task_struct *p)
 	 */
 	if (p->on_rq && rq->curr != p) {
 #ifdef CONFIG_SMP
-		if (rq->rt.overloaded && push_rt_task(rq) &&
+		if (push_rt_task(rq) &&
 		    /* Don't resched if we changed runqueues */
 		    rq != task_rq(p))
 			check_resched = 0;
-- 
1.7.7.6


  parent reply	other threads:[~2012-05-25  6:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25  6:41 [PATCH 1/3] sched: Make sched_feat_names const Hiroshi Shimamoto
2012-05-25  6:42 ` [PATCH 2/3] sched: Remove the last NULL entry from sched_feat_names Hiroshi Shimamoto
2012-05-30 13:42   ` [tip:sched/urgent] " tip-bot for Hiroshi Shimamoto
2012-05-25  6:43 ` Hiroshi Shimamoto [this message]
2012-05-25  9:39   ` [PATCH 3/3] sched/rt: Remove redundant check before push_rt_task() Peter Zijlstra
2012-05-25 13:08     ` Steven Rostedt
2012-05-30 13:41 ` [tip:sched/urgent] sched: Make sched_feat_names const tip-bot for Hiroshi Shimamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBF2A1D.2090302@ct.jp.nec.com \
    --to=h-shimamoto@ct.jp.nec.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.