From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kardashevskiy Subject: [RFC PATCH] vfio: add fixup for broken PCI devices Date: Fri, 25 May 2012 17:35:03 +1000 Message-ID: <4FBF3627.3030504@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: Benjamin Herrenschmidt , Alex Williamson , David Gibson , Alex Graf , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Alex Williamson Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:55808 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755077Ab2EYHfK (ORCPT ); Fri, 25 May 2012 03:35:10 -0400 Received: by pbbrp8 with SMTP id rp8so1408479pbb.19 for ; Fri, 25 May 2012 00:35:10 -0700 (PDT) Sender: kvm-owner@vger.kernel.org List-ID: Some adapters (like NEC PCI USB controller) do not flush their config on a sioftware reset and remember DMA config, etc. If we use such an adapter with QEMU, then crash QEMU (stop it with ctrl-A ctrl-X), and try to use it in QEMU again, it may start working immediately with previous config when pci_enable_device() is called on that PCI function. To eliminate such effect, some quirk should be called. The proposed pci_fixup_final does its job well for mentioned NEC PCI USB but not sure if it is 100% correct. Signed-off-by: Alexey Kardashevskiy --- drivers/vfio/pci/vfio_pci.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 1e5315c..6e7c12d 100644 --- a/drivers/vfio/pci/vfio_pci.c +++ b/drivers/vfio/pci/vfio_pci.c @@ -88,6 +88,8 @@ static void vfio_pci_disable(struct vfio_pci_device *vdev) { int bar; + pci_fixup_device(pci_fixup_final, vdev->pdev); + pci_disable_device(vdev->pdev); vfio_pci_set_irqs_ioctl(vdev, VFIO_IRQ_SET_DATA_NONE | -- 1.7.7.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXp3L-0004Sb-HA for qemu-devel@nongnu.org; Fri, 25 May 2012 03:35:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXp3J-0003nL-Ij for qemu-devel@nongnu.org; Fri, 25 May 2012 03:35:15 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:62343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXp3J-0003mQ-DE for qemu-devel@nongnu.org; Fri, 25 May 2012 03:35:13 -0400 Received: by pbbro12 with SMTP id ro12so1566202pbb.4 for ; Fri, 25 May 2012 00:35:10 -0700 (PDT) Message-ID: <4FBF3627.3030504@ozlabs.ru> Date: Fri, 25 May 2012 17:35:03 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, Alex Graf , David Gibson Some adapters (like NEC PCI USB controller) do not flush their config on a sioftware reset and remember DMA config, etc. If we use such an adapter with QEMU, then crash QEMU (stop it with ctrl-A ctrl-X), and try to use it in QEMU again, it may start working immediately with previous config when pci_enable_device() is called on that PCI function. To eliminate such effect, some quirk should be called. The proposed pci_fixup_final does its job well for mentioned NEC PCI USB but not sure if it is 100% correct. Signed-off-by: Alexey Kardashevskiy --- drivers/vfio/pci/vfio_pci.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 1e5315c..6e7c12d 100644 --- a/drivers/vfio/pci/vfio_pci.c +++ b/drivers/vfio/pci/vfio_pci.c @@ -88,6 +88,8 @@ static void vfio_pci_disable(struct vfio_pci_device *vdev) { int bar; + pci_fixup_device(pci_fixup_final, vdev->pdev); + pci_disable_device(vdev->pdev); vfio_pci_set_irqs_ioctl(vdev, VFIO_IRQ_SET_DATA_NONE | -- 1.7.7.3