From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXucm-0005rl-5r for qemu-devel@nongnu.org; Fri, 25 May 2012 09:32:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXuck-0005MA-EA for qemu-devel@nongnu.org; Fri, 25 May 2012 09:32:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49113 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXuck-0005Lb-82 for qemu-devel@nongnu.org; Fri, 25 May 2012 09:32:10 -0400 Message-ID: <4FBF89D2.1020901@suse.de> Date: Fri, 25 May 2012 15:32:02 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1337787881-3579-1-git-send-email-pbonzini@redhat.com> <1337787881-3579-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1337787881-3579-8-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 07/10] qdev: move bulk of qdev-properties.c to qom/object.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: imammedo@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , peter.maydell@linaro.org Am 23.05.2012 17:44, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > hw/qdev-properties.c | 487 +++++------------------------------------= -------- > hw/qdev.c | 47 +---- > hw/qdev.h | 87 --------- > include/qemu/object.h | 98 ++++++++++ > qom/object.c | 459 +++++++++++++++++++++++++++++++++++++++++= +++++ > 5 files changed, 604 insertions(+), 574 deletions(-) I'm not so fond of blowing up object.c with stuff that was originally in its own file. Had you considered a new qom/object-properties.c? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg