From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SYE4p-0003Dp-FK for mharc-grub-devel@gnu.org; Sat, 26 May 2012 06:18:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYE4n-0003Dj-8b for grub-devel@gnu.org; Sat, 26 May 2012 06:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYE4l-0007Ff-3V for grub-devel@gnu.org; Sat, 26 May 2012 06:18:24 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:64195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYE4k-0007FK-RP for grub-devel@gnu.org; Sat, 26 May 2012 06:18:23 -0400 Received: by wefh52 with SMTP id h52so1350698wef.0 for ; Sat, 26 May 2012 03:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=PwC6veS+wNOfcY8MxWEXXk/pcLEin94nXHlKOyp8FWk=; b=Hk2wuqNf7gkbf6vdVERStGHoglNKmIaM1HO5Ucmtp3MHmO5cl0JXM51OJGPpIEphNd VKFOQY09DSbNcVYz1dFdKkq2H+xuwCUknly6sSIuNtangVAJuIG/vUSkNf1HYn9WtXUI 53C+O1cXRvdO3kIT35RL+WRdI633rO+gVijh6aRAGJogKkrzA+B1ieabqv/CC4HjIqiA gZM1jw2zrt9m9ZjNIItwnHhsAQ9pjI95PhO7PATnW436BJBSFFtBABc45yx3FCc5u8mz vVwevqlv105MSiGykblmhWNrDIdKCINUce91LXyyUmuH0ylJyP834RzBQsD4bwE+drhk GgIg== Received: by 10.180.86.194 with SMTP id r2mr2718271wiz.15.1338027500234; Sat, 26 May 2012 03:18:20 -0700 (PDT) Received: from debian.x201.phnet (203-122.62-81.cust.bluewin.ch. [81.62.122.203]) by mx.google.com with ESMTPS id j4sm3675968wiz.1.2012.05.26.03.18.18 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 May 2012 03:18:19 -0700 (PDT) Message-ID: <4FC0ADE9.8000904@gmail.com> Date: Sat, 26 May 2012 12:18:17 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [bug #36532] boot in EFI mode (x86_64) fails on some systems References: <959D45574D89AF41A9DADF6F446A2E9A2AE52B06DA@AUSX7MCPS310.AMER.DELL.COM> In-Reply-To: <959D45574D89AF41A9DADF6F446A2E9A2AE52B06DA@AUSX7MCPS310.AMER.DELL.COM> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig95D92761BA1D9B8E611DF8D9" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 May 2012 10:18:26 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig95D92761BA1D9B8E611DF8D9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24.05.2012 19:27, Stuart_Hayes@Dell.com wrote: > Hello=E2=80=A6 >=20 > =20 >=20 > I just submitted a grub2 bug, along with a patch, at > . >=20 > =20 >=20 > Is that the right place for a patch, or should I sent it to this mailin= g > list? This patch is for 1.99. Could you update it to 2.00~beta5 and post here inline? Also problematic are: - Huge copy-paste for determining load address. It should be something like having a function for allocation of initrd-like chunk. - No need to probe for mmap size if we don't use the size. It's extremely unlikely that this call fails for any reason other than small buffer. - You allocate the exact size of mmap. This is wrong as allocating may increase the size of mmap slightly. You need to allocate at least 4K more= =2E --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig95D92761BA1D9B8E611DF8D9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk/AreoACgkQNak7dOguQgnBiwD/V1Yi5o+6ipS++5gzlNi/iUSV 3v7qEdRAr5N4WL4nbXsBAJWoN2JBmfwemeqv80n/toD43BQqYf8llPUjBrRG0NTH =5GNB -----END PGP SIGNATURE----- --------------enig95D92761BA1D9B8E611DF8D9--