From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50918)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SYP6T-0008Mm-N6
	for qemu-devel@nongnu.org; Sat, 26 May 2012 18:04:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SYP6R-0001ld-IH
	for qemu-devel@nongnu.org; Sat, 26 May 2012 18:04:53 -0400
Received: from cantor2.suse.de ([195.135.220.15]:54057 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SYP6R-0001kJ-C5
	for qemu-devel@nongnu.org; Sat, 26 May 2012 18:04:51 -0400
Message-ID: <4FC15375.3070504@suse.de>
Date: Sun, 27 May 2012 00:04:37 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1337787881-3579-1-git-send-email-pbonzini@redhat.com>
	<1337787881-3579-4-git-send-email-pbonzini@redhat.com>
	<4FBFADDB.2070609@suse.de> <4FC0A951.8080005@redhat.com>
In-Reply-To: <4FC0A951.8080005@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 03/10] qom: push error reporting to
	object_property_find
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: imammedo@redhat.com, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, peter.maydell@linaro.org

Am 26.05.2012 11:58, schrieb Paolo Bonzini:
> Il 25/05/2012 18:05, Andreas F=E4rber ha scritto:
>>>> @@ -698,10 +702,8 @@ void object_property_del(Object *obj, const cha=
r *name, Error **errp)
>>>>  void object_property_get(Object *obj, Visitor *v, const char *name,
>>>>                           Error **errp)
>>>>  {
>>>> -    ObjectProperty *prop =3D object_property_find(obj, name);
>>>> -
>>>> +    ObjectProperty *prop =3D object_property_find(obj, name, errp);
>>>>      if (prop =3D=3D NULL) {
>>>> -        error_set(errp, QERR_PROPERTY_NOT_FOUND, "", name);
>>>>          return;
>>>>      }
>>>> =20
>> Currently it doesn't happen, but I wonder if we should check
>> error_is_set(errp) instead of or in addition to prop =3D=3D NULL now?
>> Applies to all callsites above and below.
>=20
> No, because errp can be NULL.

Ah, see it now. I fixed up the duplicated ifs and applied it to qom-next:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg