From: "Andreas Färber" <afaerber@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] ISCSI: If the device we open is a SMC device, then force the use of sg. We dont have any medium changer emulation so only passthrough via real sg or scsi-generic via iscsi would work anyway.
Date: Sun, 27 May 2012 15:12:16 +0200 [thread overview]
Message-ID: <4FC22830.4090705@suse.de> (raw)
In-Reply-To: <jpq16n$7jd$1@dough.gmane.org>
Am 26.05.2012 09:36, schrieb Paolo Bonzini:
> Il 26/05/2012 06:56, Ronnie Sahlberg ha scritto:
>> Forcing sg also makes qemu skip trying to read from the device to guess the image format by reading from the device (find_image_format()).
>> SMC devices do not implement READ6/10/12/16 so it is noit possible to read from them.
>>
>> With this patch I can successfully manage a SMC device wiht iscsi in passthrough mode.
>>
>> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
[...]
> Modified to also do the same for tapes, applied to scsi-next branch for 1.2.
Paolo, it seems you haven't pushed scsi-next since then. I hope you've
also shortened the subject to a humanly bearable length?
Ronnie, please restrict commit message lines to at most 76 characters.
You can check by running `git log` in an 80-char-wide terminal. The
subject line is especially sensitive since this email subject is simply
unreadable. And Patchwork currently looks really ugly in WebKit due to
this patch subject.
https://live.gnome.org/Git/CommitMessages
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-05-27 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 4:56 [Qemu-devel] [PATCH 0/4] ISCSI: Passthough updates Ronnie Sahlberg
2012-05-26 4:56 ` [Qemu-devel] [PATCH 1/4] ISCSI: Only call READCAPACITY16 for SBC devices Ronnie Sahlberg
2012-05-26 4:56 ` [Qemu-devel] [PATCH 2/4] ISCSI: Use READCAPACITY10 for MMC devices Ronnie Sahlberg
2012-05-26 4:56 ` [Qemu-devel] [PATCH 3/4] ISCSI: Only use READ16 for SBC devices. Use READ10 for other device types such as MMC Ronnie Sahlberg
2012-05-26 4:56 ` [Qemu-devel] [PATCH 4/4] ISCSI: If the device we open is a SMC device, then force the use of sg. We dont have any medium changer emulation so only passthrough via real sg or scsi-generic via iscsi would work anyway Ronnie Sahlberg
2012-05-26 7:36 ` Paolo Bonzini
2012-05-27 13:12 ` Andreas Färber [this message]
2012-05-28 6:48 ` Paolo Bonzini
2012-05-28 11:55 ` ronnie sahlberg
2012-05-28 12:05 ` Paolo Bonzini
2012-05-26 7:37 ` [Qemu-devel] [PATCH 0/4] ISCSI: Passthough updates Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC22830.4090705@suse.de \
--to=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.