From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SXnyq-0001W0-LX for mharc-grub-devel@gnu.org; Fri, 25 May 2012 02:26:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXbpd-0003Xt-EM for grub-devel@gnu.org; Thu, 24 May 2012 13:28:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXbpX-00022a-6j for grub-devel@gnu.org; Thu, 24 May 2012 13:28:13 -0400 Received: from ausxippc101.us.dell.com ([143.166.85.207]:55021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXbpW-000209-Lw for grub-devel@gnu.org; Thu, 24 May 2012 13:28:07 -0400 X-Loopcount0: from 10.175.216.250 From: To: Date: Thu, 24 May 2012 12:27:57 -0500 Subject: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Topic: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Index: Ac050o+P97afjN0hQGe5GqvLv3EroA== Message-ID: <959D45574D89AF41A9DADF6F446A2E9A2AE52B06DA@AUSX7MCPS310.AMER.DELL.COM> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: multipart/alternative; boundary="_000_959D45574D89AF41A9DADF6F446A2E9A2AE52B06DAAUSX7MCPS310A_" MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 143.166.85.207 X-Mailman-Approved-At: Fri, 25 May 2012 02:26:30 -0400 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2012 17:28:15 -0000 --_000_959D45574D89AF41A9DADF6F446A2E9A2AE52B06DAAUSX7MCPS310A_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hello... I just submitted a grub2 bug, along with a patch, at . Is that the right place for a patch, or should I sent it to this mailing li= st? Thanks! Stuart --_000_959D45574D89AF41A9DADF6F446A2E9A2AE52B06DAAUSX7MCPS310A_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Hello…

I just submitted a grub2 bug, along wi= th a patch, at <h= ttp://savannah.gnu.org/bugs/?36532>.

Is that the right place for a= patch, or should I sent it to this mailing list?

Thanks!
Stuart<= /o:p>

<= /o:p>

= --_000_959D45574D89AF41A9DADF6F446A2E9A2AE52B06DAAUSX7MCPS310A_-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SYE4p-0003Dp-FK for mharc-grub-devel@gnu.org; Sat, 26 May 2012 06:18:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYE4n-0003Dj-8b for grub-devel@gnu.org; Sat, 26 May 2012 06:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYE4l-0007Ff-3V for grub-devel@gnu.org; Sat, 26 May 2012 06:18:24 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:64195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYE4k-0007FK-RP for grub-devel@gnu.org; Sat, 26 May 2012 06:18:23 -0400 Received: by wefh52 with SMTP id h52so1350698wef.0 for ; Sat, 26 May 2012 03:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=PwC6veS+wNOfcY8MxWEXXk/pcLEin94nXHlKOyp8FWk=; b=Hk2wuqNf7gkbf6vdVERStGHoglNKmIaM1HO5Ucmtp3MHmO5cl0JXM51OJGPpIEphNd VKFOQY09DSbNcVYz1dFdKkq2H+xuwCUknly6sSIuNtangVAJuIG/vUSkNf1HYn9WtXUI 53C+O1cXRvdO3kIT35RL+WRdI633rO+gVijh6aRAGJogKkrzA+B1ieabqv/CC4HjIqiA gZM1jw2zrt9m9ZjNIItwnHhsAQ9pjI95PhO7PATnW436BJBSFFtBABc45yx3FCc5u8mz vVwevqlv105MSiGykblmhWNrDIdKCINUce91LXyyUmuH0ylJyP834RzBQsD4bwE+drhk GgIg== Received: by 10.180.86.194 with SMTP id r2mr2718271wiz.15.1338027500234; Sat, 26 May 2012 03:18:20 -0700 (PDT) Received: from debian.x201.phnet (203-122.62-81.cust.bluewin.ch. [81.62.122.203]) by mx.google.com with ESMTPS id j4sm3675968wiz.1.2012.05.26.03.18.18 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 May 2012 03:18:19 -0700 (PDT) Message-ID: <4FC0ADE9.8000904@gmail.com> Date: Sat, 26 May 2012 12:18:17 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [bug #36532] boot in EFI mode (x86_64) fails on some systems References: <959D45574D89AF41A9DADF6F446A2E9A2AE52B06DA@AUSX7MCPS310.AMER.DELL.COM> In-Reply-To: <959D45574D89AF41A9DADF6F446A2E9A2AE52B06DA@AUSX7MCPS310.AMER.DELL.COM> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig95D92761BA1D9B8E611DF8D9" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 May 2012 10:18:26 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig95D92761BA1D9B8E611DF8D9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24.05.2012 19:27, Stuart_Hayes@Dell.com wrote: > Hello=E2=80=A6 >=20 > =20 >=20 > I just submitted a grub2 bug, along with a patch, at > . >=20 > =20 >=20 > Is that the right place for a patch, or should I sent it to this mailin= g > list? This patch is for 1.99. Could you update it to 2.00~beta5 and post here inline? Also problematic are: - Huge copy-paste for determining load address. It should be something like having a function for allocation of initrd-like chunk. - No need to probe for mmap size if we don't use the size. It's extremely unlikely that this call fails for any reason other than small buffer. - You allocate the exact size of mmap. This is wrong as allocating may increase the size of mmap slightly. You need to allocate at least 4K more= =2E --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig95D92761BA1D9B8E611DF8D9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk/AreoACgkQNak7dOguQgnBiwD/V1Yi5o+6ipS++5gzlNi/iUSV 3v7qEdRAr5N4WL4nbXsBAJWoN2JBmfwemeqv80n/toD43BQqYf8llPUjBrRG0NTH =5GNB -----END PGP SIGNATURE----- --------------enig95D92761BA1D9B8E611DF8D9-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SYepY-0007N3-HM for mharc-grub-devel@gnu.org; Sun, 27 May 2012 10:52:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYepV-0007Me-5n for grub-devel@gnu.org; Sun, 27 May 2012 10:52:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYepS-0001Ue-1q for grub-devel@gnu.org; Sun, 27 May 2012 10:52:24 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:47294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYepR-0001UG-Lk for grub-devel@gnu.org; Sun, 27 May 2012 10:52:21 -0400 Received: by wibhm14 with SMTP id hm14so750563wib.12 for ; Sun, 27 May 2012 07:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=fYcghr4ZCYCjzVRHDYfY1qH1AkLL4lFWJ2PXCDe6uXQ=; b=PgFnW7bLsA8zW3lQp8fi4ScTXX+0AMpgjANdNM8yyeHqPeGiqr2ANuppcq9EENeK8X HJUjeWoh8AJYnZlnHaImxEhVFajscs//3uM6/FPimjO+b/Jlmm/pkdtP721EDC04fVFJ +7XC9MtmXeWpY/BsH7dpu57JOrs8tv3nIEW0tu1IimH+AbdNCb3XE+1Ot/otgFm3B0vV 1BWpQPEybUWwZiXy5R0YSRCFdDK6jKH5OO2pl8sTQBcAZ4ltGSZ0+s7c14KvwZhCARni JRTFNSRtJYu4OpxhIdPN0seoSKsqxVBjzFXvDTseXTxgqiQffAFIjQNLvZ7mpujWE3Yd BkuQ== Received: by 10.180.74.193 with SMTP id w1mr9385062wiv.4.1338130339125; Sun, 27 May 2012 07:52:19 -0700 (PDT) Received: from debian.x201.phnet (141-174.79-83.cust.bluewin.ch. [83.79.174.141]) by mx.google.com with ESMTPS id e20sm14032325wiv.7.2012.05.27.07.52.14 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 27 May 2012 07:52:16 -0700 (PDT) Message-ID: <4FC23F9C.50000@gmail.com> Date: Sun, 27 May 2012 16:52:12 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [bug #36532] boot in EFI mode (x86_64) fails on some systems References: <959D45574D89AF41A9DADF6F446A2E9A2AE52B06DA@AUSX7MCPS310.AMER.DELL.COM> In-Reply-To: <959D45574D89AF41A9DADF6F446A2E9A2AE52B06DA@AUSX7MCPS310.AMER.DELL.COM> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig4A22CE6791F5EC5B7B85D35A" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.171 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 May 2012 14:52:27 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4A22CE6791F5EC5B7B85D35A Content-Type: multipart/mixed; boundary="------------000603060800080401050000" This is a multi-part message in MIME format. --------------000603060800080401050000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24.05.2012 19:27, Stuart_Hayes@Dell.com wrote: > Hello=E2=80=A6 >=20 > =20 >=20 > I just submitted a grub2 bug, along with a patch, at > . Could you test the attached patch on top of HEAD? --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------000603060800080401050000 Content-Type: text/x-diff; name="efi.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="efi.diff" =3D=3D=3D modified file 'grub-core/loader/efi/chainloader.c' --- grub-core/loader/efi/chainloader.c 2012-03-10 19:41:28 +0000 +++ grub-core/loader/efi/chainloader.c 2012-05-27 14:29:35 +0000 @@ -111,14 +111,16 @@ =20 fp->header.type =3D GRUB_EFI_MEDIA_DEVICE_PATH_TYPE; fp->header.subtype =3D GRUB_EFI_FILE_PATH_DEVICE_PATH_SUBTYPE; - size =3D len * sizeof (grub_efi_char16_t) + sizeof (*fp); + + size =3D grub_utf8_to_utf16 (fp->path_name, len * GRUB_MAX_UTF16_PER_U= TF8, + (const grub_uint8_t *) str, len, 0); + for (p =3D fp->path_name; p < fp->path_name + size; p++) + if (*p =3D=3D '/') + *p =3D '\\'; + + size =3D size * sizeof (grub_efi_char16_t) + sizeof (*fp); fp->header.length[0] =3D (grub_efi_uint8_t) (size & 0xff); fp->header.length[1] =3D (grub_efi_uint8_t) (size >> 8); - for (p =3D fp->path_name; len > 0; len--, p++, str++) - { - /* FIXME: this assumes that the path is in ASCII. */ - *p =3D (grub_efi_char16_t) (*str =3D=3D '/' ? '\\' : *str); - } } =20 static grub_efi_device_path_t * @@ -154,6 +156,7 @@ =20 file_path =3D grub_malloc (size + ((grub_strlen (dir_start) + 1) + * GRUB_MAX_UTF16_PER_UTF8 * sizeof (grub_efi_char16_t)) + sizeof (grub_efi_file_path_device_path_t) * 2); if (! file_path) =3D=3D=3D modified file 'grub-core/loader/i386/linux.c' --- grub-core/loader/i386/linux.c 2012-04-17 11:00:06 +0000 +++ grub-core/loader/i386/linux.c 2012-05-27 14:44:23 +0000 @@ -59,14 +59,10 @@ #define ACCEPTS_PURE_TEXT 1 #endif =20 -#define GRUB_LINUX_CL_OFFSET 0x1000 - static grub_dl_t my_mod; =20 static grub_size_t linux_mem_size; static int loaded; -static void *real_mode_mem; -static grub_addr_t real_mode_target; static void *prot_mode_mem; static grub_addr_t prot_mode_target; static void *initrd_mem; @@ -78,6 +74,8 @@ static struct grub_relocator *relocator =3D NULL; static void *efi_mmap_buf; static grub_size_t maximal_cmdline_size; +static struct linux_kernel_params linux_params; +static char *linux_cmdline; #ifdef GRUB_MACHINE_EFI static grub_efi_uintn_t efi_mmap_size; #else @@ -183,8 +181,8 @@ { grub_relocator_unload (relocator); relocator =3D NULL; - real_mode_mem =3D prot_mode_mem =3D initrd_mem =3D 0; - real_mode_target =3D prot_mode_target =3D initrd_mem_target =3D 0; + prot_mode_mem =3D initrd_mem =3D 0; + prot_mode_target =3D initrd_mem_target =3D 0; } =20 /* Allocate pages for the real mode code and the protected mode code @@ -194,31 +192,13 @@ grub_size_t min_align, int relocatable, grub_uint64_t prefered_address) { - grub_size_t real_size, mmap_size; grub_err_t err; - - /* Make sure that each size is aligned to a page boundary. */ - real_size =3D GRUB_LINUX_CL_OFFSET + maximal_cmdline_size; - prot_size =3D page_align (prot_size); - mmap_size =3D find_mmap_size (); - -#ifdef GRUB_MACHINE_EFI - efi_mmap_size =3D find_efi_mmap_size (); - if (efi_mmap_size =3D=3D 0) - return grub_errno; -#endif - - grub_dprintf ("linux", "real_size =3D %x, prot_size =3D %x, mmap_size = =3D %x\n", - (unsigned) real_size, (unsigned) prot_size, (unsigned) mmap_size); - - /* Calculate the number of pages; Combine the real mode code with - the memory map buffer for simplicity. */ - real_mode_pages =3D ((real_size + mmap_size + efi_mmap_size) >> 12); prot_mode_pages =3D (prot_size >> 12); =20 /* Initialize the memory pointers with NULL for convenience. */ free_pages (); =20 + prot_size =3D page_align (prot_size); relocator =3D grub_relocator_new (); if (!relocator) { @@ -229,59 +209,6 @@ /* FIXME: Should request low memory from the heap when this feature is= implemented. */ =20 - auto int NESTED_FUNC_ATTR hook (grub_uint64_t, grub_uint64_t, - grub_memory_type_t); - int NESTED_FUNC_ATTR hook (grub_uint64_t addr, grub_uint64_t size, - grub_memory_type_t type) - { - /* We must put real mode code in the traditional space. */ - - if (type =3D=3D GRUB_MEMORY_AVAILABLE - && addr <=3D 0x90000) - { - if (addr < 0x10000) - { - size +=3D addr - 0x10000; - addr =3D 0x10000; - } - - if (addr + size > 0x90000) - size =3D 0x90000 - addr; - - if (real_size + mmap_size + efi_mmap_size > size) - return 0; - - real_mode_target =3D ((addr + size) - (real_size + mmap_size + efi_mm= ap_size)); - return 1; - } - - return 0; - } -#ifdef GRUB_MACHINE_EFI - grub_efi_mmap_iterate (hook, 1); - if (! real_mode_target) - grub_efi_mmap_iterate (hook, 0); -#else - grub_mmap_iterate (hook); -#endif - if (! real_mode_target) - { - err =3D grub_error (GRUB_ERR_OUT_OF_MEMORY, "cannot allocate real = mode pages"); - goto fail; - } - - { - grub_relocator_chunk_t ch; - err =3D grub_relocator_alloc_chunk_addr (relocator, &ch, - real_mode_target, - (real_size + mmap_size=20 - + efi_mmap_size)); - if (err) - goto fail; - real_mode_mem =3D get_virtual_current_address (ch); - } - efi_mmap_buf =3D (grub_uint8_t *) real_mode_mem + real_size + mmap_siz= e; - { grub_relocator_chunk_t ch; if (relocatable) @@ -315,9 +242,6 @@ prot_mode_target =3D get_physical_target_address (ch); } =20 - grub_dprintf ("linux", "real_mode_mem =3D %lx, real_mode_target =3D %l= x, real_mode_pages =3D %x\n", - (unsigned long) real_mode_mem, (unsigned long) real_mode= _target, - (unsigned) real_mode_pages); grub_dprintf ("linux", "prot_mode_mem =3D %lx, prot_mode_target =3D %l= x, prot_mode_pages =3D %x\n", (unsigned long) prot_mode_mem, (unsigned long) prot_mode= _target, (unsigned) prot_mode_pages); @@ -335,12 +259,6 @@ { int n =3D *e820_num; =20 - if (n >=3D GRUB_E820_MAX_ENTRY) - { - return grub_error (GRUB_ERR_OUT_OF_RANGE, - "Too many e820 memory map entries"); - } - if ((n > 0) && (e820_map[n - 1].addr + e820_map[n - 1].size =3D=3D sta= rt) && (e820_map[n - 1].type =3D=3D type)) e820_map[n - 1].size +=3D size; @@ -462,9 +380,89 @@ const char *modevar; char *tmp; struct grub_relocator32_state state; + void *real_mode_mem; + grub_addr_t real_mode_target; + grub_size_t real_size, mmap_size; + grub_size_t cl_offset; + + mmap_size =3D find_mmap_size (); + /* Make sure that each size is aligned to a page boundary. */ + cl_offset =3D ALIGN_UP (mmap_size + sizeof (*params), 4096); + real_size =3D cl_offset + maximal_cmdline_size; + +#ifdef GRUB_MACHINE_EFI + efi_mmap_size =3D find_efi_mmap_size (); + if (efi_mmap_size =3D=3D 0) + return grub_errno; +#endif + + grub_dprintf ("linux", "real_size =3D %x, mmap_size =3D %x\n", + (unsigned) real_size, (unsigned) mmap_size); + + /* Calculate the number of pages; Combine the real mode code with + the memory map buffer for simplicity. */ + real_mode_pages =3D ((real_size + efi_mmap_size) >> 12); + + auto int NESTED_FUNC_ATTR hook (grub_uint64_t, grub_uint64_t, + grub_memory_type_t); + int NESTED_FUNC_ATTR hook (grub_uint64_t addr, grub_uint64_t size, + grub_memory_type_t type) + { + /* We must put real mode code in the traditional space. */ + + if (type =3D=3D GRUB_MEMORY_AVAILABLE + && addr <=3D 0x90000) + { + if (addr < 0x10000) + { + size +=3D addr - 0x10000; + addr =3D 0x10000; + } + + if (addr + size > 0x90000) + size =3D 0x90000 - addr; + + if (real_size + efi_mmap_size > size) + return 0; + + real_mode_target =3D ((addr + size) - (real_size + efi_mmap_size)); + return 1; + } + + return 0; + } +#ifdef GRUB_MACHINE_EFI + grub_efi_mmap_iterate (hook, 1); + if (! real_mode_target) + grub_efi_mmap_iterate (hook, 0); +#else + grub_mmap_iterate (hook); +#endif + if (! real_mode_target) + return grub_error (GRUB_ERR_OUT_OF_MEMORY, "cannot allocate real mod= e pages"); + + { + grub_relocator_chunk_t ch; + err =3D grub_relocator_alloc_chunk_addr (relocator, &ch, + real_mode_target, + (real_size + efi_mmap_size)); + if (err) + return err; + real_mode_mem =3D get_virtual_current_address (ch); + } + efi_mmap_buf =3D (grub_uint8_t *) real_mode_mem + real_size; + + grub_dprintf ("linux", "real_mode_mem =3D %lx, real_mode_target =3D %l= x, real_mode_pages =3D %x\n", + (unsigned long) real_mode_mem, (unsigned long) real_mode= _target, + (unsigned) real_mode_pages); =20 params =3D real_mode_mem; =20 + *params =3D linux_params; + params->cmd_line_ptr =3D real_mode_target + cl_offset; + grub_memcpy ((char *) params + cl_offset, linux_cmdline, + maximal_cmdline_size); + #ifdef GRUB_MACHINE_IEEE1275 { const char *bootpath; @@ -482,10 +480,10 @@ grub_dprintf ("linux", "code32_start =3D %x\n", (unsigned) params->code32_start); =20 - auto int NESTED_FUNC_ATTR hook (grub_uint64_t, grub_uint64_t, + auto int NESTED_FUNC_ATTR hook_fill (grub_uint64_t, grub_uint64_t, grub_memory_type_t); - int NESTED_FUNC_ATTR hook (grub_uint64_t addr, grub_uint64_t size,=20 - grub_memory_type_t type) + int NESTED_FUNC_ATTR hook_fill (grub_uint64_t addr, grub_uint64_t size= ,=20 + grub_memory_type_t type) { grub_uint32_t e820_type; switch (type) @@ -517,7 +515,7 @@ } =20 e820_num =3D 0; - if (grub_mmap_iterate (hook)) + if (grub_mmap_iterate (hook_fill)) return grub_errno; params->mmap_size =3D e820_num; =20 @@ -652,6 +650,8 @@ { grub_dl_unref (my_mod); loaded =3D 0; + grub_free (linux_cmdline); + linux_cmdline =3D 0; return GRUB_ERR_NONE; } =20 @@ -781,16 +781,16 @@ preffered_address)) goto fail; =20 - params =3D (struct linux_kernel_params *) real_mode_mem; - grub_memset (params, 0, GRUB_LINUX_CL_OFFSET + maximal_cmdline_size); + params =3D (struct linux_kernel_params *) &linux_params; + grub_memset (params, 0, sizeof (*params)); grub_memcpy (¶ms->setup_sects, &lh.setup_sects, sizeof (lh) - 0x1F= 1); =20 params->code32_start =3D prot_mode_target + lh.code32_start - GRUB_LIN= UX_BZIMAGE_ADDR; params->kernel_alignment =3D (1 << align); params->ps_mouse =3D params->padding10 =3D 0; =20 - len =3D 0x400 - sizeof (lh); - if (grub_file_read (file, (char *) real_mode_mem + sizeof (lh), len) != =3D len) + len =3D sizeof (*params) - sizeof (lh); + if (grub_file_read (file, (char *) params + sizeof (lh), len) !=3D len= ) { if (!grub_errno) grub_error (GRUB_ERR_BAD_OS, N_("premature end of file %s"), @@ -805,7 +805,6 @@ params->cl_magic =3D GRUB_LINUX_CL_MAGIC; params->cl_offset =3D 0x1000; =20 - params->cmd_line_ptr =3D real_mode_target + 0x1000; params->ramdisk_image =3D 0; params->ramdisk_size =3D 0; =20 @@ -978,10 +977,12 @@ } =20 /* Create kernel command line. */ - grub_memcpy ((char *)real_mode_mem + GRUB_LINUX_CL_OFFSET, LINUX_IMAGE= , - sizeof (LINUX_IMAGE)); + linux_cmdline =3D grub_malloc (maximal_cmdline_size); + if (!linux_cmdline) + goto fail; + grub_memcpy (linux_cmdline, LINUX_IMAGE, sizeof (LINUX_IMAGE)); grub_create_loader_cmdline (argc, argv, - (char *)real_mode_mem + GRUB_LINUX_CL_OFFSET + linux_cmdline + sizeof (LINUX_IMAGE) - 1, maximal_cmdline_size - (sizeof (LINUX_IMAGE) - 1)); @@ -1054,7 +1055,7 @@ =20 initrd_pages =3D (page_align (size) >> 12); =20 - lh =3D (struct linux_kernel_header *) real_mode_mem; + lh =3D (struct linux_kernel_header *) &linux_params; =20 /* Get the highest address available for the initrd. */ if (grub_le_to_cpu16 (lh->version) >=3D 0x0203) =3D=3D=3D modified file 'include/grub/i386/linux.h' --- include/grub/i386/linux.h 2012-03-04 11:13:05 +0000 +++ include/grub/i386/linux.h 2012-05-27 14:34:29 +0000 @@ -69,8 +69,6 @@ #define GRUB_E820_NVS 4 #define GRUB_E820_BADRAM 5 =20 -#define GRUB_E820_MAX_ENTRY 128 - struct grub_e820_mmap { grub_uint64_t addr; @@ -298,7 +296,7 @@ grub_uint32_t payload_length; grub_uint64_t setup_data; grub_uint8_t pad2[120]; /* 258 */ - struct grub_e820_mmap e820_map[GRUB_E820_MAX_ENTRY]; /* 2d0 */ + struct grub_e820_mmap e820_map[(0x400 - 0x2d0) / 20]; /* 2d0 */ =20 } __attribute__ ((packed)); #endif /* ! ASM_FILE */ --------------000603060800080401050000-- --------------enig4A22CE6791F5EC5B7B85D35A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk/CP5wACgkQNak7dOguQgl2uAD/d8UwH/mGpvRQ4ngJRO+9hezT l0BSN4pTEnMG1uOqdxgBALIfM3gh7phNWTXDXZHD3/ERRn11/ANbQkKn8QNb/iyx =ZbUd -----END PGP SIGNATURE----- --------------enig4A22CE6791F5EC5B7B85D35A-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SjyOv-0005yi-6O for mharc-grub-devel@gnu.org; Wed, 27 Jun 2012 15:59:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjyOs-0005ty-E3 for grub-devel@gnu.org; Wed, 27 Jun 2012 15:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjyOq-0000KM-HL for grub-devel@gnu.org; Wed, 27 Jun 2012 15:59:41 -0400 Received: from ausxipps301.us.dell.com ([143.166.148.223]:58511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjyOm-0000B7-AM; Wed, 27 Jun 2012 15:59:36 -0400 X-Loopcount0: from 10.175.216.249 From: To: Date: Wed, 27 Jun 2012 14:59:29 -0500 Subject: RE: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Topic: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Index: Ac1I1LPkSiv+F6tbSaGsVZT63mDGBwACV+0QAu/Ou0A= Message-ID: <959D45574D89AF41A9DADF6F446A2E9A2AEC020701@AUSX7MCPS310.AMER.DELL.COM> References: <20120523-193311.sv88235.49420@savannah.gnu.org> <20120531-112908.sv72589.64321@savannah.gnu.org> <959D45574D89AF41A9DADF6F446A2E9A2AE507A772@AUSX7MCPS310.AMER.DELL.COM> <959D45574D89AF41A9DADF6F446A2E9A2AE55A707B@AUSX7MCPS310.AMER.DELL.COM> <4FD1180B.8090709@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE5668374@AUSX7MCPS310.AMER.DELL.COM> <4FD646FE.4050301@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE56AEA8E@AUSX7MCPS310.AMER.DELL.COM> <4FD79D9E.6010702@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 143.166.148.223 Cc: bug-grub@gnu.org, grub-devel@gnu.org, Jared_Dominguez@DELL.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2012 19:59:43 -0000 PiANCj4gV2VsbCwgdGhpcyB3b3JrcywgdG9vIChvbiB0b3Agb2YgSEVBRCBmcm9tIDcganVuZSku DQo+IA0KPiANCj4gLS0tIC4uLy4uL2dydWIvZ3J1Yi1jb3JlL2xvYWRlci9pMzg2L2xpbnV4LmMJ MjAxMi0wNS0zMQ0KPiAxMjo1OToxOS4wMDAwMDAwMDAgLTA0MDANCj4gKysrIGdydWItY29yZS9s b2FkZXIvaTM4Ni9saW51eC5jCTIwMTItMDYtMTIgMjA6NDc6NTEuNDU1NzE4MDU1IC0wNDAwDQo+ IEBAIC0xMzksNyArMTM5LDcgQEAgZmluZF9lZmlfbW1hcF9zaXplICh2b2lkKQ0KPiANCj4gICAg LyogSW5jcmVhc2UgdGhlIHNpemUgYSBiaXQgZm9yIHNhZmV0eSwgYmVjYXVzZSBHUlVCIGFsbG9j YXRlcyBtb3JlDQo+IG9uDQo+ICAgICAgIGxhdGVyLCBhbmQgRUZJIGl0c2VsZiBtYXkgYWxsb2Nh dGUgbW9yZS4gICovDQo+IC0gIG1tYXBfc2l6ZSArPSAoMSA8PCAxMik7DQo+ICsgIG1tYXBfc2l6 ZSArPSAoMyA8PCAxMik7DQo+IA0KPiAgICBtbWFwX3NpemUgPSBwYWdlX2FsaWduIChtbWFwX3Np emUpOw0KPiAgICByZXR1cm4gbW1hcF9zaXplOw0KDQpWbGFkaW1pciwNCg0KVGhlIDIuMDByYzEg dmVyc2lvbiBvZiBncnViMiBzdGlsbCBkb2Vzbid0IGZpeCB0aGUgZWZpIG1lbW9yeSBtYXAgYnVm ZmVyIHNpemUgSSd2ZSBiZWVuIHdvcmtpbmcgb24gKHRob3VnaCBJIGNhbiBzZWUgeW91IGFyZSBu b3cgYWxsb2NhdGluZyB0aGUgZWZpIG1lbW9yeSBtYXAgYnVmZmVyIHZlcnkgc2hvcnRseSBiZWZv cmUgeW91IGFyZSBjYWxsaW5nIGdydWJfZWZpX2ZpbmlzaF9ib290X3NlcnZpY2VzKCkpLg0KDQpJ bmNyZWFzaW5nIHRoZSBtbWFwX3NpemUgaW4gZmluZF9lZmlfbW1hcF9zaXplKCktLWFzIGluIHRo ZSBwYXRjaCBpbW1lZGlhdGVseSBhYm92ZSB0aGlzIHRleHQtLWRvZXMgZml4IHRoZSBwcm9ibGVt LiAgRXZlbiBhZGRpbmcgKDIgPDwgMTIpIChpbnN0ZWFkIG9mICgxIDw8IDEyKSkgdG8gdGhlIG1t YXBfc2l6ZSB3aWxsIHdvcmsgb24gdGhlIHN5c3RlbSBJJ20gdGVzdGluZyB3aXRoLg0KDQpBcyBp cywgdGhvdWdoLCAyLjAwcmMxIGZhaWxzIHRvIGJvb3QsIHdpdGggdGhlIGVycm9yIG1lc3NhZ2Ug Im1lbW9yeSBtYXAgYnVmZmVyIGlzIHRvbyBzbWFsbCIuDQoNClRoYW5rcywNClN0dWFydA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SjzCO-0003fs-9M for mharc-grub-devel@gnu.org; Wed, 27 Jun 2012 16:50:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjzCL-0003bJ-Hl for grub-devel@gnu.org; Wed, 27 Jun 2012 16:50:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjzCJ-0000vg-NK for grub-devel@gnu.org; Wed, 27 Jun 2012 16:50:49 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:33285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjzCG-0000pX-3F; Wed, 27 Jun 2012 16:50:44 -0400 Received: by wgbds1 with SMTP id ds1so1050624wgb.30 for ; Wed, 27 Jun 2012 13:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; bh=lvO8Ri+pYiGTFkMDBrYEkfeKmK8Zuz6BrUJVCEuUghY=; b=g+E1kSSQ8I+MfpoQKdWZO4LVYnV6cGwilrl2ZRaSWuwvbrPqr44gJtRICbAFXFnnMh 81Qpz1d5fqC+hTwgAh5+sewgkx6w8YvJlOQmXaZZAFWbXUIxJDU2WUw7b1jFVXKLSssN cV9WZuFLu4CuD4nqffOAipj2R1q9FUNDdgizEwIQrN0NwCrAgJUgaDIfseXUIi79j1XW DksJd9ulFJ9n9Cs81XCYW2yZR2SpZ0EwZR2jqhwUmW00mVg2l43+TBaS4a1Z6o9+MSkQ jbxhROOZYoKMrBdzZdp51gmhgy0PhVqc8LmCcT0leFbuHp2e/qekVH//bffSIPngzbiP 7OFg== Received: by 10.180.87.35 with SMTP id u3mr7674185wiz.2.1340830240818; Wed, 27 Jun 2012 13:50:40 -0700 (PDT) Received: from debian.x201.phnet (37-39.78-83.cust.bluewin.ch. [83.78.39.37]) by mx.google.com with ESMTPS id t8sm12384948wiy.3.2012.06.27.13.50.39 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Jun 2012 13:50:40 -0700 (PDT) Message-ID: <4FEB721E.3080908@gmail.com> Date: Wed, 27 Jun 2012 22:50:38 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120624 Icedove/10.0.5 MIME-Version: 1.0 To: Stuart_Hayes@Dell.com Subject: Re: [bug #36532] boot in EFI mode (x86_64) fails on some systems References: <20120523-193311.sv88235.49420@savannah.gnu.org> <20120531-112908.sv72589.64321@savannah.gnu.org> <959D45574D89AF41A9DADF6F446A2E9A2AE507A772@AUSX7MCPS310.AMER.DELL.COM> <959D45574D89AF41A9DADF6F446A2E9A2AE55A707B@AUSX7MCPS310.AMER.DELL.COM> <4FD1180B.8090709@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE5668374@AUSX7MCPS310.AMER.DELL.COM> <4FD646FE.4050301@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE56AEA8E@AUSX7MCPS310.AMER.DELL.COM> <4FD79D9E.6010702@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AEC020701@AUSX7MCPS310.AMER.DELL.COM> In-Reply-To: <959D45574D89AF41A9DADF6F446A2E9A2AEC020701@AUSX7MCPS310.AMER.DELL.COM> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigD03847785999472F865730B6" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.49 Cc: bug-grub@gnu.org, grub-devel@gnu.org, Jared_Dominguez@DELL.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2012 20:50:51 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD03847785999472F865730B6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 27.06.2012 21:59, Stuart_Hayes@Dell.com wrote: >> >> Well, this works, too (on top of HEAD from 7 june). >> >> >> --- ../../grub/grub-core/loader/i386/linux.c 2012-05-31 >> 12:59:19.000000000 -0400 >> +++ grub-core/loader/i386/linux.c 2012-06-12 20:47:51.455718055 -0400 >> @@ -139,7 +139,7 @@ find_efi_mmap_size (void) >> >> /* Increase the size a bit for safety, because GRUB allocates more >> on >> later, and EFI itself may allocate more. */ >> - mmap_size +=3D (1 << 12); >> + mmap_size +=3D (3 << 12); >> >> mmap_size =3D page_align (mmap_size); >> return mmap_size; >=20 > Vladimir, >=20 > The 2.00rc1 version of grub2 still doesn't fix the efi memory map buffe= r size I've been working on (though I can see you are now allocating the = efi memory map buffer very shortly before you are calling grub_efi_finish= _boot_services()). >=20 > Increasing the mmap_size in find_efi_mmap_size()--as in the patch immed= iately above this text--does fix the problem. Even adding (2 << 12) (ins= tead of (1 << 12)) to the mmap_size will work on the system I'm testing w= ith. >=20 I've changed it to 3. Thanks. It's annoying that even such simple operations as we have between find_efi_mmap and finish drastically increase memory map size. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigD03847785999472F865730B6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk/rch4ACgkQNak7dOguQgmmQAD9Fq74YF6nE2fZ78Gw60ifTM5s hsx3dVHVcvhPmAX2dRgBAKAp/QaekrBf8QE6V2UBDqKjV6Gv6GLmZMD9DYcPoJbw =VqIu -----END PGP SIGNATURE----- --------------enigD03847785999472F865730B6-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SjzKR-0005fD-7J for mharc-grub-devel@gnu.org; Wed, 27 Jun 2012 16:59:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjzKO-0005da-9f for grub-devel@gnu.org; Wed, 27 Jun 2012 16:59:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjzKM-0004w4-IT for grub-devel@gnu.org; Wed, 27 Jun 2012 16:59:07 -0400 Received: from ausc60pc101.us.dell.com ([143.166.85.206]:4637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjzKM-0004v8-DN; Wed, 27 Jun 2012 16:59:06 -0400 X-Loopcount0: from 10.175.216.250 From: To: Date: Wed, 27 Jun 2012 15:58:51 -0500 Subject: RE: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Topic: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Index: Ac1Upn8Dr/cunmb6Rz6nVsWYFZTrKwAABifw Message-ID: <959D45574D89AF41A9DADF6F446A2E9A2AEC02084A@AUSX7MCPS310.AMER.DELL.COM> References: <20120523-193311.sv88235.49420@savannah.gnu.org> <20120531-112908.sv72589.64321@savannah.gnu.org> <959D45574D89AF41A9DADF6F446A2E9A2AE507A772@AUSX7MCPS310.AMER.DELL.COM> <959D45574D89AF41A9DADF6F446A2E9A2AE55A707B@AUSX7MCPS310.AMER.DELL.COM> <4FD1180B.8090709@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE5668374@AUSX7MCPS310.AMER.DELL.COM> <4FD646FE.4050301@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE56AEA8E@AUSX7MCPS310.AMER.DELL.COM> <4FD79D9E.6010702@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AEC020701@AUSX7MCPS310.AMER.DELL.COM> <4FEB721E.3080908@gmail.com> In-Reply-To: <4FEB721E.3080908@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 143.166.85.206 Cc: bug-grub@gnu.org, Jared_Dominguez@DELL.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2012 20:59:09 -0000 DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogZ3J1Yi1kZXZlbC1ib3Vu Y2VzK3N0dWFydF9oYXllcz1kZWxsLmNvbUBnbnUub3JnIFttYWlsdG86Z3J1Yi0NCj4gZGV2ZWwt Ym91bmNlcytzdHVhcnRfaGF5ZXM9ZGVsbC5jb21AZ251Lm9yZ10gT24gQmVoYWxmIE9mIFZsYWRp bWlyICdmLQ0KPiBjb2Rlci9waGNvZGVyJyBTZXJiaW5lbmtvDQo+IFNlbnQ6IFdlZG5lc2RheSwg SnVuZSAyNywgMjAxMiAzOjUxIFBNDQo+IFRvOiBIYXllcywgU3R1YXJ0DQo+IENjOiBidWctZ3J1 YkBnbnUub3JnOyBncnViLWRldmVsQGdudS5vcmc7IERvbWluZ3VleiwgSmFyZWQNCj4gU3ViamVj dDogUmU6IFtidWcgIzM2NTMyXSBib290IGluIEVGSSBtb2RlICh4ODZfNjQpIGZhaWxzIG9uIHNv bWUNCj4gc3lzdGVtcw0KPiANCj4gT24gMjcuMDYuMjAxMiAyMTo1OSwgU3R1YXJ0X0hheWVzQERl bGwuY29tIHdyb3RlOg0KPiANCj4gPj4NCj4gPj4gV2VsbCwgdGhpcyB3b3JrcywgdG9vIChvbiB0 b3Agb2YgSEVBRCBmcm9tIDcganVuZSkuDQo+ID4+DQo+ID4+DQo+ID4+IC0tLSAuLi8uLi9ncnVi L2dydWItY29yZS9sb2FkZXIvaTM4Ni9saW51eC5jCTIwMTItMDUtMzENCj4gPj4gMTI6NTk6MTku MDAwMDAwMDAwIC0wNDAwDQo+ID4+ICsrKyBncnViLWNvcmUvbG9hZGVyL2kzODYvbGludXguYwky MDEyLTA2LTEyIDIwOjQ3OjUxLjQ1NTcxODA1NQ0KPiAtMDQwMA0KPiA+PiBAQCAtMTM5LDcgKzEz OSw3IEBAIGZpbmRfZWZpX21tYXBfc2l6ZSAodm9pZCkNCj4gPj4NCj4gPj4gICAgLyogSW5jcmVh c2UgdGhlIHNpemUgYSBiaXQgZm9yIHNhZmV0eSwgYmVjYXVzZSBHUlVCIGFsbG9jYXRlcw0KPiBt b3JlDQo+ID4+IG9uDQo+ID4+ICAgICAgIGxhdGVyLCBhbmQgRUZJIGl0c2VsZiBtYXkgYWxsb2Nh dGUgbW9yZS4gICovDQo+ID4+IC0gIG1tYXBfc2l6ZSArPSAoMSA8PCAxMik7DQo+ID4+ICsgIG1t YXBfc2l6ZSArPSAoMyA8PCAxMik7DQo+ID4+DQo+ID4+ICAgIG1tYXBfc2l6ZSA9IHBhZ2VfYWxp Z24gKG1tYXBfc2l6ZSk7DQo+ID4+ICAgIHJldHVybiBtbWFwX3NpemU7DQo+ID4NCj4gPiBWbGFk aW1pciwNCj4gPg0KPiA+IFRoZSAyLjAwcmMxIHZlcnNpb24gb2YgZ3J1YjIgc3RpbGwgZG9lc24n dCBmaXggdGhlIGVmaSBtZW1vcnkgbWFwDQo+IGJ1ZmZlciBzaXplIEkndmUgYmVlbiB3b3JraW5n IG9uICh0aG91Z2ggSSBjYW4gc2VlIHlvdSBhcmUgbm93DQo+IGFsbG9jYXRpbmcgdGhlIGVmaSBt ZW1vcnkgbWFwIGJ1ZmZlciB2ZXJ5IHNob3J0bHkgYmVmb3JlIHlvdSBhcmUNCj4gY2FsbGluZyBn cnViX2VmaV9maW5pc2hfYm9vdF9zZXJ2aWNlcygpKS4NCj4gPg0KPiA+IEluY3JlYXNpbmcgdGhl IG1tYXBfc2l6ZSBpbiBmaW5kX2VmaV9tbWFwX3NpemUoKS0tYXMgaW4gdGhlIHBhdGNoDQo+IGlt bWVkaWF0ZWx5IGFib3ZlIHRoaXMgdGV4dC0tZG9lcyBmaXggdGhlIHByb2JsZW0uICBFdmVuIGFk ZGluZyAoMiA8PA0KPiAxMikgKGluc3RlYWQgb2YgKDEgPDwgMTIpKSB0byB0aGUgbW1hcF9zaXpl IHdpbGwgd29yayBvbiB0aGUgc3lzdGVtIEknbQ0KPiB0ZXN0aW5nIHdpdGguDQo+ID4NCj4gDQo+ IEkndmUgY2hhbmdlZCBpdCB0byAzLiBUaGFua3MuIEl0J3MgYW5ub3lpbmcgdGhhdCBldmVuIHN1 Y2ggc2ltcGxlDQo+IG9wZXJhdGlvbnMgYXMgd2UgaGF2ZSBiZXR3ZWVuIGZpbmRfZWZpX21tYXAg YW5kIGZpbmlzaCBkcmFzdGljYWxseQ0KPiBpbmNyZWFzZSBtZW1vcnkgbWFwIHNpemUuDQo+IA0K PiAtLQ0KPiBSZWdhcmRzDQo+IFZsYWRpbWlyICfPhi1jb2Rlci9waGNvZGVyJyBTZXJiaW5lbmtv DQoNClRoYW5rcyEgIEkgY29tcGxldGVseSBhZ3JlZSB0aGF0IGl0IGlzIGFubm95aW5nLg0KDQoN Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SkMRG-0004Yu-Vk for mharc-grub-devel@gnu.org; Thu, 28 Jun 2012 17:39:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkMRD-0004XQ-V8 for grub-devel@gnu.org; Thu, 28 Jun 2012 17:39:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SkMRC-0005bl-8U for grub-devel@gnu.org; Thu, 28 Jun 2012 17:39:43 -0400 Received: from ausxipps301.us.dell.com ([143.166.148.223]:19321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkMRC-0005ak-2y; Thu, 28 Jun 2012 17:39:42 -0400 X-Loopcount0: from 10.175.216.250 From: To: Date: Thu, 28 Jun 2012 16:39:35 -0500 Subject: RE: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Topic: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Index: Ac1Upn8Dr/cunmb6Rz6nVsWYFZTrKwAABifwADOwT1A= Message-ID: <959D45574D89AF41A9DADF6F446A2E9A2AEC085488@AUSX7MCPS310.AMER.DELL.COM> References: <20120523-193311.sv88235.49420@savannah.gnu.org> <20120531-112908.sv72589.64321@savannah.gnu.org> <959D45574D89AF41A9DADF6F446A2E9A2AE507A772@AUSX7MCPS310.AMER.DELL.COM> <959D45574D89AF41A9DADF6F446A2E9A2AE55A707B@AUSX7MCPS310.AMER.DELL.COM> <4FD1180B.8090709@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE5668374@AUSX7MCPS310.AMER.DELL.COM> <4FD646FE.4050301@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE56AEA8E@AUSX7MCPS310.AMER.DELL.COM> <4FD79D9E.6010702@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AEC020701@AUSX7MCPS310.AMER.DELL.COM> <4FEB721E.3080908@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 143.166.148.223 Cc: bug-grub@gnu.org, Jared_Dominguez@DELL.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2012 21:39:45 -0000 PiA+ID4NCj4gPiA+IFZsYWRpbWlyLA0KPiA+ID4NCj4gPiA+IFRoZSAyLjAwcmMxIHZlcnNpb24g b2YgZ3J1YjIgc3RpbGwgZG9lc24ndCBmaXggdGhlIGVmaSBtZW1vcnkgbWFwDQo+ID4gYnVmZmVy IHNpemUgSSd2ZSBiZWVuIHdvcmtpbmcgb24gKHRob3VnaCBJIGNhbiBzZWUgeW91IGFyZSBub3cN Cj4gPiBhbGxvY2F0aW5nIHRoZSBlZmkgbWVtb3J5IG1hcCBidWZmZXIgdmVyeSBzaG9ydGx5IGJl Zm9yZSB5b3UgYXJlDQo+ID4gY2FsbGluZyBncnViX2VmaV9maW5pc2hfYm9vdF9zZXJ2aWNlcygp KS4NCj4gPiA+DQo+ID4gPiBJbmNyZWFzaW5nIHRoZSBtbWFwX3NpemUgaW4gZmluZF9lZmlfbW1h cF9zaXplKCktLWFzIGluIHRoZSBwYXRjaA0KPiA+IGltbWVkaWF0ZWx5IGFib3ZlIHRoaXMgdGV4 dC0tZG9lcyBmaXggdGhlIHByb2JsZW0uICBFdmVuIGFkZGluZyAoMiA8PA0KPiA+IDEyKSAoaW5z dGVhZCBvZiAoMSA8PCAxMikpIHRvIHRoZSBtbWFwX3NpemUgd2lsbCB3b3JrIG9uIHRoZSBzeXN0 ZW0NCj4gSSdtDQo+ID4gdGVzdGluZyB3aXRoLg0KPiA+ID4NCj4gPg0KPiA+IEkndmUgY2hhbmdl ZCBpdCB0byAzLiBUaGFua3MuIEl0J3MgYW5ub3lpbmcgdGhhdCBldmVuIHN1Y2ggc2ltcGxlDQo+ ID4gb3BlcmF0aW9ucyBhcyB3ZSBoYXZlIGJldHdlZW4gZmluZF9lZmlfbW1hcCBhbmQgZmluaXNo IGRyYXN0aWNhbGx5DQo+ID4gaW5jcmVhc2UgbWVtb3J5IG1hcCBzaXplLg0KPiA+DQo+ID4gLS0N Cj4gPiBSZWdhcmRzDQo+ID4gVmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28N Cj4gDQo+IFRoYW5rcyEgIEkgY29tcGxldGVseSBhZ3JlZSB0aGF0IGl0IGlzIGFubm95aW5nLg0K PiANCg0KRllJLCB3aGlsZSBncnViLTIuMDAgd29ya3Mgb24gbXkgc3lzdGVtIG5vdywgc29tZW9u ZSBlbHNlIGhlcmUgYXQgRGVsbCBoYXMgdGVzdGVkIGl0IGFuZCBmb3VuZCB0aGF0IGl0IHN0aWxs IGRvZXNuJ3Qgd29yay4gIChJIHZlcmlmaWVkIHRoYXQgdGhleSB3ZXJlIGluZGVlZCB1c2luZyB2 ZXJzaW9uIDIuMDAsIGFuZCBzYXcgdGhlIGVycm9yIG15c2VsZikuDQoNCkkgaGF2ZSBubyBpZGVh IGhvdyBvciB3aHkgdGhlIG1lbW9yeSBtYXAgc2l6ZSBpcyBncm93aW5nIHRoYXQgbXVjaC4gIEFz IEkgZ2V0IHRpbWUsIEknbGwgdHJ5IHRvIGZpZ3VyZSB0aGF0IG91dC4uLg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Ski7r-0001oO-MO for mharc-grub-devel@gnu.org; Fri, 29 Jun 2012 16:49:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ski7p-0001nX-70 for grub-devel@gnu.org; Fri, 29 Jun 2012 16:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ski7n-0007qk-Bw for grub-devel@gnu.org; Fri, 29 Jun 2012 16:49:08 -0400 Received: from ausxipps301.us.dell.com ([143.166.148.223]:31377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ski7n-0007qJ-6b; Fri, 29 Jun 2012 16:49:07 -0400 X-Loopcount0: from 10.170.28.41 From: To: Date: Fri, 29 Jun 2012 15:49:01 -0500 Subject: RE: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Topic: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Index: Ac1Upn8Dr/cunmb6Rz6nVsWYFZTrKwAABifwADOwT1AAMF4BQA== Message-ID: <959D45574D89AF41A9DADF6F446A2E9A2AEC0F46AF@AUSX7MCPS310.AMER.DELL.COM> References: <20120523-193311.sv88235.49420@savannah.gnu.org> <20120531-112908.sv72589.64321@savannah.gnu.org> <959D45574D89AF41A9DADF6F446A2E9A2AE507A772@AUSX7MCPS310.AMER.DELL.COM> <959D45574D89AF41A9DADF6F446A2E9A2AE55A707B@AUSX7MCPS310.AMER.DELL.COM> <4FD1180B.8090709@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE5668374@AUSX7MCPS310.AMER.DELL.COM> <4FD646FE.4050301@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE56AEA8E@AUSX7MCPS310.AMER.DELL.COM> <4FD79D9E.6010702@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AEC020701@AUSX7MCPS310.AMER.DELL.COM> <4FEB721E.3080908@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 143.166.148.223 Cc: bug-grub@gnu.org, Jared_Dominguez@DELL.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2012 20:49:10 -0000 PiA+ID4gPiBWbGFkaW1pciwNCj4gPiA+ID4NCj4gPiA+ID4gVGhlIDIuMDByYzEgdmVyc2lvbiBv ZiBncnViMiBzdGlsbCBkb2Vzbid0IGZpeCB0aGUgZWZpIG1lbW9yeSBtYXANCj4gPiA+IGJ1ZmZl ciBzaXplIEkndmUgYmVlbiB3b3JraW5nIG9uICh0aG91Z2ggSSBjYW4gc2VlIHlvdSBhcmUgbm93 DQo+ID4gPiBhbGxvY2F0aW5nIHRoZSBlZmkgbWVtb3J5IG1hcCBidWZmZXIgdmVyeSBzaG9ydGx5 IGJlZm9yZSB5b3UgYXJlDQo+ID4gPiBjYWxsaW5nIGdydWJfZWZpX2ZpbmlzaF9ib290X3NlcnZp Y2VzKCkpLg0KPiA+ID4gPg0KPiA+ID4gPiBJbmNyZWFzaW5nIHRoZSBtbWFwX3NpemUgaW4gZmlu ZF9lZmlfbW1hcF9zaXplKCktLWFzIGluIHRoZSBwYXRjaA0KPiA+ID4gaW1tZWRpYXRlbHkgYWJv dmUgdGhpcyB0ZXh0LS1kb2VzIGZpeCB0aGUgcHJvYmxlbS4gIEV2ZW4gYWRkaW5nICgyDQo+IDw8 DQo+ID4gPiAxMikgKGluc3RlYWQgb2YgKDEgPDwgMTIpKSB0byB0aGUgbW1hcF9zaXplIHdpbGwg d29yayBvbiB0aGUgc3lzdGVtDQo+ID4gSSdtDQo+ID4gPiB0ZXN0aW5nIHdpdGguDQo+ID4gPiA+ DQo+ID4gPg0KPiA+ID4gSSd2ZSBjaGFuZ2VkIGl0IHRvIDMuIFRoYW5rcy4gSXQncyBhbm5veWlu ZyB0aGF0IGV2ZW4gc3VjaCBzaW1wbGUNCj4gPiA+IG9wZXJhdGlvbnMgYXMgd2UgaGF2ZSBiZXR3 ZWVuIGZpbmRfZWZpX21tYXAgYW5kIGZpbmlzaCBkcmFzdGljYWxseQ0KPiA+ID4gaW5jcmVhc2Ug bWVtb3J5IG1hcCBzaXplLg0KPiA+ID4NCj4gPiA+IC0tDQo+ID4gPiBSZWdhcmRzDQo+ID4gPiBW bGFkaW1pciAnz4YtY29kZXIvcGhjb2RlcicgU2VyYmluZW5rbw0KPiA+DQo+ID4gVGhhbmtzISAg SSBjb21wbGV0ZWx5IGFncmVlIHRoYXQgaXQgaXMgYW5ub3lpbmcuDQo+ID4NCj4gDQo+IEZZSSwg d2hpbGUgZ3J1Yi0yLjAwIHdvcmtzIG9uIG15IHN5c3RlbSBub3csIHNvbWVvbmUgZWxzZSBoZXJl IGF0IERlbGwNCj4gaGFzIHRlc3RlZCBpdCBhbmQgZm91bmQgdGhhdCBpdCBzdGlsbCBkb2Vzbid0 IHdvcmsuICAoSSB2ZXJpZmllZCB0aGF0DQo+IHRoZXkgd2VyZSBpbmRlZWQgdXNpbmcgdmVyc2lv biAyLjAwLCBhbmQgc2F3IHRoZSBlcnJvciBteXNlbGYpLg0KPiANCj4gSSBoYXZlIG5vIGlkZWEg aG93IG9yIHdoeSB0aGUgbWVtb3J5IG1hcCBzaXplIGlzIGdyb3dpbmcgdGhhdCBtdWNoLiAgQXMN Cj4gSSBnZXQgdGltZSwgSSdsbCB0cnkgdG8gZmlndXJlIHRoYXQgb3V0Li4uDQoNCkZZSSBhZ2Fp bjoNCg0KSSd2ZSBmb3VuZCB0aGUgcHJvYmxlbS4gIFRoZSBtZW1vcnkgbWFwIGlzIG5vdCBncm93 aW5nIHdpbGRseS4uLiBpdCBpcyBtb3JlIG9mIGEgZmlybXdhcmUgInF1aXJrLiIgIFRoZSBmaXJt d2FyZSBpcyB0aGlua2luZyBpdCBuZWVkcyBhIGxhcmdlciBidWZmZXIgdGhhbiBpdCBhY3R1YWxs eSBuZWVkcy4gIFNvIGNhbGxzIHRvIEdldE1lbW9yeU1hcCB3aXRoIGEgYnVmZmVyIHRoYXQgaXMg c21hbGxlciB0aGFuIChzYXkpIDUyMzY4IGJ5dGVzIHdpbGwgcmV0dXJuIEVGSV9CVUZGRVJfVE9P X1NNQUxMIGFuZCBzYXkgdGhhdCB0aGUgYnVmZmVyIG5lZWRzIHRvIGJlIDUyMzY4IGJ5dGVzLCBi dXQgdGhlbiB3aGVuIHlvdSBjYWxsIGl0IHdpdGggYSBidWZmZXIgdGhhdCdzIDUyMzY4IGJ5dGVz LCBpdCB3aWxsIHB1dCB0aGUgbWVtb3J5IG1hcCBpbnRvIHRoZSBidWZmZXIgYW5kIHRlbGwgeW91 IHRoYXQgdGhlIG1lbW9yeSBtYXAgaXMgaW4gZmFjdCBvbmx5IChzYXkpIDI0NTc2IGJ5dGVzLg0K DQpVbmZvcnR1bmF0ZWx5LCByaWdodCBub3csIGZpbmRfZWZpX21tYXBfc2l6ZSgpIHdpbGwgdGhl biByZXR1cm4gMjQ1NzYgYnl0ZXMgKHBsdXMgMyBwYWdlcywgYWxpZ25lZCB0byBhIHBhZ2Ugc2l6 ZSksIHdoaWNoIGlzbid0IGVub3VnaCwgYnV0IG5vdCBiZWNhdXNlIHRoZSBtZW1vcnkgbWFwIHNp emUgaXMgZ3Jvd2luZy4uLg0KDQpJJ2xsIHNlbmQgaW4gYSBwYXRjaCBmb3IgZ3J1YiB0aGF0IHdp bGwgbWFrZSBpdCBpbW11bmUgdG8gdGhpcyBxdWlyay4uLiBpdCBzaG91bGQgYmUgcHJldHR5IGxv dyByaXNrIChJJ20gdGhpbmtpbmcgbW9kaWZ5IGZpbmRfZWZpX21tYXBfc2l6ZSgpIHRvIHVzZSB0 aGUgdmFsdWUgb2YgbW1hcF9zaXplIHRoYXQgd2FzIHBhc3NlZCB0byBncnViX2VmaV9nZXRfbWVt b3J5X21hcCgpLCByYXRoZXIgdGhhbiB0aGUgdmFsdWUgb2YgbW1hcF9zaXplIHRoYXQgd2FzIHJl dHVybmVkIGZyb20gdGhhdCBmdW5jdGlvbi4pICBXaXRoIHRoYXQsIEkgZG9uJ3QgYmVsaWV2ZSBp dCB3b3VsZCBldmVuIG5lZWQgdG8gYWRkIDMgcGFnZXMgdG8gdGhlIG1lbW9yeSBtYXAgc2l6ZSAo SSB3YXRjaGVkIHRoZSBtZW1vcnkgbWFwIHNpemUsIGFuZCBpdCBpcyBub3QgZ3Jvd2luZyBzaWdu aWZpY2FudGx5KS4NCg0KU3R1YXJ0DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SkiWq-0006lS-QQ for mharc-grub-devel@gnu.org; Fri, 29 Jun 2012 17:15:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkiWn-0006k1-As for grub-devel@gnu.org; Fri, 29 Jun 2012 17:14:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SkiWl-0005SA-DC for grub-devel@gnu.org; Fri, 29 Jun 2012 17:14:56 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:49875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkiWl-0005Rt-0q for grub-devel@gnu.org; Fri, 29 Jun 2012 17:14:55 -0400 Received: by wibhq4 with SMTP id hq4so1036342wib.12 for ; Fri, 29 Jun 2012 14:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=u7XUSW+D+2nw0dBwgiSNM6qMCx/QDuQImwSxWm5vpX4=; b=C5+AX5MzWcSQMltAfODBu96xnxmgTdoY3+GYlMNbJ/JKvDtkAcvrUvuPk/+zZomk8r vV/PgWprF35nMXGLNZ4/ceFq+GonSal+GkcqX8aPq3MPz4xBqPuxSp3RwYsbyo1cnjbt Do1SYL7Zy+toDUkyV2b580eCnW/m5RrZJ7aMGL8JnNET7JW9iO1C0XhMoxSigKhCGwZk 4JjF9r9Oi1W1/mM+OF6LVAV9t4Fj8hdQl+h/0MiJIxLBLmZd9sV4o/2ii/+Ntaz9cO0Q fZWDJCaKrmFatXv63rqCbV3xrRMp5qbcX+ST6thqneJO5how1aJ/qrfXA+RP+ifPipsu U1JQ== Received: by 10.180.94.4 with SMTP id cy4mr981024wib.2.1341004493050; Fri, 29 Jun 2012 14:14:53 -0700 (PDT) Received: from debian.x201.phnet (105-233.197-178.cust.bluewin.ch. [178.197.233.105]) by mx.google.com with ESMTPS id f10sm13807959wiw.1.2012.06.29.14.14.52 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 29 Jun 2012 14:14:52 -0700 (PDT) Message-ID: <4FEE1AB8.3050102@gmail.com> Date: Fri, 29 Jun 2012 23:14:32 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120624 Icedove/10.0.5 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [bug #36532] boot in EFI mode (x86_64) fails on some systems References: <20120523-193311.sv88235.49420@savannah.gnu.org> <20120531-112908.sv72589.64321@savannah.gnu.org> <959D45574D89AF41A9DADF6F446A2E9A2AE507A772@AUSX7MCPS310.AMER.DELL.COM> <959D45574D89AF41A9DADF6F446A2E9A2AE55A707B@AUSX7MCPS310.AMER.DELL.COM> <4FD1180B.8090709@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE5668374@AUSX7MCPS310.AMER.DELL.COM> <4FD646FE.4050301@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE56AEA8E@AUSX7MCPS310.AMER.DELL.COM> <4FD79D9E.6010702@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AEC020701@AUSX7MCPS310.AMER.DELL.COM> <4FEB721E.3080908@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AEC0F46AF@AUSX7MCPS310.AMER.DELL.COM> In-Reply-To: <959D45574D89AF41A9DADF6F446A2E9A2AEC0F46AF@AUSX7MCPS310.AMER.DELL.COM> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigB313998C9603EFF978490191" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.171 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2012 21:14:58 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB313998C9603EFF978490191 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 29.06.2012 22:49, Stuart_Hayes@Dell.com wrote: >>>>> Vladimir, >>>>> >>>>> The 2.00rc1 version of grub2 still doesn't fix the efi memory map >>>> buffer size I've been working on (though I can see you are now >>>> allocating the efi memory map buffer very shortly before you are >>>> calling grub_efi_finish_boot_services()). >>>>> >>>>> Increasing the mmap_size in find_efi_mmap_size()--as in the patch >>>> immediately above this text--does fix the problem. Even adding (2 >> << >>>> 12) (instead of (1 << 12)) to the mmap_size will work on the system >>> I'm >>>> testing with. >>>>> >>>> >>>> I've changed it to 3. Thanks. It's annoying that even such simple >>>> operations as we have between find_efi_mmap and finish drastically >>>> increase memory map size. >>>> >>>> -- >>>> Regards >>>> Vladimir '=CF=86-coder/phcoder' Serbinenko >>> >>> Thanks! I completely agree that it is annoying. >>> >> >> FYI, while grub-2.00 works on my system now, someone else here at Dell= >> has tested it and found that it still doesn't work. (I verified that >> they were indeed using version 2.00, and saw the error myself). >> >> I have no idea how or why the memory map size is growing that much. A= s >> I get time, I'll try to figure that out... >=20 > FYI again: >=20 > I've found the problem. The memory map is not growing wildly... it is = more of a firmware "quirk." The firmware is thinking it needs a larger b= uffer than it actually needs. So calls to GetMemoryMap with a buffer tha= t is smaller than (say) 52368 bytes will return EFI_BUFFER_TOO_SMALL and = say that the buffer needs to be 52368 bytes, but then when you call it wi= th a buffer that's 52368 bytes, it will put the memory map into the buffe= r and tell you that the memory map is in fact only (say) 24576 bytes. >=20 > Unfortunately, right now, find_efi_mmap_size() will then return 24576 b= ytes (plus 3 pages, aligned to a page size), which isn't enough, but not = because the memory map size is growing... >=20 > I'll send in a patch for grub that will make it immune to this quirk...= it should be pretty low risk (I'm thinking modify find_efi_mmap_size() t= o use the value of mmap_size that was passed to grub_efi_get_memory_map()= , rather than the value of mmap_size that was returned from that function= =2E) With that, I don't believe it would even need to add 3 pages to the= memory map size (I watched the memory map size, and it is not growing si= gnificantly). >=20 What about this: =3D=3D=3D modified file 'grub-core/loader/i386/linux.c' --- grub-core/loader/i386/linux.c 2012-06-27 20:55:09 +0000 +++ grub-core/loader/i386/linux.c 2012-06-29 21:12:53 +0000 @@ -118,12 +118,13 @@ find_efi_mmap_size (void) int ret; grub_efi_memory_descriptor_t *mmap; grub_efi_uintn_t desc_size; + grub_efi_uintn_t cur_mmap_size =3D mmap_size; =20 - mmap =3D grub_malloc (mmap_size); + mmap =3D grub_malloc (cur_mmap_size); if (! mmap) return 0; =20 - ret =3D grub_efi_get_memory_map (&mmap_size, mmap, 0, &desc_size, = 0); + ret =3D grub_efi_get_memory_map (&cur_mmap_size, mmap, 0, &desc_si= ze, 0); grub_free (mmap); =20 if (ret < 0) @@ -134,6 +135,8 @@ find_efi_mmap_size (void) else if (ret > 0) break; =20 + if (mmap_size < cur_mmap_size) + mmap_size =3D cur_mmap_size; mmap_size +=3D (1 << 12); } =20 It will take the largest size returned which should be safe. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigB313998C9603EFF978490191 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk/uGrgACgkQNak7dOguQgmUpQD9Fy1iGwbHiogUMLD5+oH7+dnW ubshtLAeYpRSmgyinSQA/293MtD7K30KdEuPimMI73cb+SO9wefmxre+9tAFAIWi =DfhR -----END PGP SIGNATURE----- --------------enigB313998C9603EFF978490191-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Slkl3-0005On-Jo for mharc-grub-devel@gnu.org; Mon, 02 Jul 2012 13:49:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slkl0-0005OS-1y for grub-devel@gnu.org; Mon, 02 Jul 2012 13:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Slkky-0004ej-8K for grub-devel@gnu.org; Mon, 02 Jul 2012 13:49:53 -0400 Received: from ausxipps301.us.dell.com ([143.166.148.223]:26833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slkky-0004e0-1H for grub-devel@gnu.org; Mon, 02 Jul 2012 13:49:52 -0400 X-Loopcount0: from 10.170.28.40 From: To: Date: Mon, 2 Jul 2012 12:49:47 -0500 Subject: RE: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Topic: [bug #36532] boot in EFI mode (x86_64) fails on some systems Thread-Index: Ac1WPCwifhf3h77SQLigHvff4DTexACPJMPA Message-ID: <959D45574D89AF41A9DADF6F446A2E9A2AEC19619B@AUSX7MCPS310.AMER.DELL.COM> References: <20120523-193311.sv88235.49420@savannah.gnu.org> <20120531-112908.sv72589.64321@savannah.gnu.org> <959D45574D89AF41A9DADF6F446A2E9A2AE507A772@AUSX7MCPS310.AMER.DELL.COM> <959D45574D89AF41A9DADF6F446A2E9A2AE55A707B@AUSX7MCPS310.AMER.DELL.COM> <4FD1180B.8090709@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE5668374@AUSX7MCPS310.AMER.DELL.COM> <4FD646FE.4050301@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AE56AEA8E@AUSX7MCPS310.AMER.DELL.COM> <4FD79D9E.6010702@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AEC020701@AUSX7MCPS310.AMER.DELL.COM> <4FEB721E.3080908@gmail.com> <959D45574D89AF41A9DADF6F446A2E9A2AEC0F46AF@AUSX7MCPS310.AMER.DELL.COM> <4FEE1AB8.3050102@gmail.com> In-Reply-To: <4FEE1AB8.3050102@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 143.166.148.223 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2012 17:49:55 -0000 PiANCj4gT24gMjkuMDYuMjAxMiAyMjo0OSwgU3R1YXJ0X0hheWVzQERlbGwuY29tIHdyb3RlOg0K PiANCj4gPj4+Pj4gVmxhZGltaXIsDQo+ID4+Pj4+DQo+ID4+Pj4+IFRoZSAyLjAwcmMxIHZlcnNp b24gb2YgZ3J1YjIgc3RpbGwgZG9lc24ndCBmaXggdGhlIGVmaSBtZW1vcnkgbWFwDQo+ID4+Pj4g YnVmZmVyIHNpemUgSSd2ZSBiZWVuIHdvcmtpbmcgb24gKHRob3VnaCBJIGNhbiBzZWUgeW91IGFy ZSBub3cNCj4gPj4+PiBhbGxvY2F0aW5nIHRoZSBlZmkgbWVtb3J5IG1hcCBidWZmZXIgdmVyeSBz aG9ydGx5IGJlZm9yZSB5b3UgYXJlDQo+ID4+Pj4gY2FsbGluZyBncnViX2VmaV9maW5pc2hfYm9v dF9zZXJ2aWNlcygpKS4NCj4gPj4+Pj4NCj4gPj4+Pj4gSW5jcmVhc2luZyB0aGUgbW1hcF9zaXpl IGluIGZpbmRfZWZpX21tYXBfc2l6ZSgpLS1hcyBpbiB0aGUgcGF0Y2gNCj4gPj4+PiBpbW1lZGlh dGVseSBhYm92ZSB0aGlzIHRleHQtLWRvZXMgZml4IHRoZSBwcm9ibGVtLiAgRXZlbiBhZGRpbmcg KDINCj4gPj4gPDwNCj4gPj4+PiAxMikgKGluc3RlYWQgb2YgKDEgPDwgMTIpKSB0byB0aGUgbW1h cF9zaXplIHdpbGwgd29yayBvbiB0aGUNCj4gc3lzdGVtDQo+ID4+PiBJJ20NCj4gPj4+PiB0ZXN0 aW5nIHdpdGguDQo+ID4+Pj4+DQo+ID4+Pj4NCj4gPj4+PiBJJ3ZlIGNoYW5nZWQgaXQgdG8gMy4g VGhhbmtzLiBJdCdzIGFubm95aW5nIHRoYXQgZXZlbiBzdWNoIHNpbXBsZQ0KPiA+Pj4+IG9wZXJh dGlvbnMgYXMgd2UgaGF2ZSBiZXR3ZWVuIGZpbmRfZWZpX21tYXAgYW5kIGZpbmlzaCBkcmFzdGlj YWxseQ0KPiA+Pj4+IGluY3JlYXNlIG1lbW9yeSBtYXAgc2l6ZS4NCj4gPj4+Pg0KPiA+Pj4+IC0t DQo+ID4+Pj4gUmVnYXJkcw0KPiA+Pj4+IFZsYWRpbWlyICfPhi1jb2Rlci9waGNvZGVyJyBTZXJi aW5lbmtvDQo+ID4+Pg0KPiA+Pj4gVGhhbmtzISAgSSBjb21wbGV0ZWx5IGFncmVlIHRoYXQgaXQg aXMgYW5ub3lpbmcuDQo+ID4+Pg0KPiA+Pg0KPiA+PiBGWUksIHdoaWxlIGdydWItMi4wMCB3b3Jr cyBvbiBteSBzeXN0ZW0gbm93LCBzb21lb25lIGVsc2UgaGVyZSBhdA0KPiA+PiBEZWxsIGhhcyB0 ZXN0ZWQgaXQgYW5kIGZvdW5kIHRoYXQgaXQgc3RpbGwgZG9lc24ndCB3b3JrLiAgKEkNCj4gdmVy aWZpZWQNCj4gPj4gdGhhdCB0aGV5IHdlcmUgaW5kZWVkIHVzaW5nIHZlcnNpb24gMi4wMCwgYW5k IHNhdyB0aGUgZXJyb3IgbXlzZWxmKS4NCj4gPj4NCj4gPj4gSSBoYXZlIG5vIGlkZWEgaG93IG9y IHdoeSB0aGUgbWVtb3J5IG1hcCBzaXplIGlzIGdyb3dpbmcgdGhhdCBtdWNoLg0KPiA+PiBBcyBJ IGdldCB0aW1lLCBJJ2xsIHRyeSB0byBmaWd1cmUgdGhhdCBvdXQuLi4NCj4gPg0KPiA+IEZZSSBh Z2FpbjoNCj4gPg0KPiA+IEkndmUgZm91bmQgdGhlIHByb2JsZW0uICBUaGUgbWVtb3J5IG1hcCBp cyBub3QgZ3Jvd2luZyB3aWxkbHkuLi4gaXQNCj4gaXMgbW9yZSBvZiBhIGZpcm13YXJlICJxdWly ay4iICBUaGUgZmlybXdhcmUgaXMgdGhpbmtpbmcgaXQgbmVlZHMgYQ0KPiBsYXJnZXIgYnVmZmVy IHRoYW4gaXQgYWN0dWFsbHkgbmVlZHMuICBTbyBjYWxscyB0byBHZXRNZW1vcnlNYXAgd2l0aCBh DQo+IGJ1ZmZlciB0aGF0IGlzIHNtYWxsZXIgdGhhbiAoc2F5KSA1MjM2OCBieXRlcyB3aWxsIHJl dHVybg0KPiBFRklfQlVGRkVSX1RPT19TTUFMTCBhbmQgc2F5IHRoYXQgdGhlIGJ1ZmZlciBuZWVk cyB0byBiZSA1MjM2OCBieXRlcywNCj4gYnV0IHRoZW4gd2hlbiB5b3UgY2FsbCBpdCB3aXRoIGEg YnVmZmVyIHRoYXQncyA1MjM2OCBieXRlcywgaXQgd2lsbCBwdXQNCj4gdGhlIG1lbW9yeSBtYXAg aW50byB0aGUgYnVmZmVyIGFuZCB0ZWxsIHlvdSB0aGF0IHRoZSBtZW1vcnkgbWFwIGlzIGluDQo+ IGZhY3Qgb25seSAoc2F5KSAyNDU3NiBieXRlcy4NCj4gPg0KPiA+IFVuZm9ydHVuYXRlbHksIHJp Z2h0IG5vdywgZmluZF9lZmlfbW1hcF9zaXplKCkgd2lsbCB0aGVuIHJldHVybiAyNDU3Ng0KPiBi eXRlcyAocGx1cyAzIHBhZ2VzLCBhbGlnbmVkIHRvIGEgcGFnZSBzaXplKSwgd2hpY2ggaXNuJ3Qg ZW5vdWdoLCBidXQNCj4gbm90IGJlY2F1c2UgdGhlIG1lbW9yeSBtYXAgc2l6ZSBpcyBncm93aW5n Li4uDQo+ID4NCj4gPiBJJ2xsIHNlbmQgaW4gYSBwYXRjaCBmb3IgZ3J1YiB0aGF0IHdpbGwgbWFr ZSBpdCBpbW11bmUgdG8gdGhpcw0KPiBxdWlyay4uLiBpdCBzaG91bGQgYmUgcHJldHR5IGxvdyBy aXNrIChJJ20gdGhpbmtpbmcgbW9kaWZ5DQo+IGZpbmRfZWZpX21tYXBfc2l6ZSgpIHRvIHVzZSB0 aGUgdmFsdWUgb2YgbW1hcF9zaXplIHRoYXQgd2FzIHBhc3NlZCB0bw0KPiBncnViX2VmaV9nZXRf bWVtb3J5X21hcCgpLCByYXRoZXIgdGhhbiB0aGUgdmFsdWUgb2YgbW1hcF9zaXplIHRoYXQgd2Fz DQo+IHJldHVybmVkIGZyb20gdGhhdCBmdW5jdGlvbi4pICBXaXRoIHRoYXQsIEkgZG9uJ3QgYmVs aWV2ZSBpdCB3b3VsZCBldmVuDQo+IG5lZWQgdG8gYWRkIDMgcGFnZXMgdG8gdGhlIG1lbW9yeSBt YXAgc2l6ZSAoSSB3YXRjaGVkIHRoZSBtZW1vcnkgbWFwDQo+IHNpemUsIGFuZCBpdCBpcyBub3Qg Z3Jvd2luZyBzaWduaWZpY2FudGx5KS4NCj4gPg0KPiANCj4gV2hhdCBhYm91dCB0aGlzOg0KPiA9 PT0gbW9kaWZpZWQgZmlsZSAnZ3J1Yi1jb3JlL2xvYWRlci9pMzg2L2xpbnV4LmMnDQo+IC0tLSBn cnViLWNvcmUvbG9hZGVyL2kzODYvbGludXguYwkyMDEyLTA2LTI3IDIwOjU1OjA5ICswMDAwDQo+ ICsrKyBncnViLWNvcmUvbG9hZGVyL2kzODYvbGludXguYwkyMDEyLTA2LTI5IDIxOjEyOjUzICsw MDAwDQo+IEBAIC0xMTgsMTIgKzExOCwxMyBAQCBmaW5kX2VmaV9tbWFwX3NpemUgKHZvaWQpDQo+ ICAgICAgICBpbnQgcmV0Ow0KPiAgICAgICAgZ3J1Yl9lZmlfbWVtb3J5X2Rlc2NyaXB0b3JfdCAq bW1hcDsNCj4gICAgICAgIGdydWJfZWZpX3VpbnRuX3QgZGVzY19zaXplOw0KPiArICAgICAgZ3J1 Yl9lZmlfdWludG5fdCBjdXJfbW1hcF9zaXplID0gbW1hcF9zaXplOw0KPiANCj4gLSAgICAgIG1t YXAgPSBncnViX21hbGxvYyAobW1hcF9zaXplKTsNCj4gKyAgICAgIG1tYXAgPSBncnViX21hbGxv YyAoY3VyX21tYXBfc2l6ZSk7DQo+ICAgICAgICBpZiAoISBtbWFwKQ0KPiAgCXJldHVybiAwOw0K PiANCj4gLSAgICAgIHJldCA9IGdydWJfZWZpX2dldF9tZW1vcnlfbWFwICgmbW1hcF9zaXplLCBt bWFwLCAwLCAmZGVzY19zaXplLA0KPiAwKTsNCj4gKyAgICAgIHJldCA9IGdydWJfZWZpX2dldF9t ZW1vcnlfbWFwICgmY3VyX21tYXBfc2l6ZSwgbW1hcCwgMCwNCj4gKyAmZGVzY19zaXplLCAwKTsN Cj4gICAgICAgIGdydWJfZnJlZSAobW1hcCk7DQo+IA0KPiAgICAgICAgaWYgKHJldCA8IDApDQo+ IEBAIC0xMzQsNiArMTM1LDggQEAgZmluZF9lZmlfbW1hcF9zaXplICh2b2lkKQ0KPiAgICAgICAg ZWxzZSBpZiAocmV0ID4gMCkNCj4gIAlicmVhazsNCj4gDQo+ICsgICAgICBpZiAobW1hcF9zaXpl IDwgY3VyX21tYXBfc2l6ZSkNCj4gKwltbWFwX3NpemUgPSBjdXJfbW1hcF9zaXplOw0KPiAgICAg ICAgbW1hcF9zaXplICs9ICgxIDw8IDEyKTsNCj4gICAgICB9DQo+IA0KPiANCj4gSXQgd2lsbCB0 YWtlIHRoZSBsYXJnZXN0IHNpemUgcmV0dXJuZWQgd2hpY2ggc2hvdWxkIGJlIHNhZmUuDQo+IA0K PiAtLQ0KPiBSZWdhcmRzDQo+IFZsYWRpbWlyICfPhi1jb2Rlci9waGNvZGVyJyBTZXJiaW5lbmtv DQoNClRoYXQgd29ya3MgZ3JlYXQuICBUZXN0ZWQgb24gYSBjb3VwbGUgc3lzdGVtcywgaW5jbHVk aW5nIHRoZSBvbmUgb24gd2hpY2ggZ3J1Yi0yLjAwIGZhaWxlZC4NCg0KVGhhbmtzIQ0KU3R1YXJ0 DQo=