From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4613 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785Ab2E0R6N (ORCPT ); Sun, 27 May 2012 13:58:13 -0400 Message-ID: <4FC26B39.6090106@redhat.com> Date: Sun, 27 May 2012 19:58:17 +0200 From: Hans de Goede MIME-Version: 1.0 To: Hans Verkuil CC: linux-media@vger.kernel.org, halli manjunatha , Hans Verkuil Subject: Re: [RFCv1 PATCH 2/5] v4l2 spec: document the new v4l2_tuner capabilities References: <1338119425-17274-1-git-send-email-hverkuil@xs4all.nl> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Small typo, see comment inline, with that fixed: Acked-by: Hans de Goede On 05/27/2012 01:50 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Update the spec with the new capabilities and specify new error codes for > S_HW_FREQ_SEEK. > > Signed-off-by: Hans Verkuil > --- > .../DocBook/media/v4l/vidioc-g-frequency.xml | 6 ++++++ > Documentation/DocBook/media/v4l/vidioc-g-tuner.xml | 12 ++++++++++++ > .../DocBook/media/v4l/vidioc-s-hw-freq-seek.xml | 18 +++++++++++++++--- > 3 files changed, 33 insertions(+), 3 deletions(-) > > diff --git a/Documentation/DocBook/media/v4l/vidioc-g-frequency.xml b/Documentation/DocBook/media/v4l/vidioc-g-frequency.xml > index 69c178a..40e58a4 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-g-frequency.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-g-frequency.xml > @@ -135,6 +135,12 @@ bounds or the value in thetype field is > wrong. > > > + > + EBUSY > + > + A hardware seek is in progress. > + > + > > > > diff --git a/Documentation/DocBook/media/v4l/vidioc-g-tuner.xml b/Documentation/DocBook/media/v4l/vidioc-g-tuner.xml > index 62a1aa2..95d5371 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-g-tuner.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-g-tuner.xml > @@ -276,6 +276,18 @@ can or must be switched. (B/G PAL tuners for example are typically not > V4L2_TUNER_ANALOG_TV tuners can have this capability. > > > + V4L2_TUNER_CAP_HWSEEK_BOUNDED > + 0x0004 > + If set, then this tuner supports the hardware seek functionality > + where the seek stops when it reaches the end of the frequency range. > + > + > + V4L2_TUNER_CAP_HWSEEK_WRAP > + 0x0008 > + If set, then this tuner supports the hardware seek functionality > + where the seek wraps around when it reaches the end of the frequency range. > + > + > V4L2_TUNER_CAP_STEREO > 0x0010 > Stereo audio reception is supported. > diff --git a/Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.xml b/Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.xml > index 407dfce..d58b648 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-s-hw-freq-seek.xml > @@ -58,6 +58,9 @@ To do this applications initialize thetuner, > call theVIDIOC_S_HW_FREQ_SEEK ioctl with a pointer > to this structure. > > +If an error is returned, then the frequency original frequency will > + be restored. > + One frequency too many in that sentence :) > This ioctl is supported if theV4L2_CAP_HW_FREQ_SEEK capability is set. > > > @@ -87,7 +90,10 @@ field and the&v4l2-tuner;index field. > > __u32 > wrap_around > - If non-zero, wrap around when at the end of the frequency range, else stop seeking. > + If non-zero, wrap around when at the end of the frequency range, else stop seeking. > + The&v4l2-tuner;capability field will tell you what the > + hardware supports. > + > > > __u32 > @@ -118,9 +124,15 @@ wrong. > > > > - EAGAIN > + ENODATA > + > + The hardware seek found no channels. > + > + > + > + EBUSY > > - The ioctl timed-out. Try again. > + Another hardware seek is already in progress. > > >