From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
lliubbo@gmail.com, rayagond@vayavyalabs.com
Subject: Re: [net] stmmac: fix driver Kconfig when built as module
Date: Mon, 28 May 2012 07:44:40 +0200 [thread overview]
Message-ID: <4FC310C8.3000300@st.com> (raw)
In-Reply-To: <20120523.140139.197296963542601285.davem@davemloft.net>
On 5/23/2012 8:01 PM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> Date: Wed, 23 May 2012 08:05:42 +0200
>
>> This patches fixes the driver when built as dyn module.
>> In fact the platform part cannot be built and the probe fails
>> (thanks to Bob Liu that reported this bug).
>> The patch also makes the selection of Platform and PCI parts
>> mutually exclusive.
>>
>> Reported-by: Bob Liu <lliubbo@gmail.com>
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
>
> We have drivers which support both OF (which is implemented as
> platform bus) and PCI at the same time. For example,
> drivers/net/ethernet/sun/niu.c
>
> I do not see why stmmac cannot support both at the same time as well.
>
> I absolutely do not want such segregation unless it is absolutely
> necessary. Because it means that no matter what is choosen, a piece
> of code is disabled and therefore not getting build and/or runtime
> validation.
Ok, I'll review it and resend all the patches asap.
Regards
Peppe
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-05-28 5:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 7:38 [PATCH 1/3] drivers: net: stmmac: add blackfin support Bob Liu
2012-05-22 7:38 ` [PATCH 2/3] drivers: net: ethernet: stmmac: fix failure in module test Bob Liu
2012-05-22 11:56 ` Ben Hutchings
2012-05-22 12:51 ` Giuseppe CAVALLARO
2012-05-23 5:09 ` Bob Liu
2012-05-23 6:08 ` Giuseppe CAVALLARO
2012-05-23 6:05 ` [net] stmmac: fix driver Kconfig when built as module Giuseppe CAVALLARO
2012-05-23 18:01 ` David Miller
2012-05-28 5:44 ` Giuseppe CAVALLARO [this message]
2012-05-22 7:38 ` [PATCH 3/3] drivers: net: ethernet: stmmac: fix resume function Bob Liu
2012-05-22 12:36 ` [PATCH 1/3] drivers: net: stmmac: add blackfin support Giuseppe CAVALLARO
2012-05-23 7:58 ` Bob Liu
2012-05-23 8:21 ` Giuseppe CAVALLARO
2012-05-23 8:27 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC310C8.3000300@st.com \
--to=peppe.cavallaro@st.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=lliubbo@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rayagond@vayavyalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.