From: Stefan Weil <sw@weilnetz.de>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
"Jan Kiszka (maintainer:SLIRP)" <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH for-1.1?] slirp: Avoid redefining MAX_TCPOPTLEN
Date: Mon, 28 May 2012 09:00:23 +0200 [thread overview]
Message-ID: <4FC32287.2060206@weilnetz.de> (raw)
In-Reply-To: <4FC3200E.8040005@redhat.com>
Am 28.05.2012 08:49, schrieb Paolo Bonzini:
> Il 27/05/2012 19:02, Andreas Färber ha scritto:
>> MAX_TCPOPTLEN is being defined as 32. Darwin has it as 40, causing a
>> warning. The value is only used to declare an array, into which currently
>> 4 bytes are written at most. It should therefore be acceptable to adopt
>> the host's definition.
Can we be sure that there will be never a build environment
which defines MAX_TCPOPTLENto a value less than 4?
If not, either the preprocessor or an assertion should test
that, or we could use QEMU_MAX_TCPOPTLEN or SLIRP_MAX_TCPOPTLEN.
Regards,
Stefan W.
next prev parent reply other threads:[~2012-05-28 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 17:02 [Qemu-devel] [PATCH for-1.1?] slirp: Avoid redefining MAX_TCPOPTLEN Andreas Färber
2012-05-28 6:49 ` Paolo Bonzini
2012-05-28 7:00 ` Stefan Weil [this message]
2012-05-28 11:40 ` Jan Kiszka
2012-05-28 14:45 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC32287.2060206@weilnetz.de \
--to=sw@weilnetz.de \
--cc=andreas.faerber@web.de \
--cc=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.