From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] video: atmel/lcd: add LCD driver for Atmel new SoC
Date: Mon, 28 May 2012 15:31:59 +0800 [thread overview]
Message-ID: <4FC329EF.8050503@atmel.com> (raw)
In-Reply-To: <20120525130412.135283e9@wker>
Hi Anatolig,
On 5/25/2012 19:04, Anatolij Gustschin wrote:
> Hi,
>
> On Tue, 22 May 2012 16:47:29 +0800
> Bo Shen<voice.shen@atmel.com> wrote:
> ...
>> diff --git a/drivers/video/atmel_hlcdfb.c b/drivers/video/atmel_hlcdfb.c
>> new file mode 100644
>> index 0000000..0fd7800
>> --- /dev/null
>> +++ b/drivers/video/atmel_hlcdfb.c
> ...
>> +#define lcdc_readl(mmio, reg) __raw_readl((mmio)+(reg))
>> +#define lcdc_writel(mmio, reg, val) __raw_writel((val), (mmio)+(reg))
>
> Wolfgang won't accept base + offset for register access, we should use
> struct instead. Converted patch is on the way, please review/test.
This converted patch has been verified. It works well on Atmel SoC
(at91sam9x5ek, and etc).
>
> Thanks,
> Anatolij
prev parent reply other threads:[~2012-05-28 7:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 8:47 [U-Boot] [PATCH v2] video: atmel/lcd: add LCD driver for Atmel new SoC Bo Shen
2012-05-25 10:59 ` [U-Boot] [PATCH v3] video: atmel/lcd: add LCD driver for new Atmel SoC Anatolij Gustschin
2012-05-28 7:33 ` Bo Shen
2012-06-04 20:54 ` Anatolij Gustschin
2012-05-25 11:04 ` [U-Boot] [PATCH v2] video: atmel/lcd: add LCD driver for Atmel new SoC Anatolij Gustschin
2012-05-28 7:31 ` Bo Shen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC329EF.8050503@atmel.com \
--to=voice.shen@atmel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.