From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH v3 07/16] block: Rename bio_split() -> bio_pair_split() Date: Mon, 28 May 2012 13:15:39 +0300 Message-ID: <4FC3504B.7000903@panasas.com> References: <1337977539-16977-1-git-send-email-koverstreet@google.com> <1337977539-16977-8-git-send-email-koverstreet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1337977539-16977-8-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kent Overstreet Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, neilb-l3A5Bk7waGM@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org, yehuda-L5o5AL9CYN0tUFlbccrkMA@public.gmane.org List-Id: dm-devel.ids On 05/25/2012 11:25 PM, Kent Overstreet wrote: > This is prep work for introducing a more general bio_split() > > Change-Id: Ib9c4ff691af889d26bc9ec9fb42a2f3068f34ad9 > Since these patches will go through Jens tree this kind of comment can *never* be true/correct. And it is plenty unwanted for sure. Here: bio_do means an operation on bio. But here we are actually operating on a bio_pair. So rename it it to bio_pair_do. We will later introduce a real bio_split() function that receives a bio and splits it. Or something like that. Thanks Boaz > Signed-off-by: Kent Overstreet > @@ -201,7 +201,7 @@ struct bio_pair { > atomic_t cnt; > int error; > }; > -extern struct bio_pair *bio_split(struct bio *bi, int first_sectors); > +extern struct bio_pair *bio_pair_split(struct bio *bi, int first_sectors); > extern void bio_pair_release(struct bio_pair *dbio); > > extern struct bio_set *bioset_create(unsigned int, unsigned int); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.linbit.com (zimbra.linbit.com [212.69.161.123]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 6CEC81011BE7 for ; Wed, 30 May 2012 10:41:02 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra.linbit.com (Postfix) with ESMTP id 66D811B435D for ; Wed, 30 May 2012 10:41:02 +0200 (CEST) Received: from zimbra.linbit.com ([127.0.0.1]) by localhost (zimbra.linbit.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lr9HeFR+bIPL for ; Wed, 30 May 2012 10:41:02 +0200 (CEST) Received: from soda.linbit (tuerlsteher.linbit.com [86.59.100.100]) by zimbra.linbit.com (Postfix) with ESMTP id 492C01B435C for ; Wed, 30 May 2012 10:41:02 +0200 (CEST) Resent-Message-ID: <20120530084102.GL4141@soda.linbit> Received: from natasha.panasas.com (natasha.panasas.com [67.152.220.90]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 55DBB1019A78 for ; Mon, 28 May 2012 12:16:44 +0200 (CEST) Message-ID: <4FC3504B.7000903@panasas.com> Date: Mon, 28 May 2012 13:15:39 +0300 From: Boaz Harrosh MIME-Version: 1.0 To: Kent Overstreet References: <1337977539-16977-1-git-send-email-koverstreet@google.com> <1337977539-16977-8-git-send-email-koverstreet@google.com> In-Reply-To: <1337977539-16977-8-git-send-email-koverstreet@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: axboe@kernel.dk, dm-devel@redhat.com, neilb@suse.de, linux-kernel@vger.kernel.org, tj@kernel.org, linux-bcache@vger.kernel.org, mpatocka@redhat.com, vgoyal@redhat.com, yehuda@hq.newdream.net, linux-fsdevel@vger.kernel.org, sage@newdream.net, agk@redhat.com, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH v3 07/16] block: Rename bio_split() -> bio_pair_split() List-Id: Coordination of development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 05/25/2012 11:25 PM, Kent Overstreet wrote: > This is prep work for introducing a more general bio_split() > > Change-Id: Ib9c4ff691af889d26bc9ec9fb42a2f3068f34ad9 > Since these patches will go through Jens tree this kind of comment can *never* be true/correct. And it is plenty unwanted for sure. Here: bio_do means an operation on bio. But here we are actually operating on a bio_pair. So rename it it to bio_pair_do. We will later introduce a real bio_split() function that receives a bio and splits it. Or something like that. Thanks Boaz > Signed-off-by: Kent Overstreet > @@ -201,7 +201,7 @@ struct bio_pair { > atomic_t cnt; > int error; > }; > -extern struct bio_pair *bio_split(struct bio *bi, int first_sectors); > +extern struct bio_pair *bio_pair_split(struct bio *bi, int first_sectors); > extern void bio_pair_release(struct bio_pair *dbio); > > extern struct bio_set *bioset_create(unsigned int, unsigned int); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH v3 07/16] block: Rename bio_split() -> bio_pair_split() Date: Mon, 28 May 2012 13:15:39 +0300 Message-ID: <4FC3504B.7000903@panasas.com> References: <1337977539-16977-1-git-send-email-koverstreet@google.com> <1337977539-16977-8-git-send-email-koverstreet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , , , , , , , , , , , , To: Kent Overstreet Return-path: In-Reply-To: <1337977539-16977-8-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On 05/25/2012 11:25 PM, Kent Overstreet wrote: > This is prep work for introducing a more general bio_split() > > Change-Id: Ib9c4ff691af889d26bc9ec9fb42a2f3068f34ad9 > Since these patches will go through Jens tree this kind of comment can *never* be true/correct. And it is plenty unwanted for sure. Here: bio_do means an operation on bio. But here we are actually operating on a bio_pair. So rename it it to bio_pair_do. We will later introduce a real bio_split() function that receives a bio and splits it. Or something like that. Thanks Boaz > Signed-off-by: Kent Overstreet > @@ -201,7 +201,7 @@ struct bio_pair { > atomic_t cnt; > int error; > }; > -extern struct bio_pair *bio_split(struct bio *bi, int first_sectors); > +extern struct bio_pair *bio_pair_split(struct bio *bi, int first_sectors); > extern void bio_pair_release(struct bio_pair *dbio); > > extern struct bio_set *bioset_create(unsigned int, unsigned int); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478Ab2E1KQx (ORCPT ); Mon, 28 May 2012 06:16:53 -0400 Received: from natasha.panasas.com ([67.152.220.90]:45714 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753228Ab2E1KQu (ORCPT ); Mon, 28 May 2012 06:16:50 -0400 Message-ID: <4FC3504B.7000903@panasas.com> Date: Mon, 28 May 2012 13:15:39 +0300 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111113 Thunderbird/8.0 MIME-Version: 1.0 To: Kent Overstreet CC: , , , , , , , , , , , , Subject: Re: [PATCH v3 07/16] block: Rename bio_split() -> bio_pair_split() References: <1337977539-16977-1-git-send-email-koverstreet@google.com> <1337977539-16977-8-git-send-email-koverstreet@google.com> In-Reply-To: <1337977539-16977-8-git-send-email-koverstreet@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2012 11:25 PM, Kent Overstreet wrote: > This is prep work for introducing a more general bio_split() > > Change-Id: Ib9c4ff691af889d26bc9ec9fb42a2f3068f34ad9 > Since these patches will go through Jens tree this kind of comment can *never* be true/correct. And it is plenty unwanted for sure. Here: bio_do means an operation on bio. But here we are actually operating on a bio_pair. So rename it it to bio_pair_do. We will later introduce a real bio_split() function that receives a bio and splits it. Or something like that. Thanks Boaz > Signed-off-by: Kent Overstreet > @@ -201,7 +201,7 @@ struct bio_pair { > atomic_t cnt; > int error; > }; > -extern struct bio_pair *bio_split(struct bio *bi, int first_sectors); > +extern struct bio_pair *bio_pair_split(struct bio *bi, int first_sectors); > extern void bio_pair_release(struct bio_pair *dbio); > > extern struct bio_set *bioset_create(unsigned int, unsigned int);