From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jun'ichi Nomura" Subject: Re: [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info Date: Mon, 28 May 2012 20:41:18 +0900 Message-ID: <4FC3645E.8040901@ce.jp.nec.com> References: <1337977539-16977-1-git-send-email-koverstreet@google.com> <1337977539-16977-3-git-send-email-koverstreet@google.com> <4FC2CD93.1080009@ce.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FC2CD93.1080009-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kent Overstreet Cc: device-mapper development , axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yehuda-L5o5AL9CYN0tUFlbccrkMA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org List-Id: dm-devel.ids On 05/28/12 09:57, Jun'ichi Nomura wrote: > On 05/26/12 05:25, Kent Overstreet wrote: >> - pools->bs = bioset_create(pool_size, 0); >> + pools->bs = bioset_create(pool_size, >> + offsetof(struct dm_rq_clone_bio_info, orig)); >> if (!pools->bs) >> goto free_tio_pool_and_out; > > Did you mean offset of *clone*? > "offsetof(struct dm_rq_clone_bio_info, orig)" is zero. Additional comment: frontpad is not necessary if type is DM_TYPE_BIO_BASED. Please check conditional switches done in the same function for pools->tio_pool. -- Jun'ichi Nomura, NEC Corporation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.linbit.com (zimbra.linbit.com [212.69.161.123]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 8F0CA10003DC for ; Wed, 30 May 2012 10:41:03 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra.linbit.com (Postfix) with ESMTP id 88BEB1B435D for ; Wed, 30 May 2012 10:41:03 +0200 (CEST) Received: from zimbra.linbit.com ([127.0.0.1]) by localhost (zimbra.linbit.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cXzaZvzVgov9 for ; Wed, 30 May 2012 10:41:03 +0200 (CEST) Received: from soda.linbit (tuerlsteher.linbit.com [86.59.100.100]) by zimbra.linbit.com (Postfix) with ESMTP id 6CAA61B435C for ; Wed, 30 May 2012 10:41:03 +0200 (CEST) Resent-Message-ID: <20120530084103.GM4141@soda.linbit> Received: from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [202.32.8.206]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id 39DA21019A68 for ; Mon, 28 May 2012 13:42:16 +0200 (CEST) Message-ID: <4FC3645E.8040901@ce.jp.nec.com> Date: Mon, 28 May 2012 20:41:18 +0900 From: "Jun'ichi Nomura" MIME-Version: 1.0 To: Kent Overstreet References: <1337977539-16977-1-git-send-email-koverstreet@google.com> <1337977539-16977-3-git-send-email-koverstreet@google.com> <4FC2CD93.1080009@ce.jp.nec.com> In-Reply-To: <4FC2CD93.1080009@ce.jp.nec.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: axboe@kernel.dk, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, device-mapper development , mpatocka@redhat.com, vgoyal@redhat.com, sage@newdream.net, bharrosh@panasas.com, tj@kernel.org, yehuda@hq.newdream.net, agk@redhat.com, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info List-Id: Coordination of development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 05/28/12 09:57, Jun'ichi Nomura wrote: > On 05/26/12 05:25, Kent Overstreet wrote: >> - pools->bs = bioset_create(pool_size, 0); >> + pools->bs = bioset_create(pool_size, >> + offsetof(struct dm_rq_clone_bio_info, orig)); >> if (!pools->bs) >> goto free_tio_pool_and_out; > > Did you mean offset of *clone*? > "offsetof(struct dm_rq_clone_bio_info, orig)" is zero. Additional comment: frontpad is not necessary if type is DM_TYPE_BIO_BASED. Please check conditional switches done in the same function for pools->tio_pool. -- Jun'ichi Nomura, NEC Corporation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754148Ab2E1LmG (ORCPT ); Mon, 28 May 2012 07:42:06 -0400 Received: from TYO202.gate.nec.co.jp ([202.32.8.206]:59483 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753677Ab2E1LmE (ORCPT ); Mon, 28 May 2012 07:42:04 -0400 Message-ID: <4FC3645E.8040901@ce.jp.nec.com> Date: Mon, 28 May 2012 20:41:18 +0900 From: "Jun'ichi Nomura" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Kent Overstreet CC: device-mapper development , axboe@kernel.dk, linux-kernel@vger.kernel.org, tj@kernel.org, linux-bcache@vger.kernel.org, mpatocka@redhat.com, agk@redhat.com, bharrosh@panasas.com, linux-fsdevel@vger.kernel.org, yehuda@hq.newdream.net, drbd-dev@lists.linbit.com, vgoyal@redhat.com, sage@newdream.net Subject: Re: [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info References: <1337977539-16977-1-git-send-email-koverstreet@google.com> <1337977539-16977-3-git-send-email-koverstreet@google.com> <4FC2CD93.1080009@ce.jp.nec.com> In-Reply-To: <4FC2CD93.1080009@ce.jp.nec.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/28/12 09:57, Jun'ichi Nomura wrote: > On 05/26/12 05:25, Kent Overstreet wrote: >> - pools->bs = bioset_create(pool_size, 0); >> + pools->bs = bioset_create(pool_size, >> + offsetof(struct dm_rq_clone_bio_info, orig)); >> if (!pools->bs) >> goto free_tio_pool_and_out; > > Did you mean offset of *clone*? > "offsetof(struct dm_rq_clone_bio_info, orig)" is zero. Additional comment: frontpad is not necessary if type is DM_TYPE_BIO_BASED. Please check conditional switches done in the same function for pools->tio_pool. -- Jun'ichi Nomura, NEC Corporation