From: Avi Kivity <avi@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>, TeLeMan <geleman@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion
Date: Mon, 28 May 2012 15:04:18 +0300 [thread overview]
Message-ID: <4FC369C2.3000503@redhat.com> (raw)
In-Reply-To: <CAMo8Bf+XtppLqX-64Doeg6V_3vfvKe8goSfztizmNKOVPZvUsA@mail.gmail.com>
On 05/28/2012 02:54 PM, Max Filippov wrote:
>>>
>>> Right. If the fix is going to be checked in then TeLeMan's original version
>>> with '|' is preferable for this reason.
>>
>> I disagree. Whatever we call cpu_get_phys_page_debug() has to either
>> mask out the low bits, or not (I prefer the latter, since it's
>> unambiguous for large pages), but it has to be consistent. Once it's
>> consistent, there's no reason to use clever tricks.
>
> I meant a one line fix for the 1.1. I suspect that fixing entire
> cpu_get_phys_page_debug thing for 1.1 is too risky.
>
Agree for 1.1.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2012-05-28 12:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 2:34 [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion Jan Kiszka
2012-05-24 2:44 ` Jan Kiszka
2012-05-24 10:51 ` Max Filippov
2012-05-24 11:25 ` Jan Kiszka
2012-05-24 12:08 ` Max Filippov
2012-05-24 12:16 ` Jan Kiszka
2012-05-24 12:42 ` Max Filippov
2012-05-24 13:26 ` Jan Kiszka
2012-05-24 14:11 ` Max Filippov
2012-05-24 14:21 ` Jan Kiszka
2012-05-24 14:29 ` Max Filippov
2012-05-24 14:34 ` Jan Kiszka
2012-05-24 14:26 ` Avi Kivity
2012-05-24 19:58 ` Max Filippov
2012-05-28 9:34 ` Avi Kivity
2012-05-28 11:54 ` Max Filippov
2012-05-28 12:04 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC369C2.3000503@redhat.com \
--to=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=geleman@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.