All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 2/2] [media] firedtv: Port it to use rc_core
Date: Mon, 28 May 2012 11:41:55 -0300	[thread overview]
Message-ID: <4FC38EB3.8010000@redhat.com> (raw)
In-Reply-To: <20120528161432.50a6ca45@stein>

Em 28-05-2012 11:14, Stefan Richter escreveu:
> On May 28 Stefan Richter wrote:
>>> +	idev->phys = "/ir0";		/* FIXME */  
>>
>> Something similar to drivers/media/dvb/dvb-usb/dvb-usb-remote.c::
>>
>> 	usb_make_path(d->udev, d->rc_phys, sizeof(d->rc_phys));
>> 	strlcat(d->rc_phys, "/ir0", sizeof(d->rc_phys));
>>
>> should be implemented for this, right?
> 
> PS:
> The current input device looks like this:
> 
> /sys/devices/pci0000:00/0000:00:02.0/0000:02:00.0/0000:03:01.0/0000:04:00.0/fw7/fw7.0/input/input8/device -> ../../../fw7.0
> 
> "fw7.0" is dev_name(dev) in fdtv_register_rc() or dev_name(fdtv->device)
> in general in firedtv.
> 
> The last numeric name before fw7, i.e. 0000:04:00.0, is the name of the PCI
> device of the FireWire controller.  fw7 is the name of the FireDTV node;
> fw7.0 is the name of the (only) unit within the FireDTV node which
> implements the DVB receiver and IR receiver.  What would be needed from
> this?
> 
> FWIW, usb_make_path() results in "usb-%s-%s" % (usb_device.bus.bus_name,
> usb_device.devpath).

IMO, the physical patch is "fw7.0". We add a /ir0 for the first IR device (as a
driver might have more than one IR).

So, the phys should be "fw7.0/ir0".

Regards,
Mauro

  reply	other threads:[~2012-05-28 14:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-28 13:14 [PATCH 1/2] [media] Add a keymap for FireDTV board Mauro Carvalho Chehab
2012-05-28 13:14 ` [PATCH 2/2] [media] firedtv: Port it to use rc_core Mauro Carvalho Chehab
2012-05-28 14:01   ` Stefan Richter
2012-05-28 14:09     ` Mauro Carvalho Chehab
2012-05-28 14:09     ` Mauro Carvalho Chehab
2012-05-28 14:14     ` Stefan Richter
2012-05-28 14:41       ` Mauro Carvalho Chehab [this message]
2012-05-28 13:29 ` [PATCH 1/2] [media] Add a keymap for FireDTV board Stefan Richter
2012-05-28 13:32   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC38EB3.8010000@redhat.com \
    --to=mchehab@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.